From patchwork Tue Sep 24 22:02:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 15264 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 3EE2A449BE7 for ; Wed, 25 Sep 2019 01:03:42 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 284E868A0E5; Wed, 25 Sep 2019 01:03:42 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 75728689D16 for ; Wed, 25 Sep 2019 01:03:35 +0300 (EEST) Received: by mail-wm1-f67.google.com with SMTP id a6so2050641wma.5 for ; Tue, 24 Sep 2019 15:03:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SjmdfFieEGVoesoMlHngjly/l6u9gF6fl1dcZRLHIjw=; b=jGQjQmbJ2Ekopqrh9w2CJiNkDXWGThmBL3sjvXRXot0S+EXuGOO5+7EJsaEa+dPZfq t4R5jTSCsgCaZzC2L4yPG5Q0hP54tm3GeEVJb/4MOlEwqf/1MJoKX6/bjWY+4qhTK/21 0AfO5sUb57+YJoPL6Bt4zdjKu0qv/idBmcNmpak8rW3mvf+t8zrKVoRstd14OCkpFgT9 cMz3ZmwShu1HHqUF8NHAwlgsXWmfZppaqA/cioHkzJSMusIWzE+HBMLTVP4l9r/5a2ys TlhSR/3aCPyavY3kNhVLlc5aGZ9DOT3lRAqC/aJ66z/vp2uIlJkPbdh5YVHeMwftpIg2 hVGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SjmdfFieEGVoesoMlHngjly/l6u9gF6fl1dcZRLHIjw=; b=f5ReSY0Muw0JIXzgIZVFdyWTWZuvNzVsAalrW7TqlhTBCwdYSQ+zNvZjBPxACxNCrp hB3unfzJe2mceS1D8FsP3+oYmPcpRZMHgPDrQyT0dKTRVVbDgTK6BX525wk22sz1BfEh EOJHkfP9JJO0gvIzlh0RBwXiuqo0wQF/OGTE2ppLClQMw+H7VYoR+9PVHPIWtephAYHV 9k+H4MYaZ9OzqakZId+dwfDUZxgcYue+I/GV9Byx5g3vwkJAu4ZsKn5IUeFvLDc2fVXT lhsgr1+41kBlRSkCik2vGUK5aXRz0WBbpzxmTYmquXvUCxMf9JH2GhgsNWgP7ucNs0PY HltQ== X-Gm-Message-State: APjAAAX/AMNA1hgcXCt4icxX+MQirXNl3VTtSwry41NRYK78We7mPDFA XZlJFjnebcYSOLUp2ROYt5o3ckAK X-Google-Smtp-Source: APXvYqxtVDwIJm1vyw41ywice2nXwMdk30chHu13xwI6Hi+BwBHm31Zq3VUYSqtkT3nx+pyTDiLN9A== X-Received: by 2002:a1c:7306:: with SMTP id d6mr3010846wmb.62.1569362614707; Tue, 24 Sep 2019 15:03:34 -0700 (PDT) Received: from sblaptop.fritz.box ([188.192.248.87]) by smtp.gmail.com with ESMTPSA id l1sm3023808wrb.1.2019.09.24.15.03.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2019 15:03:34 -0700 (PDT) From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Wed, 25 Sep 2019 00:02:57 +0200 Message-Id: <20190924220310.31157-3-andreas.rheinhardt@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190924220310.31157-1-andreas.rheinhardt@gmail.com> References: <20190924220310.31157-1-andreas.rheinhardt@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 02/15] avcodec/truespeech: Fix invalid shift X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Fixes the last undefined behaviour in the truespeech FATE-test as well as the last of the truespeech bugs reported in ticket #8159. The other left shifts of negative numbers have already been fixed in c7c0229b. Signed-off-by: Andreas Rheinhardt --- libavcodec/truespeech.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/truespeech.c b/libavcodec/truespeech.c index 54352851b3..bbbf75f06e 100644 --- a/libavcodec/truespeech.c +++ b/libavcodec/truespeech.c @@ -281,7 +281,7 @@ static void truespeech_synth(TSContext *dec, int16_t *out, int quart) ptr0 = dec->tmp3; for(i = 0; i < 60; i++){ - int sum = out[i] << 12; + int sum = FFLSHIFT(out[i], 12); for(k = 0; k < 8; k++) sum += ptr0[k] * t[k]; for(k = 7; k > 0; k--)