diff mbox

[FFmpeg-devel] cmdutils: trailing options may be ignored

Message ID 20190927225153.31276-1-lou@lrcd.com
State Accepted
Commit 61b7676bd5a6ae79e4a607a600d3741c84ec6d8a
Headers show

Commit Message

Lou Logan Sept. 27, 2019, 10:51 p.m. UTC 
Signed-off-by: Lou Logan <lou@lrcd.com>
---
 fftools/cmdutils.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jun Zhao Sept. 29, 2019, 1:04 a.m. UTC | #1 
On Sat, Sep 28, 2019 at 6:52 AM Lou Logan <lou@lrcd.com> wrote:
>
> Signed-off-by: Lou Logan <lou@lrcd.com>
> ---
>  fftools/cmdutils.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
> index 6f4031fbb9..84f98b7c04 100644
> --- a/fftools/cmdutils.c
> +++ b/fftools/cmdutils.c
> @@ -848,8 +848,8 @@ do {                                                                           \
>      }
>
>      if (octx->cur_group.nb_opts || codec_opts || format_opts || resample_opts)
> -        av_log(NULL, AV_LOG_WARNING, "Trailing options were found on the "
> -               "commandline.\n");
> +        av_log(NULL, AV_LOG_WARNING, "Trailing option(s) found in the "
> +               "command: may be ignored.\n");
>
>      av_log(NULL, AV_LOG_DEBUG, "Finished splitting the commandline.\n");
>
> --
LGTM
Lou Logan Oct. 1, 2019, 6:45 p.m. UTC | #2 
On Sat, Sep 28, 2019, at 5:04 PM, mypopy@gmail.com wrote:
>
> LGTM

Pushed
61b7676bd5a6ae79e4a607a600d3741c84ec6d8a
Carl Eugen Hoyos Oct. 1, 2019, 6:52 p.m. UTC | #3 
Am Sa., 28. Sept. 2019 um 00:52 Uhr schrieb Lou Logan <lou@lrcd.com>:
>
> Signed-off-by: Lou Logan <lou@lrcd.com>
> ---
>  fftools/cmdutils.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
> index 6f4031fbb9..84f98b7c04 100644
> --- a/fftools/cmdutils.c
> +++ b/fftools/cmdutils.c
> @@ -848,8 +848,8 @@ do {                                                                           \
>      }
>
>      if (octx->cur_group.nb_opts || codec_opts || format_opts || resample_opts)
> -        av_log(NULL, AV_LOG_WARNING, "Trailing options were found on the "
> -               "commandline.\n");
> +        av_log(NULL, AV_LOG_WARNING, "Trailing option(s) found in the "

> +               "command: may be ignored.\n");

In which case are they not ignored?

Carl Eugen
diff mbox

Patch

diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
index 6f4031fbb9..84f98b7c04 100644
--- a/fftools/cmdutils.c
+++ b/fftools/cmdutils.c
@@ -848,8 +848,8 @@  do {                                                                           \
     }
 
     if (octx->cur_group.nb_opts || codec_opts || format_opts || resample_opts)
-        av_log(NULL, AV_LOG_WARNING, "Trailing options were found on the "
-               "commandline.\n");
+        av_log(NULL, AV_LOG_WARNING, "Trailing option(s) found in the "
+               "command: may be ignored.\n");
 
     av_log(NULL, AV_LOG_DEBUG, "Finished splitting the commandline.\n");