diff mbox

[FFmpeg-devel,3/5] tools/target_dec_fuzzer: Adjust VP7 threshold

Message ID 20190928235345.26528-3-michael@niedermayer.cc
State Accepted
Commit 47b0d0812e7738ee193249d2507b4d1630774614
Headers show

Commit Message

Michael Niedermayer Sept. 28, 2019, 11:53 p.m. UTC
Fixes: Timeout (110sec -> 10sec)
Fixes: 17705/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP7_fuzzer-5765834135306240

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 tools/target_dec_fuzzer.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Peter Ross Sept. 29, 2019, 5:34 a.m. UTC | #1
On Sun, Sep 29, 2019 at 01:53:43AM +0200, Michael Niedermayer wrote:
> Fixes: Timeout (110sec -> 10sec)
> Fixes: 17705/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP7_fuzzer-5765834135306240
> 
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  tools/target_dec_fuzzer.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c
> index 4af7b26e54..a2c59be318 100644
> --- a/tools/target_dec_fuzzer.c
> +++ b/tools/target_dec_fuzzer.c
> @@ -153,6 +153,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
>      case AV_CODEC_ID_MSS2:        maxpixels /= 16384; break;
>      case AV_CODEC_ID_SNOW:        maxpixels /= 128; break;
>      case AV_CODEC_ID_TRUEMOTION2: maxpixels /= 1024; break;
> +    case AV_CODEC_ID_VP7:         maxpixels /= 256;  break;
>      }

ok. however i am curious why this is needed for vp7 and not vp8.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
Michael Niedermayer Sept. 29, 2019, 3:45 p.m. UTC | #2
On Sun, Sep 29, 2019 at 03:34:33PM +1000, Peter Ross wrote:
> On Sun, Sep 29, 2019 at 01:53:43AM +0200, Michael Niedermayer wrote:
> > Fixes: Timeout (110sec -> 10sec)
> > Fixes: 17705/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP7_fuzzer-5765834135306240
> > 
> > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  tools/target_dec_fuzzer.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c
> > index 4af7b26e54..a2c59be318 100644
> > --- a/tools/target_dec_fuzzer.c
> > +++ b/tools/target_dec_fuzzer.c
> > @@ -153,6 +153,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
> >      case AV_CODEC_ID_MSS2:        maxpixels /= 16384; break;
> >      case AV_CODEC_ID_SNOW:        maxpixels /= 128; break;
> >      case AV_CODEC_ID_TRUEMOTION2: maxpixels /= 1024; break;
> > +    case AV_CODEC_ID_VP7:         maxpixels /= 256;  break;
> >      }
> 
> ok. however i am curious why this is needed for vp7 and not vp8.

The CPU time was spend in vp7_fade_frame() i dont see a similar
call for vp8 but maybe the fuzzer will find something in vp8
too eventually

will apply

thx

[...]
diff mbox

Patch

diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c
index 4af7b26e54..a2c59be318 100644
--- a/tools/target_dec_fuzzer.c
+++ b/tools/target_dec_fuzzer.c
@@ -153,6 +153,7 @@  int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
     case AV_CODEC_ID_MSS2:        maxpixels /= 16384; break;
     case AV_CODEC_ID_SNOW:        maxpixels /= 128; break;
     case AV_CODEC_ID_TRUEMOTION2: maxpixels /= 1024; break;
+    case AV_CODEC_ID_VP7:         maxpixels /= 256;  break;
     }