[FFmpeg-devel,4/5] avcodec/alac: Fix integer overflow in LPC

Submitted by Michael Niedermayer on Sept. 30, 2019, 11:12 p.m.

Details

Message ID 20190930231254.23993-4-michael@niedermayer.cc
State New
Headers show

Commit Message

Michael Niedermayer Sept. 30, 2019, 11:12 p.m.
Fixes: signed integer overflow: 2147483628 + 128 cannot be represented in type 'int'
Fixes: 17783/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5146470595952640

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/alac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/libavcodec/alac.c b/libavcodec/alac.c
index fbe427595e..09decb806b 100644
--- a/libavcodec/alac.c
+++ b/libavcodec/alac.c
@@ -215,7 +215,7 @@  static void lpc_prediction(int32_t *error_buffer, uint32_t *buffer_out,
         /* LPC prediction */
         for (j = 0; j < lpc_order; j++)
             val += (pred[j] - d) * lpc_coefs[j];
-        val = (val + (1 << (lpc_quant - 1))) >> lpc_quant;
+        val = (val + (1LL << (lpc_quant - 1))) >> lpc_quant;
         val += d + error_val;
         buffer_out[i] = sign_extend(val, bps);