[FFmpeg-devel,v2,12/14] avfilter/vf_scale_qsv: add logging context to log

Submitted by Steven Liu on Oct. 2, 2019, 6:58 a.m.

Details

Message ID 20191002065815.30333-12-lq@chinaffmpeg.org
State New
Headers show

Commit Message

Steven Liu Oct. 2, 2019, 6:58 a.m.
Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
---
 libavfilter/vf_scale_qsv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zhong Li Oct. 8, 2019, 7:08 a.m.
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Steven

> Liu

> Sent: Wednesday, October 2, 2019 2:58 PM

> To: ffmpeg-devel@ffmpeg.org

> Cc: Steven Liu <lq@chinaffmpeg.org>

> Subject: [FFmpeg-devel] [PATCH v2 12/14] avfilter/vf_scale_qsv: add logging

> context to log

> 

> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>

> ---

>  libavfilter/vf_scale_qsv.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/libavfilter/vf_scale_qsv.c b/libavfilter/vf_scale_qsv.c index

> 3cc05b64f3..1cf5367969 100644

> --- a/libavfilter/vf_scale_qsv.c

> +++ b/libavfilter/vf_scale_qsv.c

> @@ -541,7 +541,7 @@ static int qsvscale_config_props(AVFilterLink *outlink)

>      return 0;

> 

>  fail:

> -    av_log(NULL, AV_LOG_ERROR,

> +    av_log(ctx, AV_LOG_ERROR,

>             "Error when evaluating the expression '%s'\n", expr);

>      return ret;

>  }

> --

> 2.15.1


LGTM
Steven Liu Oct. 8, 2019, 7:13 a.m.
> 在 2019年10月8日,15:08,Li, Zhong <zhong.li@intel.com> 写道:
> 
>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Steven
>> Liu
>> Sent: Wednesday, October 2, 2019 2:58 PM
>> To: ffmpeg-devel@ffmpeg.org
>> Cc: Steven Liu <lq@chinaffmpeg.org>
>> Subject: [FFmpeg-devel] [PATCH v2 12/14] avfilter/vf_scale_qsv: add logging
>> context to log
>> 
>> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
>> ---
>> libavfilter/vf_scale_qsv.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/libavfilter/vf_scale_qsv.c b/libavfilter/vf_scale_qsv.c index
>> 3cc05b64f3..1cf5367969 100644
>> --- a/libavfilter/vf_scale_qsv.c
>> +++ b/libavfilter/vf_scale_qsv.c
>> @@ -541,7 +541,7 @@ static int qsvscale_config_props(AVFilterLink *outlink)
>>     return 0;
>> 
>> fail:
>> -    av_log(NULL, AV_LOG_ERROR,
>> +    av_log(ctx, AV_LOG_ERROR,
>>            "Error when evaluating the expression '%s'\n", expr);
>>     return ret;
>> }
>> --
>> 2.15.1
> 
> LGTM
patchset have been applied.
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Thanks
Steven

Patch hide | download patch | download mbox

diff --git a/libavfilter/vf_scale_qsv.c b/libavfilter/vf_scale_qsv.c
index 3cc05b64f3..1cf5367969 100644
--- a/libavfilter/vf_scale_qsv.c
+++ b/libavfilter/vf_scale_qsv.c
@@ -541,7 +541,7 @@  static int qsvscale_config_props(AVFilterLink *outlink)
     return 0;
 
 fail:
-    av_log(NULL, AV_LOG_ERROR,
+    av_log(ctx, AV_LOG_ERROR,
            "Error when evaluating the expression '%s'\n", expr);
     return ret;
 }