diff mbox

[FFmpeg-devel,v1,05/11] avformat/libmodplug: fix memleak when load modplug failed

Message ID 20191009073530.4505-5-lq@chinaffmpeg.org
State Accepted
Commit 22eae2d0c9fc5d5847bb7b64debe8d4b72fdff01
Headers show

Commit Message

Liu Steven Oct. 9, 2019, 7:35 a.m. UTC 
Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
---
 libavformat/libmodplug.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff mbox

Patch

diff --git a/libavformat/libmodplug.c b/libavformat/libmodplug.c
index 314bdae3e7..d4f78d99b1 100644
--- a/libavformat/libmodplug.c
+++ b/libavformat/libmodplug.c
@@ -216,9 +216,10 @@  static int modplug_read_header(AVFormatContext *s)
     ModPlug_SetSettings(&settings);
 
     modplug->f = ModPlug_Load(modplug->buf, sz);
-    if (!modplug->f)
+    if (!modplug->f) {
+        av_freep(&modplug->buf);
         return AVERROR_INVALIDDATA;
-
+    }
     st = avformat_new_stream(s, NULL);
     if (!st)
         return AVERROR(ENOMEM);