From patchwork Wed Oct 9 09:56:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul B Mahol X-Patchwork-Id: 15602 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 544AE44696F for ; Wed, 9 Oct 2019 12:57:11 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3CFBE6881B2; Wed, 9 Oct 2019 12:57:11 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9B5FA688192 for ; Wed, 9 Oct 2019 12:57:03 +0300 (EEST) Received: by mail-wm1-f68.google.com with SMTP id 3so1831254wmi.3 for ; Wed, 09 Oct 2019 02:57:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=iJB/+xDIAxojWKk2bFtb+6ONQ2oGFYDAMuVJtzu6eHA=; b=se4ZE/VAfLBcAmrw3W6YFwwCgGdE0gl0jvoV+dytXCEY79f8oflfAGKhPE3FtGR/OS cvB0PjVZgOYHmdlTB7e9EsZ0ooh0cHUnW1hDzcAmPK7VUiF1JDfUtS9YMH5ywk7NMA9v mtatnsMQJhOTeGB4xTiNZxbAnvkomKPk87hBP5xVUvOnHRj1UNRcGACZtfh2URqr6Vss /b927yxW7bKMdsi3G6Y1AMvLQIVTcjj3q4d76QU4SMUMzpJN/43bb+8SQUjyedulnK/9 Vvm1ZAlUpVNPKhKvLJ1qbVEaXaEtIzc74H7L35Uo8tl3D6l1UvY3dCjMDRMuXg6T1QPW zCbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=iJB/+xDIAxojWKk2bFtb+6ONQ2oGFYDAMuVJtzu6eHA=; b=IELbB7SC3XFozjuhNfGMHJDHNlvkBFuCDBgbSaUxubli9OWrEE5fJKkdjQMF2N+Md1 s94cey4AjefcYbe1Gyn+Ts+Ma1SxHGXFx8jJHVXqo+Nvbt+sbPQZKVyyR4gahef4HR1r /vscJqgkocOgi79qkcyys39MPHDByn2ni6wYoxQFjGqDyTyqtvCGQdrLUjNa9jg2IEJT ksjSYHH1It7/v6zlfzj7fMiHeV6I3mQCsgaY6MpvLrG6w3QUYsgf1dH+2zbciIdNBJL3 KR9YUh0iAeCTwJwzqYUk2M+KUNsFfLh4H9gZqv64vP+A/+XI9+Uk4BnjBJgwez8PU/Lf 7Zrg== X-Gm-Message-State: APjAAAXZOPrYPG5CMxco2lMdDsgxqfWePbA/MngIF1Y+xf09F+88ohX4 gBy1TviCMEdHOf2NqTco5nxS/ErF X-Google-Smtp-Source: APXvYqznvaiFcRRxso48SeQgIytcA1xNrM7wrJ8HJZiku8+BOiQLbzaHx0UbHdREfRnRbMIGPvNo6w== X-Received: by 2002:a1c:81d7:: with SMTP id c206mr1832545wmd.175.1570615022786; Wed, 09 Oct 2019 02:57:02 -0700 (PDT) Received: from localhost.localdomain ([37.244.241.148]) by smtp.gmail.com with ESMTPSA id s9sm1964315wme.36.2019.10.09.02.57.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 02:57:02 -0700 (PDT) From: Paul B Mahol To: ffmpeg-devel@ffmpeg.org Date: Wed, 9 Oct 2019 11:56:42 +0200 Message-Id: <20191009095651.2928-4-onemda@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191009095651.2928-1-onemda@gmail.com> References: <20191009095651.2928-1-onemda@gmail.com> Subject: [FFmpeg-devel] [PATCH 04/13] avfilter/af_anlms: switch to ff_filter_process_command() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Signed-off-by: Paul B Mahol --- libavfilter/af_anlms.c | 27 ++++++--------------------- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/libavfilter/af_anlms.c b/libavfilter/af_anlms.c index 75bd969a83..b618e2367d 100644 --- a/libavfilter/af_anlms.c +++ b/libavfilter/af_anlms.c @@ -60,13 +60,14 @@ typedef struct AudioNLMSContext { #define OFFSET(x) offsetof(AudioNLMSContext, x) #define A AV_OPT_FLAG_AUDIO_PARAM|AV_OPT_FLAG_FILTERING_PARAM +#define C AV_OPT_FLAG_COMMAND_PARAM static const AVOption anlms_options[] = { { "order", "set the filter order", OFFSET(order), AV_OPT_TYPE_INT, {.i64=256}, 1, INT16_MAX, A }, - { "mu", "set the filter mu", OFFSET(mu), AV_OPT_TYPE_FLOAT, {.dbl=0.75}, 0, 1, A }, - { "eps", "set the filter eps", OFFSET(eps), AV_OPT_TYPE_FLOAT, {.dbl=1}, 0, 1, A }, - { "leakage", "set the filter leakage", OFFSET(leakage), AV_OPT_TYPE_FLOAT, {.dbl=0}, 0, 1, A }, - { "out_mode", "set output mode", OFFSET(output_mode), AV_OPT_TYPE_INT, {.i64=OUT_MODE}, 0, NB_OMODES-1, A, "mode" }, + { "mu", "set the filter mu", OFFSET(mu), AV_OPT_TYPE_FLOAT, {.dbl=0.75}, 0, 1, A|C }, + { "eps", "set the filter eps", OFFSET(eps), AV_OPT_TYPE_FLOAT, {.dbl=1}, 0, 1, A|C }, + { "leakage", "set the filter leakage", OFFSET(leakage), AV_OPT_TYPE_FLOAT, {.dbl=0}, 0, 1, A|C }, + { "out_mode", "set output mode", OFFSET(output_mode), AV_OPT_TYPE_INT, {.i64=OUT_MODE}, 0, NB_OMODES-1, A|C, "mode" }, { "i", "input", 0, AV_OPT_TYPE_CONST, {.i64=IN_MODE}, 0, 0, A, "mode" }, { "d", "desired", 0, AV_OPT_TYPE_CONST, {.i64=DESIRED_MODE}, 0, 0, A, "mode" }, { "o", "output", 0, AV_OPT_TYPE_CONST, {.i64=OUT_MODE}, 0, 0, A, "mode" }, @@ -281,22 +282,6 @@ static av_cold int init(AVFilterContext *ctx) return 0; } -static int process_command(AVFilterContext *ctx, const char *cmd, const char *args, - char *res, int res_len, int flags) -{ - AudioNLMSContext *s = ctx->priv; - int ret; - - if ( !strcmp(cmd, "mu") || !strcmp(cmd, "eps") - || !strcmp(cmd, "leakage") || !strcmp(cmd, "out_mode")) { - ret = av_opt_set(s, cmd, args, 0); - } else { - ret = AVERROR(ENOSYS); - } - - return ret; -} - static av_cold void uninit(AVFilterContext *ctx) { AudioNLMSContext *s = ctx->priv; @@ -341,5 +326,5 @@ AVFilter ff_af_anlms = { .inputs = inputs, .outputs = outputs, .flags = AVFILTER_FLAG_SLICE_THREADS, - .process_command = process_command, + .process_command = ff_filter_process_command, };