diff mbox

[FFmpeg-devel,03/14] avutil/opt: print command flag too

Message ID 20191009101705.7072-3-onemda@gmail.com
State New
Headers show

Commit Message

Paul B Mahol Oct. 9, 2019, 10:16 a.m. UTC 
Signed-off-by: Paul B Mahol <onemda@gmail.com>
---
 libavutil/opt.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Michael Niedermayer Oct. 9, 2019, 3:38 p.m. UTC | #1 
On Wed, Oct 09, 2019 at 12:16:54PM +0200, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol <onemda@gmail.com>
> ---
>  libavutil/opt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavutil/opt.c b/libavutil/opt.c
> index 7c2649725f..5bc70f7ffc 100644
> --- a/libavutil/opt.c
> +++ b/libavutil/opt.c
> @@ -1217,6 +1217,7 @@ static void opt_list(void *obj, void *av_log_obj, const char *unit,
>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_EXPORT)         ? 'X' : '.');
>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_READONLY)       ? 'R' : '.');
>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_BSF_PARAM)      ? 'B' : '.');
> +        av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_COMMAND_PARAM)  ? 'C' : '.');
>  
>          if (opt->help)
>              av_log(av_log_obj, AV_LOG_INFO, " %s", opt->help);

This probably needs a update to fate-opt

thx

[...]
Paul B Mahol Oct. 9, 2019, 4:27 p.m. UTC | #2 
On 10/9/19, Michael Niedermayer <michael@niedermayer.cc> wrote:
> On Wed, Oct 09, 2019 at 12:16:54PM +0200, Paul B Mahol wrote:
>> Signed-off-by: Paul B Mahol <onemda@gmail.com>
>> ---
>>  libavutil/opt.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/libavutil/opt.c b/libavutil/opt.c
>> index 7c2649725f..5bc70f7ffc 100644
>> --- a/libavutil/opt.c
>> +++ b/libavutil/opt.c
>> @@ -1217,6 +1217,7 @@ static void opt_list(void *obj, void *av_log_obj,
>> const char *unit,
>>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags &
>> AV_OPT_FLAG_EXPORT)         ? 'X' : '.');
>>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags &
>> AV_OPT_FLAG_READONLY)       ? 'R' : '.');
>>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags &
>> AV_OPT_FLAG_BSF_PARAM)      ? 'B' : '.');
>> +        av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags &
>> AV_OPT_FLAG_COMMAND_PARAM)  ? 'C' : '.');
>>
>>          if (opt->help)
>>              av_log(av_log_obj, AV_LOG_INFO, " %s", opt->help);
>
> This probably needs a update to fate-opt
>

Updated locally.

> thx
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> No snowflake in an avalanche ever feels responsible. -- Voltaire
>
diff mbox

Patch

diff --git a/libavutil/opt.c b/libavutil/opt.c
index 7c2649725f..5bc70f7ffc 100644
--- a/libavutil/opt.c
+++ b/libavutil/opt.c
@@ -1217,6 +1217,7 @@  static void opt_list(void *obj, void *av_log_obj, const char *unit,
         av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_EXPORT)         ? 'X' : '.');
         av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_READONLY)       ? 'R' : '.');
         av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_BSF_PARAM)      ? 'B' : '.');
+        av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_COMMAND_PARAM)  ? 'C' : '.');
 
         if (opt->help)
             av_log(av_log_obj, AV_LOG_INFO, " %s", opt->help);