From patchwork Thu Oct 10 02:07:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Steven X-Patchwork-Id: 15655 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 1C781446632 for ; Thu, 10 Oct 2019 05:08:27 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0834B688200; Thu, 10 Oct 2019 05:08:27 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from smtpproxy21.qq.com (smtpbg704.qq.com [203.205.195.105]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A77966881F6 for ; Thu, 10 Oct 2019 05:08:19 +0300 (EEST) X-QQ-mid: bizesmtp19t1570673295tsmhhu3o Received: from localhost (unknown [47.90.47.25]) by esmtp10.qq.com (ESMTP) with id ; Thu, 10 Oct 2019 10:08:14 +0800 (CST) X-QQ-SSF: 01100000002000K0ZRF1B00A0000000 X-QQ-FEAT: bP3hyS9xCjChNQ9EceWMytIbj/fRRQh6quzZGPxDbHC1v/V/e2Y8XDlfJ2+a1 FFCyN5S383L4ATJtu1jYP/R0t6yRlXTRZqxUPRnZ0mPStzfyjMUNwSHzVRqgE9A1kSUhssw Z5004MiAL59pVligm/YjZC5LU/w6gr/JlorxOhhQ/TU47kBcjGS0BnNMJoyI2yK/oEKH5gZ +51Xl9TOVKI5jCOania73l4P8BD5Ib6fqcaC1ErFmYXjCp1Y0v41cq4hFKm5RkOPbIoDI/S 0U0RvJCEtHLxS4N9FAUiqDZ/RPvrQLRttzSYMLyg9611As1TW2bvjio9s= X-QQ-GoodBg: 0 From: Steven Liu To: ffmpeg-devel@ffmpeg.org Date: Thu, 10 Oct 2019 10:07:56 +0800 Message-Id: <20191010020756.30820-8-lq@chinaffmpeg.org> X-Mailer: git-send-email 2.10.1.382.ga23ca1b.dirty In-Reply-To: <20191010020756.30820-1-lq@chinaffmpeg.org> References: <20191010020756.30820-1-lq@chinaffmpeg.org> X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:chinaffmpeg.org:qybgforeign:qybgforeign1 X-QQ-Bgrelay: 1 Subject: [FFmpeg-devel] [PATCH v2 8/8] avformat/wc3movie: fix memleak when read content size not equvipe input size X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Steven Liu MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Signed-off-by: Steven Liu --- libavformat/wc3movie.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/wc3movie.c b/libavformat/wc3movie.c index 27f5eb1962..6577007777 100644 --- a/libavformat/wc3movie.c +++ b/libavformat/wc3movie.c @@ -130,8 +130,10 @@ static int wc3_read_header(AVFormatContext *s) buffer = av_malloc(size+1); if (!buffer) return AVERROR(ENOMEM); - if ((ret = avio_read(pb, buffer, size)) != size) + if ((ret = avio_read(pb, buffer, size)) != size) { + av_freep(&buffer); return AVERROR(EIO); + } buffer[size] = 0; av_dict_set(&s->metadata, "title", buffer, AV_DICT_DONT_STRDUP_VAL);