[FFmpeg-devel,v1,3/6] avcodec/xwddec: cosmetics

Submitted by lance.lmwang@gmail.com on Oct. 11, 2019, 6:14 a.m.

Details

Message ID 20191011061444.4988-3-lance.lmwang@gmail.com
State New
Headers show

Commit Message

lance.lmwang@gmail.com Oct. 11, 2019, 6:14 a.m.
From: Limin Wang <lance.lmwang@gmail.com>

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
 libavcodec/xwddec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul B Mahol Oct. 11, 2019, 11:45 a.m.
pointless

On 10/11/19, lance.lmwang@gmail.com <lance.lmwang@gmail.com> wrote:
> From: Limin Wang <lance.lmwang@gmail.com>
>
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
>  libavcodec/xwddec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/xwddec.c b/libavcodec/xwddec.c
> index 8c4358fd4c..924ba020da 100644
> --- a/libavcodec/xwddec.c
> +++ b/libavcodec/xwddec.c
> @@ -151,7 +151,7 @@ static int xwd_decode_frame(AVCodecContext *avctx, void
> *data,
>      }
>
>      if (pixformat != XWD_Z_PIXMAP) {
> -        avpriv_report_missing_feature(avctx, "Pixmap format %"PRIu32,
> pixformat);
> +        avpriv_report_missing_feature(avctx, "Pixmap format %"PRIu32"",
> pixformat);
>          return AVERROR_PATCHWELCOME;
>      }
>
> --
> 2.21.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Paul B Mahol Oct. 11, 2019, 2:44 p.m.
On 10/11/19, Limin Wang <lance.lmwang@gmail.com> wrote:
> On Fri, Oct 11, 2019 at 01:45:34PM +0200, Paul B Mahol wrote:
>> pointless
>>
> It's OK, I saw two different code style, so I change it for consistent.
>

No, it is not OK, please refrain from posting such patches, they are
considered spam.

Also stop posting messages only to me.

> It seems that the current style is used more than changed in same file:
> line 105:
> avpriv_request_sample(avctx, "xoffset %"PRIu32"", xoffset);
> line 208
> avpriv_request_sample(avctx,
>                                "Unknown file: bpp %"PRIu32", pixdepth
> %"PRIu32", vclass %"PRIu32"",
>                                bpp, pixdepth, vclass);
>
>
>> On 10/11/19, lance.lmwang@gmail.com <lance.lmwang@gmail.com> wrote:
>> > From: Limin Wang <lance.lmwang@gmail.com>
>> >
>> > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
>> > ---
>> >  libavcodec/xwddec.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/libavcodec/xwddec.c b/libavcodec/xwddec.c
>> > index 8c4358fd4c..924ba020da 100644
>> > --- a/libavcodec/xwddec.c
>> > +++ b/libavcodec/xwddec.c
>> > @@ -151,7 +151,7 @@ static int xwd_decode_frame(AVCodecContext *avctx,
>> > void
>> > *data,
>> >      }
>> >
>> >      if (pixformat != XWD_Z_PIXMAP) {
>> > -        avpriv_report_missing_feature(avctx, "Pixmap format %"PRIu32,
>> > pixformat);
>> > +        avpriv_report_missing_feature(avctx, "Pixmap format
>> > %"PRIu32"",
>> > pixformat);
>> >          return AVERROR_PATCHWELCOME;
>> >      }
>> >
>> > --
>> > 2.21.0
>> >
>> > _______________________________________________
>> > ffmpeg-devel mailing list
>> > ffmpeg-devel@ffmpeg.org
>> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> >
>> > To unsubscribe, visit link above, or email
>> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>

Patch hide | download patch | download mbox

diff --git a/libavcodec/xwddec.c b/libavcodec/xwddec.c
index 8c4358fd4c..924ba020da 100644
--- a/libavcodec/xwddec.c
+++ b/libavcodec/xwddec.c
@@ -151,7 +151,7 @@  static int xwd_decode_frame(AVCodecContext *avctx, void *data,
     }
 
     if (pixformat != XWD_Z_PIXMAP) {
-        avpriv_report_missing_feature(avctx, "Pixmap format %"PRIu32, pixformat);
+        avpriv_report_missing_feature(avctx, "Pixmap format %"PRIu32"", pixformat);
         return AVERROR_PATCHWELCOME;
     }