From patchwork Sat Oct 19 20:39:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 15854 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 4D29E449718 for ; Sat, 19 Oct 2019 23:42:00 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3CE2368AE27; Sat, 19 Oct 2019 23:42:00 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-pe02-1.mx.upcmail.net (vie01a-dmta-pe02-1.mx.upcmail.net [62.179.121.157]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9AF3F68ADA6 for ; Sat, 19 Oct 2019 23:41:50 +0300 (EEST) Received: from [172.31.216.235] (helo=vie01a-pemc-psmtp-pe12.mail.upcmail.net) by vie01a-dmta-pe02.mx.upcmail.net with esmtp (Exim 4.92) (envelope-from ) id 1iLvXp-00034M-0c for ffmpeg-devel@ffmpeg.org; Sat, 19 Oct 2019 22:41:49 +0200 Received: from localhost ([213.47.68.29]) by vie01a-pemc-psmtp-pe12.mail.upcmail.net with ESMTP id LvWriqJNzwlysLvWriaJ7Q; Sat, 19 Oct 2019 22:40:49 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 213.47.68.29 X-CNFS-Analysis: v=2.3 cv=E5OzWpVl c=1 sm=1 tr=0 a=2hcxjKEKjp0CzLx6oWAm4g==:117 a=2hcxjKEKjp0CzLx6oWAm4g==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=ZZnuYtJkoWoA:10 a=nZOtpAppAAAA:20 a=WrjDaOYfKXb1FzPFa9sA:9 a=VlZU0XKO32wA:10 a=1fhp2MxaeJtTNGEnv6mo:22 a=Z5ABNNGmrOfJ6cZ5bIyy:22 a=SsAZrZ5W_gNWK9tOzrEV:22 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sat, 19 Oct 2019 22:39:49 +0200 Message-Id: <20191019203950.11689-4-michael@niedermayer.cc> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191019203950.11689-1-michael@niedermayer.cc> References: <20191019203950.11689-1-michael@niedermayer.cc> MIME-Version: 1.0 X-CMAE-Envelope: MS4wfFng86e0PEVxlN/atOubUPVDH/5jzsXUuniCx+hX54HH1SYWWpQyBn/saWPZpdLbf0rNHBbGQkoxCrM0gNGZDibgPd9cbmeIhtpZcjR9755g6ro6JOat rtqHKNFKRJIRnn4YZOa1+uqFkCWD9oqqaun4ulp/hMDW6MEYcQfZNUip Subject: [FFmpeg-devel] [PATCH 4/5] avutil/lfg: Correct index type to avoid undefined behavior X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int' Fixes: 18333/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_COMFORTNOISE_fuzzer-5668481831272448 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavutil/lfg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/lfg.h b/libavutil/lfg.h index 03f779ad8a..8b18df2cea 100644 --- a/libavutil/lfg.h +++ b/libavutil/lfg.h @@ -26,7 +26,7 @@ typedef struct AVLFG { unsigned int state[64]; - int index; + unsigned index; } AVLFG; void av_lfg_init(AVLFG *c, unsigned int seed);