diff mbox

[FFmpeg-devel,4/5] doc/indevs: Add examples for libdc1394

Message ID 20191020095533.15016-5-cyrozap@gmail.com
State Superseded
Headers show

Commit Message

Forest Crossman Oct. 20, 2019, 9:55 a.m. UTC
Signed-off-by: Forest Crossman <cyrozap@gmail.com>
---
 doc/indevs.texi | 51 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

Comments

Gyan Doshi Oct. 20, 2019, 10:13 a.m. UTC | #1
This patch (and others in this set) appear to have been sent multiple 
times. This is the latest received one, so reviewing this one.

On 20-10-2019 03:25 PM, Forest Crossman wrote:
> Signed-off-by: Forest Crossman <cyrozap@gmail.com>
> ---
>   doc/indevs.texi | 51 +++++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 51 insertions(+)
>
> diff --git a/doc/indevs.texi b/doc/indevs.texi
> index 757fac91de..078f45497a 100644
> --- a/doc/indevs.texi
> +++ b/doc/indevs.texi
> @@ -1086,6 +1086,57 @@ Set the video size given as a string such as @code{640x480} or @code{hd720}.
>   Default is @code{qvga}.
>   @end table
>   
> +@subsection Examples
> +
> +@itemize
> +
> +@item
> +List all the connected IIDC cameras.
> +@example
> +ffmpeg -sources libdc1394
> +@end example
> +
> +@item
> +Grab and record the input of an Apple iSight.
> +@example
> +ffmpeg -f libdc1394 -pixel_format uyvy422 -video_size 320x240 -framerate 30 -i auto out.mkv
> +@end example
> +
> +@item
> +Grab and record the input of an Apple iSight, using the shorter options.
> +@example
> +ffmpeg -f libdc1394 -pix_fmt uyvy422 -s 320x240 -r 30 -i auto out.mkv
> +@end example

The shorter options are deprecated and aren't strictly speaking, private 
options of this device, so remove this example.

> +@item
> +Grab and record the input of an Apple iSight, specifying the framerate
> +as a ratio.
> +@example
> +ffmpeg -f libdc1394 -pix_fmt uyvy422 -s 320x240 -r 30000:1000 -i auto out.mkv
> +@end example

Not really necessary, but if kept, replace with device options.

> +@item
> +Grab and record the input of an Apple iSight at a greater resolution but
> +a lower framerate.
> +@example
> +ffmpeg -f libdc1394 -pix_fmt uyvy422 -s 640x480 -r 15 -i auto out.mkv
> +@end example

Unless there are restrictions on combinations of option values, seems 
unnecessary.

> +@item
> +Grab and record the input of a specific Apple iSight.
> +@example
> +ffmpeg -f libdc1394 -pix_fmt uyvy422 -s 640x480 -r 15 -i 0x000a270004106ea3 out.mkv
> +@end example

Replace with device options.

> +@item
> +Grab and record the second stream from a specific camera that has
> +multiple units.
> +@example
> +ffmpeg -f libdc1394 -pix_fmt uyvy422 -s 640x480 -r 15 -i 0xfacade02bc394f15:1 out.mkv
> +@end example

Same.


Regards,
Gyan
Forest Crossman Oct. 20, 2019, 12:35 p.m. UTC | #2
On Sun, Oct 20, 2019 at 5:21 AM Gyan <ffmpeg@gyani.pro> wrote:
>
> This patch (and others in this set) appear to have been sent multiple
> times. This is the latest received one, so reviewing this one.

Interesting, sorry about that. I only ran git send-email once, but I
did notice that the messages arrived out-of-order in Patchwork and the
list archive--maybe there was a delivery issue somewhere and either
Google or the list server re-sent the messages?

> > +@item
> > +Grab and record the input of an Apple iSight, using the shorter options.
> > +@example
> > +ffmpeg -f libdc1394 -pix_fmt uyvy422 -s 320x240 -r 30 -i auto out.mkv
> > +@end example
>
> The shorter options are deprecated and aren't strictly speaking, private
> options of this device, so remove this example.

Oops, didn't realize those were deprecated, will fix for v2.

> > +@item
> > +Grab and record the input of an Apple iSight, specifying the framerate
> > +as a ratio.
> > +@example
> > +ffmpeg -f libdc1394 -pix_fmt uyvy422 -s 320x240 -r 30000:1000 -i auto out.mkv
> > +@end example
>
> Not really necessary, but if kept, replace with device options.

Got it, in that case I'll just remove it.

> > +@item
> > +Grab and record the input of an Apple iSight at a greater resolution but
> > +a lower framerate.
> > +@example
> > +ffmpeg -f libdc1394 -pix_fmt uyvy422 -s 640x480 -r 15 -i auto out.mkv
> > +@end example
>
> Unless there are restrictions on combinations of option values, seems
> unnecessary.

While there isn't an inherent restriction, devices only support a
limited number of video modes, and in each of those modes only certain
frame rates are supported. I added this example to demonstrate that
other video modes/frame rates could be used, but since the other
examples use this resolution/frame rate combo this example does seem a
bit redundant, so I'll remove it.

> > +@item
> > +Grab and record the input of a specific Apple iSight.
> > +@example
> > +ffmpeg -f libdc1394 -pix_fmt uyvy422 -s 640x480 -r 15 -i 0x000a270004106ea3 out.mkv
> > +@end example
>
> Replace with device options.

Done.

> > +@item
> > +Grab and record the second stream from a specific camera that has
> > +multiple units.
> > +@example
> > +ffmpeg -f libdc1394 -pix_fmt uyvy422 -s 640x480 -r 15 -i 0xfacade02bc394f15:1 out.mkv
> > +@end example
>
> Same.

Done.
diff mbox

Patch

diff --git a/doc/indevs.texi b/doc/indevs.texi
index 757fac91de..078f45497a 100644
--- a/doc/indevs.texi
+++ b/doc/indevs.texi
@@ -1086,6 +1086,57 @@  Set the video size given as a string such as @code{640x480} or @code{hd720}.
 Default is @code{qvga}.
 @end table
 
+@subsection Examples
+
+@itemize
+
+@item
+List all the connected IIDC cameras.
+@example
+ffmpeg -sources libdc1394
+@end example
+
+@item
+Grab and record the input of an Apple iSight.
+@example
+ffmpeg -f libdc1394 -pixel_format uyvy422 -video_size 320x240 -framerate 30 -i auto out.mkv
+@end example
+
+@item
+Grab and record the input of an Apple iSight, using the shorter options.
+@example
+ffmpeg -f libdc1394 -pix_fmt uyvy422 -s 320x240 -r 30 -i auto out.mkv
+@end example
+
+@item
+Grab and record the input of an Apple iSight, specifying the framerate
+as a ratio.
+@example
+ffmpeg -f libdc1394 -pix_fmt uyvy422 -s 320x240 -r 30000:1000 -i auto out.mkv
+@end example
+
+@item
+Grab and record the input of an Apple iSight at a greater resolution but
+a lower framerate.
+@example
+ffmpeg -f libdc1394 -pix_fmt uyvy422 -s 640x480 -r 15 -i auto out.mkv
+@end example
+
+@item
+Grab and record the input of a specific Apple iSight.
+@example
+ffmpeg -f libdc1394 -pix_fmt uyvy422 -s 640x480 -r 15 -i 0x000a270004106ea3 out.mkv
+@end example
+
+@item
+Grab and record the second stream from a specific camera that has
+multiple units.
+@example
+ffmpeg -f libdc1394 -pix_fmt uyvy422 -s 640x480 -r 15 -i 0xfacade02bc394f15:1 out.mkv
+@end example
+
+@end itemize
+
 @section openal
 
 The OpenAL input device provides audio capture on all systems with a