[FFmpeg-devel,2/2] avfilter/Makefile: add missing framesync dependency to bm3d & mix filters

Submitted by Lou Logan on Nov. 6, 2019, 7:52 p.m.

Details

Message ID 20191106195244.79194-2-lou@lrcd.com
State Accepted
Commit 007e03348dbd8d3de3eb09022d72c734a8608144
Headers show

Commit Message

Lou Logan Nov. 6, 2019, 7:52 p.m.
Signed-off-by: Lou Logan <lou@lrcd.com>
---
bm3d
/usr/bin/ld: libavfilter/libavfilter.a(vf_bm3d.o): in function `activate':
vf_bm3d.c:(.text+0x3100): undefined reference to `ff_framesync_activate'
/usr/bin/ld: libavfilter/libavfilter.a(vf_bm3d.o): in function `process_frame':
vf_bm3d.c:(.text+0x3182): undefined reference to `ff_framesync_get_frame'
/usr/bin/ld: vf_bm3d.c:(.text+0x31ac): undefined reference to `ff_framesync_get_frame'
/usr/bin/ld: libavfilter/libavfilter.a(vf_bm3d.o): in function `config_output':
vf_bm3d.c:(.text+0x36fe): undefined reference to `ff_framesync_init'
/usr/bin/ld: vf_bm3d.c:(.text+0x37c1): undefined reference to `ff_framesync_configure'
/usr/bin/ld: libavfilter/libavfilter.a(vf_bm3d.o): in function `uninit':
vf_bm3d.c:(.text+0x383a): undefined reference to `ff_framesync_uninit'

mix
/usr/bin/ld: libavfilter/libavfilter.a(vf_mix.o): in function `process_frame':
vf_mix.c:(.text+0x954): undefined reference to `ff_framesync_get_frame'
/usr/bin/ld: libavfilter/libavfilter.a(vf_mix.o): in function `config_output':
vf_mix.c:(.text+0xd2c): undefined reference to `ff_framesync_init'
/usr/bin/ld: vf_mix.c:(.text+0xe77): undefined reference to `ff_framesync_configure'
/usr/bin/ld: libavfilter/libavfilter.a(vf_mix.o): in function `uninit':
vf_mix.c:(.text+0xeba): undefined reference to `ff_framesync_uninit'
/usr/bin/ld: libavfilter/libavfilter.a(vf_mix.o): in function `activate':
vf_mix.c:(.text+0xf8a): undefined reference to `ff_framesync_activate'
---
 libavfilter/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

mypopy@gmail.com Nov. 8, 2019, 1:29 a.m.
On Thu, Nov 7, 2019 at 3:53 AM Lou Logan <lou@lrcd.com> wrote:

> Signed-off-by: Lou Logan <lou@lrcd.com>
> ---
> bm3d
> /usr/bin/ld: libavfilter/libavfilter.a(vf_bm3d.o): in function `activate':
> vf_bm3d.c:(.text+0x3100): undefined reference to `ff_framesync_activate'
> /usr/bin/ld: libavfilter/libavfilter.a(vf_bm3d.o): in function
> `process_frame':
> vf_bm3d.c:(.text+0x3182): undefined reference to `ff_framesync_get_frame'
> /usr/bin/ld: vf_bm3d.c:(.text+0x31ac): undefined reference to
> `ff_framesync_get_frame'
> /usr/bin/ld: libavfilter/libavfilter.a(vf_bm3d.o): in function
> `config_output':
> vf_bm3d.c:(.text+0x36fe): undefined reference to `ff_framesync_init'
> /usr/bin/ld: vf_bm3d.c:(.text+0x37c1): undefined reference to
> `ff_framesync_configure'
> /usr/bin/ld: libavfilter/libavfilter.a(vf_bm3d.o): in function `uninit':
> vf_bm3d.c:(.text+0x383a): undefined reference to `ff_framesync_uninit'
>
> mix
> /usr/bin/ld: libavfilter/libavfilter.a(vf_mix.o): in function
> `process_frame':
> vf_mix.c:(.text+0x954): undefined reference to `ff_framesync_get_frame'
> /usr/bin/ld: libavfilter/libavfilter.a(vf_mix.o): in function
> `config_output':
> vf_mix.c:(.text+0xd2c): undefined reference to `ff_framesync_init'
> /usr/bin/ld: vf_mix.c:(.text+0xe77): undefined reference to
> `ff_framesync_configure'
> /usr/bin/ld: libavfilter/libavfilter.a(vf_mix.o): in function `uninit':
> vf_mix.c:(.text+0xeba): undefined reference to `ff_framesync_uninit'
> /usr/bin/ld: libavfilter/libavfilter.a(vf_mix.o): in function `activate':
> vf_mix.c:(.text+0xf8a): undefined reference to `ff_framesync_activate'
> ---
>  libavfilter/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavfilter/Makefile b/libavfilter/Makefile
> index 2080eed559..ec2ed4a8e7 100644
> --- a/libavfilter/Makefile
> +++ b/libavfilter/Makefile
> @@ -169,7 +169,7 @@ OBJS-$(CONFIG_BITPLANENOISE_FILTER)          +=
> vf_bitplanenoise.o
>  OBJS-$(CONFIG_BLACKDETECT_FILTER)            += vf_blackdetect.o
>  OBJS-$(CONFIG_BLACKFRAME_FILTER)             += vf_blackframe.o
>  OBJS-$(CONFIG_BLEND_FILTER)                  += vf_blend.o framesync.o
> -OBJS-$(CONFIG_BM3D_FILTER)                   += vf_bm3d.o
> +OBJS-$(CONFIG_BM3D_FILTER)                   += vf_bm3d.o framesync.o
>  OBJS-$(CONFIG_BOXBLUR_FILTER)                += vf_boxblur.o boxblur.o
>  OBJS-$(CONFIG_BOXBLUR_OPENCL_FILTER)         += vf_avgblur_opencl.o
> opencl.o \
>                                                  opencl/avgblur.o boxblur.o
> @@ -303,7 +303,7 @@ OBJS-$(CONFIG_MESTIMATE_FILTER)              +=
> vf_mestimate.o motion_estimation
>  OBJS-$(CONFIG_METADATA_FILTER)               += f_metadata.o
>  OBJS-$(CONFIG_MIDEQUALIZER_FILTER)           += vf_midequalizer.o
> framesync.o
>  OBJS-$(CONFIG_MINTERPOLATE_FILTER)           += vf_minterpolate.o
> motion_estimation.o
> -OBJS-$(CONFIG_MIX_FILTER)                    += vf_mix.o
> +OBJS-$(CONFIG_MIX_FILTER)                    += vf_mix.o framesync.o
>  OBJS-$(CONFIG_MPDECIMATE_FILTER)             += vf_mpdecimate.o
>  OBJS-$(CONFIG_NEGATE_FILTER)                 += vf_lut.o
>  OBJS-$(CONFIG_NLMEANS_FILTER)                += vf_nlmeans.o
> --
> 2.24.0
>
> _______________________________________________
>
>  LGTM
Lou Logan Nov. 8, 2019, 7:24 p.m.
On Thu, Nov 7, 2019, at 4:29 PM, mypopy@gmail.com wrote:
>  LGTM

Set pushed.

Patch hide | download patch | download mbox

diff --git a/libavfilter/Makefile b/libavfilter/Makefile
index 2080eed559..ec2ed4a8e7 100644
--- a/libavfilter/Makefile
+++ b/libavfilter/Makefile
@@ -169,7 +169,7 @@  OBJS-$(CONFIG_BITPLANENOISE_FILTER)          += vf_bitplanenoise.o
 OBJS-$(CONFIG_BLACKDETECT_FILTER)            += vf_blackdetect.o
 OBJS-$(CONFIG_BLACKFRAME_FILTER)             += vf_blackframe.o
 OBJS-$(CONFIG_BLEND_FILTER)                  += vf_blend.o framesync.o
-OBJS-$(CONFIG_BM3D_FILTER)                   += vf_bm3d.o
+OBJS-$(CONFIG_BM3D_FILTER)                   += vf_bm3d.o framesync.o
 OBJS-$(CONFIG_BOXBLUR_FILTER)                += vf_boxblur.o boxblur.o
 OBJS-$(CONFIG_BOXBLUR_OPENCL_FILTER)         += vf_avgblur_opencl.o opencl.o \
                                                 opencl/avgblur.o boxblur.o
@@ -303,7 +303,7 @@  OBJS-$(CONFIG_MESTIMATE_FILTER)              += vf_mestimate.o motion_estimation
 OBJS-$(CONFIG_METADATA_FILTER)               += f_metadata.o
 OBJS-$(CONFIG_MIDEQUALIZER_FILTER)           += vf_midequalizer.o framesync.o
 OBJS-$(CONFIG_MINTERPOLATE_FILTER)           += vf_minterpolate.o motion_estimation.o
-OBJS-$(CONFIG_MIX_FILTER)                    += vf_mix.o
+OBJS-$(CONFIG_MIX_FILTER)                    += vf_mix.o framesync.o
 OBJS-$(CONFIG_MPDECIMATE_FILTER)             += vf_mpdecimate.o
 OBJS-$(CONFIG_NEGATE_FILTER)                 += vf_lut.o
 OBJS-$(CONFIG_NLMEANS_FILTER)                += vf_nlmeans.o