[FFmpeg-devel] avcodec/vp9_raw_reorder_bsf.c adjust params keep same with api

Submitted by darling.zhong on Nov. 8, 2019, 6:14 a.m.

Details

Message ID 36b770fc.f07f8.16e49a5f849.Coremail.dalingzhong@yeah.net
State New
Headers show

Commit Message

darling.zhong Nov. 8, 2019, 6:14 a.m.
Signed-off-by: darling.zhong <dalingzhong@yeah.net>
---
 libavcodec/h265_metadata_bsf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 mode change 100644 => 100755 libavcodec/h265_metadata_bsf.c

Comments

mypopy@gmail.com Nov. 8, 2019, 6:24 a.m.
On Fri, Nov 8, 2019 at 2:14 PM darling.zhong <dalingzhong@yeah.net> wrote:
>
>
>
> Signed-off-by: darling.zhong <dalingzhong@yeah.net>
> ---
>  libavcodec/h265_metadata_bsf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>  mode change 100644 => 100755 libavcodec/h265_metadata_bsf.c
>
Please don't change the file mode
>
> diff --git a/libavcodec/h265_metadata_bsf.c b/libavcodec/h265_metadata_bsf.c
> old mode 100644
> new mode 100755
> index b3a1fda144..730f7ac28f
> --- a/libavcodec/h265_metadata_bsf.c
> +++ b/libavcodec/h265_metadata_bsf.c
> @@ -131,7 +131,7 @@ static void h265_metadata_guess_level(AVBSFContext *bsf,
>      }
>
>      desc = ff_h265_guess_level(ptl, bit_rate, width, height,
> -                               0, tile_cols, tile_rows,
> +                               0, tile_rows, tile_cols,
>                                 max_dec_pic_buffering);
>      if (desc) {
>          av_log(bsf, AV_LOG_DEBUG, "Stream appears to conform to "
> --
> 2.17.1
darling.zhong Nov. 8, 2019, 7:17 a.m.
oh, no, I'm a student learning ffmpeg now, and just learing git nowis there any shell tools like make patch, send to my email use Private letter, thx

At 2019-11-08 14:24:28, "mypopy@gmail.com" <mypopy@gmail.com> wrote: >On Fri, Nov 8, 2019 at 2:14 PM darling.zhong <dalingzhong@yeah.net> wrote: >> >> >> >> Signed-off-by: darling.zhong <dalingzhong@yeah.net> >> --- >> libavcodec/h265_metadata_bsf.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> mode change 100644 => 100755 libavcodec/h265_metadata_bsf.c >> >Please don't change the file mode >> >> diff --git a/libavcodec/h265_metadata_bsf.c b/libavcodec/h265_metadata_bsf.c >> old mode 100644 >> new mode 100755 >> index b3a1fda144..730f7ac28f >> --- a/libavcodec/h265_metadata_bsf.c >> +++ b/libavcodec/h265_metadata_bsf.c >> @@ -131,7 +131,7 @@ static void h265_metadata_guess_level(AVBSFContext *bsf, >> } >> >> desc = ff_h265_guess_level(ptl, bit_rate, width, height, >> - 0, tile_cols, tile_rows, >> + 0, tile_rows, tile_cols, >> max_dec_pic_buffering); >> if (desc) { >> av_log(bsf, AV_LOG_DEBUG, "Stream appears to conform to " >> -- >> 2.17.1 >_______________________________________________ >ffmpeg-devel mailing list >ffmpeg-devel@ffmpeg.org >https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >To unsubscribe, visit link above, or email >ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Andreas Rheinhardt Nov. 8, 2019, 10:56 a.m.
darling.zhong:
> 
> 
> Signed-off-by: darling.zhong <dalingzhong@yeah.net>
> ---
>  libavcodec/h265_metadata_bsf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>  mode change 100644 => 100755 libavcodec/h265_metadata_bsf.c
> 
> 
> diff --git a/libavcodec/h265_metadata_bsf.c b/libavcodec/h265_metadata_bsf.c
> old mode 100644
> new mode 100755
> index b3a1fda144..730f7ac28f
> --- a/libavcodec/h265_metadata_bsf.c
> +++ b/libavcodec/h265_metadata_bsf.c
> @@ -131,7 +131,7 @@ static void h265_metadata_guess_level(AVBSFContext *bsf,
>      }
>  
>      desc = ff_h265_guess_level(ptl, bit_rate, width, height,
> -                               0, tile_cols, tile_rows,
> +                               0, tile_rows, tile_cols,
>                                 max_dec_pic_buffering);
>      if (desc) {
>          av_log(bsf, AV_LOG_DEBUG, "Stream appears to conform to "
> 
1. Your commit message says that you are modifying
vp9_raw_reorder_bsf.c, while you are actually modifying
h265_metadata_bsf.c.
2. As has been said, don't change the file mode.
3. The actual change is the same as in [1].

- Andreas

[1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2019-September/250770.html

Patch hide | download patch | download mbox

diff --git a/libavcodec/h265_metadata_bsf.c b/libavcodec/h265_metadata_bsf.c
old mode 100644
new mode 100755
index b3a1fda144..730f7ac28f
--- a/libavcodec/h265_metadata_bsf.c
+++ b/libavcodec/h265_metadata_bsf.c
@@ -131,7 +131,7 @@  static void h265_metadata_guess_level(AVBSFContext *bsf,
     }
 
     desc = ff_h265_guess_level(ptl, bit_rate, width, height,
-                               0, tile_cols, tile_rows,
+                               0, tile_rows, tile_cols,
                                max_dec_pic_buffering);
     if (desc) {
         av_log(bsf, AV_LOG_DEBUG, "Stream appears to conform to "