diff mbox

[FFmpeg-devel] configure: Fix build on MacOS 10.15

Message ID 20191117215749.76271-1-kernrj@gmail.com
State New
Headers show

Commit Message

Rick Kern Nov. 17, 2019, 9:57 p.m. UTC 
The default ./configure produces binaries that segfault on MacOS 10.15.
Fixes #8073 using the work-around mentioned in the ticket.
---
 configure | 1 +
 1 file changed, 1 insertion(+)

Comments

James Almer Nov. 17, 2019, 10:02 p.m. UTC | #1 
On 11/17/2019 6:57 PM, Rick Kern wrote:
> The default ./configure produces binaries that segfault on MacOS 10.15.
> Fixes #8073 using the work-around mentioned in the ticket.
> ---
>  configure | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configure b/configure
> index 31a3744dc6..6e371ae433 100755
> --- a/configure
> +++ b/configure
> @@ -6878,6 +6878,7 @@ elif enabled clang; then
>      check_cflags -Werror=implicit-function-declaration
>      check_cflags -Werror=missing-prototypes
>      check_cflags -Werror=return-type
> +    check_cflags -fno-stack-check

This works around an Xcode 11 bug/regression, btw, that Apple hasn't
fixed yet. It's afaik not exclusive to Catalina, so the commit message
should mention it.

>  elif enabled cparser; then
>      add_cflags -Wno-missing-variable-declarations
>      add_cflags -Wno-empty-statement
>
diff mbox

Patch

diff --git a/configure b/configure
index 31a3744dc6..6e371ae433 100755
--- a/configure
+++ b/configure
@@ -6878,6 +6878,7 @@  elif enabled clang; then
     check_cflags -Werror=implicit-function-declaration
     check_cflags -Werror=missing-prototypes
     check_cflags -Werror=return-type
+    check_cflags -fno-stack-check
 elif enabled cparser; then
     add_cflags -Wno-missing-variable-declarations
     add_cflags -Wno-empty-statement