From patchwork Tue Dec 3 15:19:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 16561 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 0A5BD448646 for ; Tue, 3 Dec 2019 17:20:01 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CF4CA68B3FC; Tue, 3 Dec 2019 17:20:00 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A6A4E68B146 for ; Tue, 3 Dec 2019 17:19:54 +0200 (EET) Received: by mail-wr1-f65.google.com with SMTP id z7so4075974wrl.13 for ; Tue, 03 Dec 2019 07:19:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KJV0H7ySw9POHDO2/R1hA22bxGhcRNAPcDfEYxsklsk=; b=Mi1SQBxORwLS59fuKoNkO3v5tO09N5tgvaRyQYZ1V1kxXPgYOTCyhUS6tAOx77YNZe bS8Oo0jUyhl0VLyY0mXJNsW3HwZZu/vsCFSW60SbYOcCkPsPk1XSmAMg+wbHlK9Xy1SU z+6MAnXmRUgV0r1XPXSpQzeHeXZDt7BLMPgwoyfxxfxOeDz3Q5w3Bk8EU2tXb3NdOZJ7 rkvEOTbOFRWBFemzWkic9GSYr6cS9hc1ifWusNlQvbnKO9H1cdrMg4VSYUXMB+kdHNmj coIxEG/ErcPcyEtdK9+YB6LwYbtGyN+YvcBoJ3Rz1q8SEmAp9p5wqBxPC0SrzIx+jvca Mx/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KJV0H7ySw9POHDO2/R1hA22bxGhcRNAPcDfEYxsklsk=; b=QNVJrfKihawm/CDqxvjwAwrxEJvfmn7SMc8gmUx2qK31pAP/hpEPfzK6SZOwMePgei sMyRnqsiQ6UcwM1SUvo/oX9nfT4uAu0vTn7mVUpOcBvkwbp/IlOZN+quH8vPz5TI6ROI sBrrOLPvXzat/FHUZTg24E17DjMwrlOdFNL7ZYXjwy5tsK3GuSVLcg0XA7WpbeCaKIu1 ttzNd4knKc1w/m8HjLynFZLAw4gfmHheOaGHbgR5Br57DdRhQu0/TbjZsBxb27QII8n0 yR7VzjjmFEby0PaKGh5Gs62hQkRIubWMLFy0UtElNnSGS3uy/8XcE6UtTwyhga3tQC33 Iq1g== X-Gm-Message-State: APjAAAUB4lI0WjHTz4zrop1Uw5bH39vLeyl5aJ6GXLN4b0AQBOukvaXL 5wF/dw0n7yNKp7siIcLtkC6sRZUi X-Google-Smtp-Source: APXvYqycNQ/HKNVKZF4CZ+s3WRQ8lORK/5jKfaL+81MqQ5Q2hQ7mJ/pIg5oKNCDr8uIqVHbE4PRCyg== X-Received: by 2002:adf:e40f:: with SMTP id g15mr6047852wrm.223.1575386393898; Tue, 03 Dec 2019 07:19:53 -0800 (PST) Received: from sblaptop.fritz.box (ipbcc08e23.dynamic.kabel-deutschland.de. [188.192.142.35]) by smtp.gmail.com with ESMTPSA id n12sm3411162wmd.1.2019.12.03.07.19.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 07:19:52 -0800 (PST) From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Tue, 3 Dec 2019 16:19:47 +0100 Message-Id: <20191203151947.24685-1-andreas.rheinhardt@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191127053842.19481-2-andreas.rheinhardt@gmail.com> References: <20191127053842.19481-2-andreas.rheinhardt@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v3] avformat/matroskaenc: Use random TrackUID X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Up until now, the TrackUID of a Matroska track which is supposed to be random was not random at all: It always coincided with the TrackNumber which is usually the 1-based index of the corresponding stream in the array of AVStreams. This has been changed: It is now set via an AVLFG if AVFMT_FLAG_BITEXACT is not set. Otherwise it is set like it is set now (the only change happens if an explicit track number has been chosen via dash_track_number, because the system used in the normal situation is now used, too). In particular, no FATE tests need to be updated. This also fixes a bug in case the dash_track_number option was used: In this case the TrackUID was set to the track number, but the tags were written with a TagTrackUID simply based upon the index, so that the tags didn't apply to the track they ought to apply to. Signed-off-by: Andreas Rheinhardt --- I have updated the patchset to rely on the AVLFG to provide sufficiently many distinct values, as you said. I could add a check and a for if we still have a collision after (say) 1000 tries in order to avoid the potentially infinite loop. libavformat/matroskaenc.c | 52 +++++++++++++++++++++++++++++++++------ 1 file changed, 44 insertions(+), 8 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 41c3f1a985..b2f28304c8 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@ -94,6 +94,7 @@ typedef struct mkv_cues { typedef struct mkv_track { int write_dts; int has_cue; + uint64_t uid; int sample_rate; int64_t sample_rate_offset; int64_t last_timestamp; @@ -1199,8 +1200,7 @@ static int mkv_write_track(AVFormatContext *s, MatroskaMuxContext *mkv, track = start_ebml_master(pb, MATROSKA_ID_TRACKENTRY, 0); put_ebml_uint (pb, MATROSKA_ID_TRACKNUMBER, mkv->is_dash ? mkv->dash_track_number : i + 1); - put_ebml_uint (pb, MATROSKA_ID_TRACKUID, - mkv->is_dash ? mkv->dash_track_number : i + 1); + put_ebml_uint (pb, MATROSKA_ID_TRACKUID, mkv->tracks[i].uid); put_ebml_uint (pb, MATROSKA_ID_TRACKFLAGLACING , 0); // no lacing (yet) if ((tag = av_dict_get(st->metadata, "title", NULL, 0))) @@ -1651,7 +1651,8 @@ static int mkv_write_tags(AVFormatContext *s) if (!mkv_check_tag(st->metadata, MATROSKA_ID_TAGTARGETS_TRACKUID)) continue; - ret = mkv_write_tag(s, st->metadata, MATROSKA_ID_TAGTARGETS_TRACKUID, i + 1); + ret = mkv_write_tag(s, st->metadata, MATROSKA_ID_TAGTARGETS_TRACKUID, + mkv->tracks[i].uid); if (ret < 0) return ret; } @@ -1659,13 +1660,15 @@ static int mkv_write_tags(AVFormatContext *s) for (i = 0; i < s->nb_streams; i++) { AVIOContext *pb; AVStream *st = s->streams[i]; + mkv_track *track = &mkv->tracks[i]; ebml_master tag_target; ebml_master tag; if (st->codecpar->codec_type == AVMEDIA_TYPE_ATTACHMENT) continue; - mkv_write_tag_targets(s, MATROSKA_ID_TAGTARGETS_TRACKUID, i + 1, &tag_target); + mkv_write_tag_targets(s, MATROSKA_ID_TAGTARGETS_TRACKUID, + track->uid, &tag_target); pb = mkv->tags_bc; tag = start_ebml_master(pb, MATROSKA_ID_SIMPLETAG, 0); @@ -1865,10 +1868,6 @@ static int mkv_write_header(AVFormatContext *s) version = 4; } - mkv->tracks = av_mallocz_array(s->nb_streams, sizeof(*mkv->tracks)); - if (!mkv->tracks) { - return AVERROR(ENOMEM); - } ebml_header = start_ebml_master(pb, EBML_ID_HEADER, MAX_EBML_HEADER_SIZE); put_ebml_uint (pb, EBML_ID_EBMLVERSION , 1); put_ebml_uint (pb, EBML_ID_EBMLREADVERSION , 1); @@ -2670,8 +2669,29 @@ static int webm_query_codec(enum AVCodecID codec_id, int std_compliance) return 0; } +static uint64_t mkv_get_uid(const mkv_track *tracks, int i, AVLFG *c) +{ + uint64_t uid; + + while (1) { + int k; + uid = (uint64_t)av_lfg_get(c) << 32; + uid |= av_lfg_get(c); + if (!uid) + continue; + for (k = 0; k < i; k++) { + if (tracks[k].uid == uid) + break; + } + if (k == i) + return uid; + } +} + static int mkv_init(struct AVFormatContext *s) { + MatroskaMuxContext *mkv = s->priv_data; + AVLFG c; int i; if (s->nb_streams > MAX_TRACKS) { @@ -2700,7 +2720,23 @@ static int mkv_init(struct AVFormatContext *s) s->internal->avoid_negative_ts_use_pts = 1; } + mkv->tracks = av_mallocz_array(s->nb_streams, sizeof(*mkv->tracks)); + if (!mkv->tracks) { + return AVERROR(ENOMEM); + } + + if (!(s->flags & AVFMT_FLAG_BITEXACT)) + av_lfg_init(&c, av_get_random_seed()); + for (i = 0; i < s->nb_streams; i++) { + mkv_track *track = &mkv->tracks[i]; + + if (s->flags & AVFMT_FLAG_BITEXACT) { + track->uid = i + 1; + } else { + track->uid = mkv_get_uid(mkv->tracks, i, &c); + } + // ms precision is the de-facto standard timescale for mkv files avpriv_set_pts_info(s->streams[i], 64, 1, 1000); }