[FFmpeg-devel] avutil: Improved test coverage for avstring.c

Submitted by Thomas Turner on Dec. 20, 2016, 2:44 a.m.

Details

Message ID 1482201882-7013-1-git-send-email-thomastdt@googlemail.com
State Accepted
Commit e303e3d4b972975640da92cb55b766dad951d90d
Headers show

Commit Message

Thomas Turner Dec. 20, 2016, 2:44 a.m.
Signed-off-by: Thomas Turner <thomastdt@googlemail.com>
---
 libavutil/tests/avstring.c | 26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

Comments

Michael Niedermayer Dec. 20, 2016, 5:20 p.m.
On Mon, Dec 19, 2016 at 06:44:42PM -0800, Thomas Turner wrote:
> Signed-off-by: Thomas Turner <thomastdt@googlemail.com>
> ---
>  libavutil/tests/avstring.c | 26 +++++++++++++++++++++++++-
>  1 file changed, 25 insertions(+), 1 deletion(-)

applied

thx

[...]

Patch hide | download patch | download mbox

diff --git a/libavutil/tests/avstring.c b/libavutil/tests/avstring.c
index 1242b3f..290b170 100644
--- a/libavutil/tests/avstring.c
+++ b/libavutil/tests/avstring.c
@@ -25,7 +25,7 @@ 
 int main(void)
 {
     int i;
-    char *fullpath;
+    char *fullpath, *ptr;
     static const char * const strings[] = {
         "''",
         "",
@@ -54,6 +54,8 @@  int main(void)
         "'\\fo\\o:': blahblah",
         "\\'fo\\o\\:':  foo  '  :blahblah"
     };
+    const char *haystack = "Education consists mainly in what we have unlearned.";
+    const char * const needle[] = {"learned.", "unlearned.", "Unlearned"};
 
     printf("Testing av_get_token()\n");
     for (i = 0; i < FF_ARRAY_ELEMS(strings); i++) {
@@ -79,5 +81,27 @@  int main(void)
     TEST_APPEND_PATH_COMPONENT("path", "/comp", "path/comp");
     TEST_APPEND_PATH_COMPONENT("path/", "/comp", "path/comp");
     TEST_APPEND_PATH_COMPONENT("path/path2/", "/comp/comp2", "path/path2/comp/comp2");
+
+    /*Testing av_strnstr()*/
+    #define TEST_STRNSTR(haystack, needle, hay_length, expected) \
+        ptr = av_strnstr(haystack, needle, hay_length); \
+        if (ptr != expected){ \
+            printf("expected: %p, received %p\n", expected, ptr); \
+        }
+    TEST_STRNSTR(haystack, needle [0], strlen(haystack), haystack+44);
+    TEST_STRNSTR(haystack, needle [1], strlen(haystack), haystack+42);
+    TEST_STRNSTR(haystack, needle [2], strlen(haystack), NULL       );
+    TEST_STRNSTR(haystack, strings[1], strlen(haystack), haystack   );
+
+    /*Testing av_d2str()*/
+    #define TEST_D2STR(value, expected) \
+        if((ptr = av_d2str(value)) == NULL){ \
+            printf("error, received null pointer!\n"); \
+        } else if(strcmp(ptr, expected) != 0){ \
+            printf( "expected: %s, received: %s\n", expected, ptr); \
+        }
+    TEST_D2STR(0         ,  "0.000000");
+    TEST_D2STR(-1.2333234, "-1.233323");
+    TEST_D2STR(-1.2333237, "-1.233324");
     return 0;
 }