diff mbox

[FFmpeg-devel,2/5] avcodec/bsf: Add ff_bsf_get_packet_ref() function

Message ID 1469722696-2018-2-git-send-email-sebechlebskyjan@gmail.com
State Accepted
Commit 87d5686151bcb2ab94bd1c962e94d7e41203e31a
Headers show

Commit Message

sebechlebskyjan@gmail.com July 28, 2016, 4:18 p.m. UTC 
From: Jan Sebechlebsky <sebechlebskyjan@gmail.com>

Use of this function can save unnecessary malloc operation
in bitstream filter.

Signed-off-by: Jan Sebechlebsky <sebechlebskyjan@gmail.com>
---
 libavcodec/bsf.c | 16 ++++++++++++++++
 libavcodec/bsf.h | 11 +++++++++++
 2 files changed, 27 insertions(+)

Comments

Michael Niedermayer Aug. 13, 2016, 10:48 a.m. UTC | #1 
On Thu, Jul 28, 2016 at 06:18:13PM +0200, sebechlebskyjan@gmail.com wrote:
> From: Jan Sebechlebsky <sebechlebskyjan@gmail.com>
> 
> Use of this function can save unnecessary malloc operation
> in bitstream filter.
> 
> Signed-off-by: Jan Sebechlebsky <sebechlebskyjan@gmail.com>
> ---
>  libavcodec/bsf.c | 16 ++++++++++++++++
>  libavcodec/bsf.h | 11 +++++++++++
>  2 files changed, 27 insertions(+)

applied

thx

[...]
diff mbox

Patch

diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c
index 8e36861..40fc925 100644
--- a/libavcodec/bsf.c
+++ b/libavcodec/bsf.c
@@ -220,3 +220,19 @@  int ff_bsf_get_packet(AVBSFContext *ctx, AVPacket **pkt)
 
     return 0;
 }
+
+int ff_bsf_get_packet_ref(AVBSFContext *ctx, AVPacket *pkt)
+{
+    AVBSFInternal *in = ctx->internal;
+
+    if (in->eof)
+        return AVERROR_EOF;
+
+    if (!ctx->internal->buffer_pkt->data &&
+        !ctx->internal->buffer_pkt->side_data_elems)
+        return AVERROR(EAGAIN);
+
+    av_packet_move_ref(pkt, ctx->internal->buffer_pkt);
+
+    return 0;
+}
diff --git a/libavcodec/bsf.h b/libavcodec/bsf.h
index 3435df5..af035ee 100644
--- a/libavcodec/bsf.h
+++ b/libavcodec/bsf.h
@@ -28,6 +28,17 @@ 
  */
 int ff_bsf_get_packet(AVBSFContext *ctx, AVPacket **pkt);
 
+/**
+ * Called by bitstream filters to get packet for filtering.
+ * The reference to packet is moved to provided packet structure.
+ *
+ * @param ctx pointer to AVBSFContext of filter
+ * @param pkt pointer to packet to move reference to
+ *
+ * @return 0>= on success, negative AVERROR in case of failure
+ */
+int ff_bsf_get_packet_ref(AVBSFContext *ctx, AVPacket *pkt);
+
 const AVClass *ff_bsf_child_class_next(const AVClass *prev);
 
 #endif /* AVCODEC_BSF_H */