From patchwork Sat Jan 28 16:12:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: u-9iep@aetey.se X-Patchwork-Id: 2349 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.89.21 with SMTP id n21csp739940vsb; Sat, 28 Jan 2017 08:13:30 -0800 (PST) X-Received: by 10.223.151.135 with SMTP id s7mr11449762wrb.51.1485620010033; Sat, 28 Jan 2017 08:13:30 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id i124si5700421wma.144.2017.01.28.08.13.29; Sat, 28 Jan 2017 08:13:29 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@fripost.org; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 30BFF68A428; Sat, 28 Jan 2017 18:13:25 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from outgoing.fripost.org (giraff.fripost.org [178.16.208.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DD50568A27E for ; Sat, 28 Jan 2017 18:13:17 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by outgoing.fripost.org (Postfix) with ESMTP id 50878A56A33 for ; Sat, 28 Jan 2017 17:13:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fripost.org; h= content-disposition:content-type:content-type:mime-version :message-id:subject:subject:from:from:date:date; s=20140703; t= 1485619998; x=1487434399; bh=+G2h/EhaFZMGZsYUaazeh96STIIaFor41M0 +O20SqvU=; b=acz7KG8c2Xd5sKrfq7VfOyVt1gVAQmyDyzz7n8ujjmN+RbGB14g 5xi85c4uyrK9SZUgpR96bdI5ql4nwDf4FSaQZKVwA3HKRYG3DTc+1EQqvFfyk9iQ Ix097FWRW6FC8zWN2bsvPryUjXLjGRFpPBmaFlD/ooukF08+k1Mfr8bg= X-Virus-Scanned: Debian amavisd-new at fripost.org Received: from outgoing.fripost.org ([127.0.0.1]) by localhost (giraff.fripost.org [127.0.0.1]) (amavisd-new, port 10040) with LMTP id TUY3Y3LTHoI2 for ; Sat, 28 Jan 2017 17:13:18 +0100 (CET) Received: from smtp.fripost.org (unknown [172.16.0.6]) by outgoing.fripost.org (Postfix) with ESMTP id 2589AA56A2E for ; Sat, 28 Jan 2017 17:13:18 +0100 (CET) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by smtp.fripost.org (Postfix) with ESMTPSA id 8DA0629AD3E3 for ; Sat, 28 Jan 2017 17:13:11 +0100 (CET) Received: (qmail 11388 invoked from network); 28 Jan 2017 15:50:19 -0000 Received: from localhost (HELO aetey.se) (eh1ba719@127.0.0.1) by mail with ESMTPA; 28 Jan 2017 15:50:19 -0000 Date: Sat, 28 Jan 2017 17:12:08 +0100 From: u-9iep@aetey.se To: FFmpeg development discussions and patches Message-ID: <20170128161208.GN1516@example.net> MIME-Version: 1.0 Content-Disposition: inline Subject: [FFmpeg-devel] patch 3 (of 3): comment FIX in libavcodec/cinepak.c X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Fix a plainly wrong (inverted) misleading comment in the cinepak decoder. No code changes. I kindly ask to apply this fix, which of course was due from the beginning. Attaching the patch. Regards, Rune --- libavcodec/cinepak.c.orig 2017-01-28 17:00:37.000000000 +0100 +++ libavcodec/cinepak.c 2017-01-28 17:04:20.513123515 +0100 @@ -155,8 +155,8 @@ } } } -/* to get the correct picture for not-multiple-of-4 cases let us fill - * each block from the bottom up, thus possibly overwriting the top line +/* to get the correct picture for not-multiple-of-4 cases let us fill each + * block from the bottom up, thus possibly overwriting the bottommost line * more than once but ending with the correct data in place * (instead of in-loop checking) */