From patchwork Wed Feb 8 23:19:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rostislav Pehlivanov X-Patchwork-Id: 2457 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.89.21 with SMTP id n21csp52340vsb; Wed, 8 Feb 2017 15:24:58 -0800 (PST) X-Received: by 10.223.153.15 with SMTP id x15mr30947wrb.179.1486596298712; Wed, 08 Feb 2017 15:24:58 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id h71si4098518wmd.143.2017.02.08.15.24.58; Wed, 08 Feb 2017 15:24:58 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 550FF689CAD; Thu, 9 Feb 2017 01:24:53 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C0FDE689BDC for ; Thu, 9 Feb 2017 01:24:46 +0200 (EET) Received: by mail-wm0-f67.google.com with SMTP id u63so502355wmu.2 for ; Wed, 08 Feb 2017 15:24:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=tWQSgyacQ9CzpHO6zh9GBRYZZmJRTTzbEHsmZyUBk/A=; b=Fjj/iaEdqVF1kGa3getpmDQ6b5oLjauW0xKZZMT/ZF9/jqzkT/b3UKn67ssHf2YCu8 3D9jCRbyxivQn8Yqw/VFXlw5AF+h+YpDkfHwnwgjkFT4aCB2WPdp+UVLFEUfL6/8Fv3i 9s4A88NKA1eygRElrQZApZUbddc3dYTtFITeCKStILwDFHO/dZEargf0Nvbsvfhc77OA vQ65D9FoSSl+q4gK3ikqAHYMl+5U4mtdT4VR2UBNSth0HEEddQIP0DkRt0B+t6bH2kGW ErymPQFvhqNbRwSbvveo5Yk08gC6gX6QfLq0KQ7HQuwn6BT9RCsACZjf+V8RL+KsXdvc X14Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=tWQSgyacQ9CzpHO6zh9GBRYZZmJRTTzbEHsmZyUBk/A=; b=aHw5tMLszomnuE8wLxoIoVDnUi7F50RaqFeShBQzYC0ljI18vc0tqZE4rl+PgjSCIZ zqSt2ySut5UbQQHfxbYjKm991aRijmv2soIYvmNUbv86JaZ+jbgbuOtiqeoFdZ3qiQC7 xwPVtBrP1NcpEnvLPWn1xfb3Dy3jlgJePpdPoca7BFcZ7OETeKZlCSqs02B300dmeZVb XjRkeH6/vSDdL0Rlut0MMpmwP63QhsEtkLx9+4MubKMr8gc9yTc5KdxTbrmaAbKb43tZ irWEeFjCsTZwC+F0h82lOC3iIBgbN4Wkvd+ZRny0xzLW1kW0rW7yTjfTsiJUEirHfael fMBg== X-Gm-Message-State: AMke39kXdd8/GRv81NWzdD46V8IQ+VE+yEj3yfPMyEmNanmXZZmXAroG0vn6tn8DEEM42w== X-Received: by 10.28.197.142 with SMTP id v136mr20519253wmf.62.1486595976845; Wed, 08 Feb 2017 15:19:36 -0800 (PST) Received: from moonbase.lan (host86-146-193-232.range86-146.btcentralplus.com. [86.146.193.232]) by smtp.gmail.com with ESMTPSA id w99sm15487344wrb.5.2017.02.08.15.19.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Feb 2017 15:19:36 -0800 (PST) From: Rostislav Pehlivanov To: ffmpeg-devel@ffmpeg.org Date: Wed, 8 Feb 2017 23:19:22 +0000 Message-Id: <20170208231922.43398-1-atomnuker@gmail.com> X-Mailer: git-send-email 2.11.0.483.g087da7b7c Subject: [FFmpeg-devel] [PATCH] mjpegenc_huffman: fix uninitialized variable usage X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Rostislav Pehlivanov , jerryjiang1128@gmail.com MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Happened when max_length == 0, in which case i wasn't set to 0 during the first run. i is supposed to already be at the maximum size when the max_length is 0. Fixes CID1400146 Signed-off-by: Rostislav Pehlivanov --- libavcodec/mjpegenc_huffman.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mjpegenc_huffman.c b/libavcodec/mjpegenc_huffman.c index a5d7d5365b..075473429c 100644 --- a/libavcodec/mjpegenc_huffman.c +++ b/libavcodec/mjpegenc_huffman.c @@ -81,7 +81,7 @@ void ff_mjpegenc_huffman_compute_bits(PTable *prob_table, HuffTable *distincts, { PackageMergerList list_a, list_b, *to = &list_a, *from = &list_b, *temp; - int times, i, j, k; + int times, i = size, j, k; int nbits[257] = {0};