From patchwork Mon Mar 6 09:08:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rostislav Pehlivanov X-Patchwork-Id: 2765 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.31.14 with SMTP id f14csp1310945vsf; Mon, 6 Mar 2017 01:08:54 -0800 (PST) X-Received: by 10.223.170.3 with SMTP id p3mr14903563wrd.100.1488791334606; Mon, 06 Mar 2017 01:08:54 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 8si13800348wmh.1.2017.03.06.01.08.54; Mon, 06 Mar 2017 01:08:54 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3E818680CA1; Mon, 6 Mar 2017 11:08:39 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qk0-f170.google.com (mail-qk0-f170.google.com [209.85.220.170]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 49650680495 for ; Mon, 6 Mar 2017 11:08:32 +0200 (EET) Received: by mail-qk0-f170.google.com with SMTP id y76so11947109qkb.0 for ; Mon, 06 Mar 2017 01:08:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=hMtk60r17cUQzYy1IJGCLpoR+iOYiL9cF+VkVsJAYWg=; b=Yrb5JYzo/6pXHq7DrkaZ1OHTz7cVcu10z3hw/NVfgRAkFALR3oYHPJN4qwkGMn+FGv mtRmgTrkhm7Vwh7ziqpRJh8q2vgiOZR+Vt2sf/OuB0eG/1F64GQGuv8PC5na+WEKX7es L4ryOnAo2zDKerTsTutnXyoEgAd66/WCQPsP+8pQyGWV9qjoiAqXgUDeabPSJRADzgbe ny6goy4AVX5v7SNU7yOlb9dkTN+9XBlUErniiql2DUWdGxSRNoWlIMTdKaTFAg6gvJTi ddgh72eUrFUa+jOk5KTxh6AQDXDFitYPtpdToPU+dtBZPPip7D2zZVJVZPDapLI21soW hOTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=hMtk60r17cUQzYy1IJGCLpoR+iOYiL9cF+VkVsJAYWg=; b=ps5sPJmMVOzj1fc/AMkmxqEM9l+Psk2P8rhGW/0S0UsVvWcWkFmBZbqu1hvztQlLoJ Pj9bhEY5eF7tAjsr7fxCTM9aIVFsUb1VgQ64mHPMUnGVq8NHufbJYUmrZmPyLn22BLJY E++Clr2A/PcKmkv+NNzzXzLeYpBBQKi1uuoG7W5KjkvUyDYZJQ2dJFYhFrywf6eQLwiW 5ZI6YSaHZTMLlfJf6OaDgPOOn0LiO5La+H6JNe1RALQ0Iksfi3496hfL18rtjxjSDjYJ E+msAZQ2Qw/BetbmUkwccjKMWjaBYqAdmfRMVlP8sAmBfneqSoNrq9QuL4ty6IIvAM98 foTg== X-Gm-Message-State: AMke39lXB38ia+lMvfa31aN2+mr3Zsl5moUX2uZIW7BGAbfXYaPP02hJ4vJeQ+y6fSbG5xJ+PJSaMedw/Tv8/Q== X-Received: by 10.200.47.161 with SMTP id l30mr15261025qta.248.1488791323563; Mon, 06 Mar 2017 01:08:43 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.40.180 with HTTP; Mon, 6 Mar 2017 01:08:43 -0800 (PST) In-Reply-To: References: <20170306084821.2204-1-atomnuker@gmail.com> From: Rostislav Pehlivanov Date: Mon, 6 Mar 2017 09:08:43 +0000 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.20 Subject: Re: [FFmpeg-devel] [PATCH] lavfi: rename af_aresample to af_resample X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On 6 March 2017 at 09:00, Carl Eugen Hoyos wrote: > 2017-03-06 9:48 GMT+01:00 Rostislav Pehlivanov : > > > +AVFilter ff_af_resample = { > > + .name = "resample", > > Why? Do we really need two identical filters with similar name? > > We cannot remove the "aresample" filter that is mentioned > all over our documentation. > We did not support he resample filter for several years, > removing it can't be an issue. > > Carl Eugen > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > Yeah, I agree, I'd prefer af_aresample to remain. Most of our filters use af_a for audio and vf_ for video (e.g. af_apad and vf_pad). I'd be happy with the filename remaining af_aresample and the filter remaining as af_aresample but also providing af_resample (that is if there's a real need for it; I don't believe there is but maybe someone can say there is). I've attached a patch which does that. From 7a7b31afd4211ba980f73e7d3247d00d3bc563b1 Mon Sep 17 00:00:00 2001 From: Rostislav Pehlivanov Date: Mon, 6 Mar 2017 09:06:19 +0000 Subject: [PATCH] af_aresample: provide af_resample Signed-off-by: Rostislav Pehlivanov --- libavfilter/af_aresample.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/libavfilter/af_aresample.c b/libavfilter/af_aresample.c index 028e105318..1ee02a96ad 100644 --- a/libavfilter/af_aresample.c +++ b/libavfilter/af_aresample.c @@ -349,3 +349,16 @@ AVFilter ff_af_aresample = { .inputs = aresample_inputs, .outputs = aresample_outputs, }; + +/* af_resample got removed, this provides compatibility for now */ +AVFilter ff_af_resample = { + .name = "resample", + .description = NULL_IF_CONFIG_SMALL("Resample audio data."), + .init_dict = init_dict, + .uninit = uninit, + .query_formats = query_formats, + .priv_size = sizeof(AResampleContext), + .priv_class = &aresample_class, + .inputs = aresample_inputs, + .outputs = aresample_outputs, +}; -- 2.12.0.rc1.440.g5b76565f74