Message ID | CAEuSpvhVhqavMncCQ=bU2ATrSv4azbK-XMO9iQwyb0bfT2tOwg@mail.gmail.com |
---|---|
State | Superseded |
Headers | show |
On Sat, 11 Mar 2017 at 20:56 Katherine Frances Nagels <kfnagels@gmail.com> wrote: > Hi ffmpeg-devel, > > This is my first time submitting a patch, so I hope I'm on the right track. > > I noticed that not all of the -vf colormatrix options described in ffmpeg > -h filter=colormatrix are included in the docs at > https://ffmpeg.org/ffmpeg-all.html#colormatrix. > Therefore, I've added the missing options. > Looks good to me. Kieran
On Sun, Mar 12, 2017 at 09:49:37AM +1300, Katherine Frances Nagels wrote: > Hi ffmpeg-devel, > > This is my first time submitting a patch, so I hope I'm on the right track. > > I noticed that not all of the -vf colormatrix options described in ffmpeg > -h filter=colormatrix are included in the docs at > https://ffmpeg.org/ffmpeg-all.html#colormatrix. > Therefore, I've added the missing options. > > I've attached the patch (via git format-patch -1), here are the contents > directly: > > From 0bdaddb3ab2d96a975ac29307ecd2bd7a3ab177c Mon Sep 17 00:00:00 2001 > > From: Katherine Nagels <kfnagels@gmail.com> > > Date: Sun, 12 Mar 2017 09:39:47 +1300 > > Subject: [PATCH] Update colormatrix values --- > > doc/filters.texi | 15 ++++++++++++--- > > 1 file changed, 12 insertions(+), 3 deletions(-) diff --git > > a/doc/filters.texi b/doc/filters.texi > > index 192a81a..950ff81 100644 > > --- a/doc/filters.texi > > +++ b/doc/filters.texi > > @@ -5260,15 +5260,24 @@ The accepted values are: > > @item bt709 > > BT.709 > > > > +@item fcc > > +FCC > > + > > @item bt601 > > BT.601 > > > > +@item bt470 > > +BT.470 > > + > > +@item bt470bg > > +BT.470BG > > + > > +@item smpte170m > > +SMPTE-170M > > + > > @item smpte240m > > SMPTE-240M > > > > -@item fcc > > -FCC > > - > > @item bt2020 > > BT.2020 > > @end table > > -- > > 2.7.4 > > > Thank you. > > Best, Katherine > filters.texi | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > 836420957f84fcf3b9c9253d2419d632520b05c2 0001-Update-colormatrix-values.patch > From 0bdaddb3ab2d96a975ac29307ecd2bd7a3ab177c Mon Sep 17 00:00:00 2001 > From: Katherine Nagels <kfnagels@gmail.com> > Date: Sun, 12 Mar 2017 09:39:47 +1300 > Subject: [PATCH] Update colormatrix values This commit message does not comply to to our formating requiremets its also too general. "update" can mean alot [...]
From 0bdaddb3ab2d96a975ac29307ecd2bd7a3ab177c Mon Sep 17 00:00:00 2001 From: Katherine Nagels <kfnagels@gmail.com> Date: Sun, 12 Mar 2017 09:39:47 +1300 Subject: [PATCH] Update colormatrix values --- doc/filters.texi | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 192a81a..950ff81 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -5260,15 +5260,24 @@ The accepted values are: @item bt709 BT.709 +@item fcc +FCC + @item bt601 BT.601 +@item bt470 +BT.470 + +@item bt470bg +BT.470BG + +@item smpte170m +SMPTE-170M + @item smpte240m SMPTE-240M -@item fcc -FCC - @item bt2020 BT.2020 @end table -- 2.7.4