From patchwork Fri Mar 17 13:18:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: James Darnley X-Patchwork-Id: 2990 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.50.79 with SMTP id y76csp261974vsy; Fri, 17 Mar 2017 06:28:00 -0700 (PDT) X-Received: by 10.223.154.44 with SMTP id z41mr13015539wrb.188.1489757280265; Fri, 17 Mar 2017 06:28:00 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id m196si3296005wmg.8.2017.03.17.06.27.59; Fri, 17 Mar 2017 06:28:00 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@ob-encoder-com.20150623.gappssmtp.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5A80F688352; Fri, 17 Mar 2017 15:27:39 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 301B96882D1 for ; Fri, 17 Mar 2017 15:27:33 +0200 (EET) Received: by mail-wm0-f67.google.com with SMTP id n11so3309801wma.0 for ; Fri, 17 Mar 2017 06:27:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ob-encoder-com.20150623.gappssmtp.com; s=20150623; h=sender:from:to:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FAB+eM49x2jpUo6k3U/FnLkz4igPxRbl/kHkiYSkrQc=; b=d6NfK1v1bTEcLgMzZH4rHMwKxyheypHFVpNwhdZyKwGBQT4BxjxF98H6M7cYB3DThj +qf+MhD9h1HpjfG1n388zvoxYe1hs1OGqVOrnNx10U4Q23Oj/BTDDIUefk3CMNSJWFgs w2v0axnkLj9ln6h3RDKfqHPMV8+fYv/fbh+sRj/9HhXVwmW5iwMGtdAv8tJqyG2OQ+QZ f4RivTj1oHl8OjIpwKQ82NYbRdCHWYpStZNsGGT4iLvaDdi/NebwCtAi6RyTwLdHAJMm Q/R7q+Iwsb4lXvXet6eWER7fUlkW3i+RaesnluFzAFRwTLqe9nnQaO+96PBS34lyLMya zHDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=FAB+eM49x2jpUo6k3U/FnLkz4igPxRbl/kHkiYSkrQc=; b=CkC1Hc62ufRHFfrHoh/KwHtSWzGDh/OGok0l3WsdspWBHdhFpRvjVZsW5M8cHgSDvf EmbG/yfs2wikI3iCtL2ajgjBUH44eYAk5eqmMvRVmb3gdcBsCDBmNghAEJ05+dBPVvIQ i9xmcQAJfSmhCOHTjHg7QMmi3sNBIxzLN5IL8BoDG+S2Q7BGnzcsyilMwVVagSBVy5Df P/xV7MemBdOW3f99W/G5c4WqpWsb2aYNNg/sogl2dJbx4NoO+8DBahO0dKdT7pUn4MWm 8zRz12ULF4OWYjCp0Znh3wnqf3WEMbmWkO83JTFIr4u4yH16GUgnr4ONPXBD5PgG/saT kcZQ== X-Gm-Message-State: AFeK/H1YQhFcn2GnWK1GNRdZrixUhBUi8lu64SbHQSq9eW+U7ahraiC8YwPAxswxW8g4Sg== X-Received: by 10.28.236.209 with SMTP id h78mr2989749wmi.97.1489756770026; Fri, 17 Mar 2017 06:19:30 -0700 (PDT) Received: from localhost.localdomain (d51a44418.access.telenet.be. [81.164.68.24]) by smtp.gmail.com with ESMTPSA id e72sm2676411wma.5.2017.03.17.06.19.29 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Mar 2017 06:19:29 -0700 (PDT) From: James Darnley To: FFmpeg development discussions and patches Date: Fri, 17 Mar 2017 14:18:42 +0100 Message-Id: <20170317131845.7760-8-jdarnley@obe.tv> X-Mailer: git-send-email 2.8.3 In-Reply-To: <20170317131845.7760-1-jdarnley@obe.tv> References: <20170317131845.7760-1-jdarnley@obe.tv> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 07/10] h264_idct8_dc_add X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" 1.12x faster (638±12.7 vs. 568±4.3 decicycles) compared with mmxext --- libavcodec/x86/h264_idct.asm | 11 +++++++++++ libavcodec/x86/h264dsp_init.c | 2 ++ 2 files changed, 13 insertions(+) diff --git a/libavcodec/x86/h264_idct.asm b/libavcodec/x86/h264_idct.asm index c4b6e55..a74e095 100644 --- a/libavcodec/x86/h264_idct.asm +++ b/libavcodec/x86/h264_idct.asm @@ -1188,3 +1188,14 @@ cglobal h264_idct_dc_add_8, 3, 4, 0, dst_, block_, stride_ DC_ADD_INIT r3 DC_ADD_MMXEXT_OP movd, dst_q, stride_q, r3 RET + +; Not any faster +cglobal h264_idct8_dc_add_8, 3, 4, 0 + movsxdifnidn stride_q, stride_d + movsx r3d, word [block_q] + mov dword [block_q], 0 + DC_ADD_INIT r3 + DC_ADD_MMXEXT_OP movq, dst_q, stride_q, r3 + lea dst_q, [dst_q + stride_q*4] + DC_ADD_MMXEXT_OP movq, dst_q, stride_q, r3 +RET diff --git a/libavcodec/x86/h264dsp_init.c b/libavcodec/x86/h264dsp_init.c index 1aa66a8..de7becf 100644 --- a/libavcodec/x86/h264dsp_init.c +++ b/libavcodec/x86/h264dsp_init.c @@ -38,6 +38,7 @@ IDCT_ADD_FUNC(_dc, 8, mmxext) IDCT_ADD_FUNC(_dc, 8, avx) IDCT_ADD_FUNC(_dc, 10, mmxext) IDCT_ADD_FUNC(8_dc, 8, mmxext) +IDCT_ADD_FUNC(8_dc, 8, avx) IDCT_ADD_FUNC(8_dc, 10, sse2) IDCT_ADD_FUNC(8, 8, mmx) IDCT_ADD_FUNC(8, 8, sse2) @@ -344,6 +345,7 @@ av_cold void ff_h264dsp_init_x86(H264DSPContext *c, const int bit_depth, c->h264_idct_add = ff_h264_idct_add_8_avx; c->h264_idct8_add = ff_h264_idct8_add_8_avx; c->h264_idct_dc_add = ff_h264_idct_dc_add_8_avx; + c->h264_idct8_dc_add = ff_h264_idct8_dc_add_8_avx; } } else if (bit_depth == 10) { if (EXTERNAL_MMXEXT(cpu_flags)) {