[FFmpeg-devel] vda: add necessary includes to pass make checkheaders.

Submitted by Ronald S. Bultje on March 28, 2017, 9:35 p.m.

Details

Message ID 1490736908-21760-1-git-send-email-rsbultje@gmail.com
State New
Headers show

Commit Message

Ronald S. Bultje March 28, 2017, 9:35 p.m.
---
 libavcodec/vda_vt_internal.h | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Clément Bœsch March 28, 2017, 9:38 p.m.
On Tue, Mar 28, 2017 at 05:35:08PM -0400, Ronald S. Bultje wrote:
> ---
>  libavcodec/vda_vt_internal.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/libavcodec/vda_vt_internal.h b/libavcodec/vda_vt_internal.h
> index 9ff63cc..458ebb4 100644
> --- a/libavcodec/vda_vt_internal.h
> +++ b/libavcodec/vda_vt_internal.h
> @@ -19,6 +19,13 @@
>  #ifndef AVCODEC_VDA_VT_INTERNAL_H
>  #define AVCODEC_VDA_VT_INTERNAL_H
>  
> +#include <stdint.h>
> +#define Picture QuickdrawPicture
> +#include <VideoDecodeAcceleration/VDADecoder.h>
> +#undef Picture
> +

That define looks wrong...

But in any case, I think that header belongs in the SKIPHEADERS in
lavc/Makefile.
Ronald S. Bultje March 28, 2017, 9:44 p.m.
Hi,

On Tue, Mar 28, 2017 at 5:38 PM, Clément Bœsch <u@pkh.me> wrote:

> On Tue, Mar 28, 2017 at 05:35:08PM -0400, Ronald S. Bultje wrote:
> > ---
> >  libavcodec/vda_vt_internal.h | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/libavcodec/vda_vt_internal.h b/libavcodec/vda_vt_internal.h
> > index 9ff63cc..458ebb4 100644
> > --- a/libavcodec/vda_vt_internal.h
> > +++ b/libavcodec/vda_vt_internal.h
> > @@ -19,6 +19,13 @@
> >  #ifndef AVCODEC_VDA_VT_INTERNAL_H
> >  #define AVCODEC_VDA_VT_INTERNAL_H
> >
> > +#include <stdint.h>
> > +#define Picture QuickdrawPicture
> > +#include <VideoDecodeAcceleration/VDADecoder.h>
> > +#undef Picture
> > +
>
> That define looks wrong...
>
> But in any case, I think that header belongs in the SKIPHEADERS in
> lavc/Makefile.


Sure, sent a patch to do that instead then.

Ronald

Patch hide | download patch | download mbox

diff --git a/libavcodec/vda_vt_internal.h b/libavcodec/vda_vt_internal.h
index 9ff63cc..458ebb4 100644
--- a/libavcodec/vda_vt_internal.h
+++ b/libavcodec/vda_vt_internal.h
@@ -19,6 +19,13 @@ 
 #ifndef AVCODEC_VDA_VT_INTERNAL_H
 #define AVCODEC_VDA_VT_INTERNAL_H
 
+#include <stdint.h>
+#define Picture QuickdrawPicture
+#include <VideoDecodeAcceleration/VDADecoder.h>
+#undef Picture
+
+#include "libavcodec/avcodec.h"
+
 void ff_vda_output_callback(void *vda_hw_ctx,
                             CFDictionaryRef user_info,
                             OSStatus status,