| Message ID | 201703282357.42561.cehoyos@ag.or.at |
|---|---|
| State | Accepted |
| Headers | show |
On 3/28/17, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote: > Hi! > > libavformat contains a codec point for WMAv2 for many years, it allows to > write undecodable files but does not allow to decode existing (flip4mac) > files. > I believe the flip4mac files should be read differently, without using > the code point. > > Please comment, Carl Eugen > Who added it, when and why?
2017-03-29 23:36 GMT+02:00 Paul B Mahol <onemda@gmail.com>: > On 3/28/17, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote: >> Hi! >> >> libavformat contains a codec point for WMAv2 for many years, it allows to >> write undecodable files but does not allow to decode existing (flip4mac) >> files. >> I believe the flip4mac files should be read differently, without using >> the code point. >> >> Please comment, Carl Eugen > > Who added it, when and why? Michael in 200x assuming it would make decoding such files easier. Carl Eugen
2017-03-28 23:57 GMT+02:00 Carl Eugen Hoyos <cehoyos@ag.or.at>: > Hi! > > libavformat contains a codec point for WMAv2 for many years, it allows to > write undecodable files but does not allow to decode existing (flip4mac) > files. > I believe the flip4mac files should be read differently, without using > the code point. Patch applied, Carl Eugen
From 05f8ac8e0d583eeb20a273abeadfc5780a54cbab Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos <cehoyos@ag.or.at> Date: Tue, 28 Mar 2017 23:55:01 +0200 Subject: [PATCH] lavf/isom: Remove codec point for WMAv2 that has never worked. --- libavformat/isom.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/isom.c b/libavformat/isom.c index 7da2700..470bb34 100644 --- a/libavformat/isom.c +++ b/libavformat/isom.c @@ -353,7 +353,6 @@ const AVCodecTag ff_codec_movaudio_tags[] = { { AV_CODEC_ID_QDMC, MKTAG('Q', 'D', 'M', 'C') }, { AV_CODEC_ID_SPEEX, MKTAG('s', 'p', 'e', 'x') }, /* Flash Media Server */ { AV_CODEC_ID_SPEEX, MKTAG('S', 'P', 'X', 'N') }, /* ZygoAudio (quality 10 mode) */ - { AV_CODEC_ID_WMAV2, MKTAG('W', 'M', 'A', '2') }, { AV_CODEC_ID_EVRC, MKTAG('s', 'e', 'v', 'c') }, /* 3GPP2 */ { AV_CODEC_ID_SMV, MKTAG('s', 's', 'm', 'v') }, /* 3GPP2 */ { AV_CODEC_ID_FLAC, MKTAG('f', 'L', 'a', 'C') }, /* nonstandard */ -- 1.7.10.4