[FFmpeg-devel] Fix leaked dictionary in mp3dec

Message ID	CABrVPobNBCAu4uOVWfzH+MR8Hb7W8hL-7vpy9-nUnXrwaQMOPw@mail.gmail.com
State	Superseded
Headers	show Delivered-To: ffmpegpatchwork@gmail.com Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; MIME-Version: 1.0 From: Thomas Guilbert <tguilbert@chromium.org> Date: Fri, 31 Mar 2017 12:39:49 -0700 Message-ID: <CABrVPobNBCAu4uOVWfzH+MR8Hb7W8hL-7vpy9-nUnXrwaQMOPw@mail.gmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: multipart/mixed; boundary=001a113fb31ed34f90054c0bfa9d Subject: [FFmpeg-devel] Fix leaked dictionary in mp3dec Precedence: list Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>

Message ID

CABrVPobNBCAu4uOVWfzH+MR8Hb7W8hL-7vpy9-nUnXrwaQMOPw@mail.gmail.com

State

Superseded

Headers

Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org
	designates 79.124.17.100 as permitted sender)
	client-ip=79.124.17.100; 
MIME-Version: 1.0
From: Thomas Guilbert <tguilbert@chromium.org>
Date: Fri, 31 Mar 2017 12:39:49 -0700
Message-ID: <CABrVPobNBCAu4uOVWfzH+MR8Hb7W8hL-7vpy9-nUnXrwaQMOPw@mail.gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: multipart/mixed; boundary=001a113fb31ed34f90054c0bfa9d
Subject: [FFmpeg-devel] Fix leaked dictionary in mp3dec
Precedence: list
Reply-To: FFmpeg development discussions and patches
	<ffmpeg-devel@ffmpeg.org>
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>

Commit Message

Thomas Guilbert March 31, 2017, 7:39 p.m. UTC

Commit '65862f57ad2f7f49d715f334a9d892e0b20d42f1' overwrites s->metada
with s->internal->id3v2_meta, which leaks an AVDictionary* if
s->metada was not null.

Please excuse any formatting problems in this email, this is my first
time uploading a patch :)

Thank you,
Thomas

RnJvbSBmY2VkNWFiMGUwOWY1MjkzOTdhZGRkY2I1NjBkMWEwOGYyZGY0ODQwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUaG9tYXMgR3VpbGJlcnQgPHRndWlsYmVydEBjaHJvbWl1bS5v
cmc+CkRhdGU6IFRodSwgMzAgTWFyIDIwMTcgMTg6MjM6MjkgLTA3MDAKU3ViamVjdDogW1BBVENI
XSBGaXggZGljdGlvbm5hcnkgbGVhayBpbiBtcDNkZWMKCi0tLQogbGliYXZmb3JtYXQvbXAzZGVj
LmMgfCAxICsKIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQoKZGlmZiAtLWdpdCBhL2xp
YmF2Zm9ybWF0L21wM2RlYy5jIGIvbGliYXZmb3JtYXQvbXAzZGVjLmMKaW5kZXggMDkyNGE1Nzg0
My4uZmQ4MTg0Y2MwYiAxMDA2NDQKLS0tIGEvbGliYXZmb3JtYXQvbXAzZGVjLmMKKysrIGIvbGli
YXZmb3JtYXQvbXAzZGVjLmMKQEAgLTM0OSw2ICszNDksNyBAQCBzdGF0aWMgaW50IG1wM19yZWFk
X2hlYWRlcihBVkZvcm1hdENvbnRleHQgKnMpCiAgICAgaW50IHJldDsKICAgICBpbnQgaTsKIAor
ICAgIGF2X2RpY3RfZnJlZSgmcy0+bWV0YWRhdGEpOwogICAgIHMtPm1ldGFkYXRhID0gcy0+aW50
ZXJuYWwtPmlkM3YyX21ldGE7CiAgICAgcy0+aW50ZXJuYWwtPmlkM3YyX21ldGEgPSBOVUxMOwog
Ci0tIAoyLjEyLjIuNTY0LmcwNjNmZTg1OGI4LWdvb2cKCg==

[FFmpeg-devel] Fix leaked dictionary in mp3dec

Commit Message

Patch