From patchwork Fri Mar 31 19:39:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Guilbert X-Patchwork-Id: 3228 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.44.195 with SMTP id s186csp2190251vss; Fri, 31 Mar 2017 12:46:15 -0700 (PDT) X-Received: by 10.28.149.85 with SMTP id x82mr3075729wmd.110.1490989574019; Fri, 31 Mar 2017 12:46:14 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id n5si9411344wra.31.2017.03.31.12.46.13; Fri, 31 Mar 2017 12:46:13 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@chromium.org; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EC9C2689A0C; Fri, 31 Mar 2017 22:46:09 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com [209.85.215.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2E2F96808BC for ; Fri, 31 Mar 2017 22:46:03 +0300 (EEST) Received: by mail-lf0-f51.google.com with SMTP id z15so49050768lfd.1 for ; Fri, 31 Mar 2017 12:46:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:from:date:message-id:subject:to; bh=Kz/kZmSJe+b5DqSas0DCLoIaSgFh1f6TiatDx2tOxxg=; b=GVrYHCUndtM62sztFurjypx1RFcHliq/+mmb9zo80rVtPM3X0io5ZeB+bHxdVWc7H3 kWODlP4CLRXOnSRC+4xEjTUQ++yvV+9Mq8CudQOykxG01VvnGsayppuSL/XMXazas13D Xub5gvvRAJ4Y5UJJVwBGq4USWakglcR5hNwKU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Kz/kZmSJe+b5DqSas0DCLoIaSgFh1f6TiatDx2tOxxg=; b=MrFJhHL1LY2DqEh+KvkeFaUgY1z3JkikupS9Vrw36tjrj06dl5y44XRLGeegKb7YTV WO09H4yWvGOWD2vxX/+um18qsqTiYr+T/V1LPnBa0T2SVvclS0uSw+dI4SSGwvodJA3l cFT1FhHkteuRxAbjPvrERd5k8o3Vfwwzl6jio6qhcWb7b4FJKCjtdHNrxFy68PqRx9XJ 7euzBu5dHZWsJdWyw+y5F//lvFXlY/0XFTJViPFLL5c3bpOioBKvnxCpj78ekjKScj/M E//QZUjPB4qiAqp2bHnSNe3qKMklqJdlz/MZtiAciZjHAR2jqMRXZlxs4Smxrg+rqaX7 uZzw== X-Gm-Message-State: AFeK/H25/z7g/EQU8DSqFDyVuXV4n7cReEABbcE/UZh5Q4ZPCkOHb4Xuk8jjPEBLiZVOTSwS X-Received: by 10.46.20.87 with SMTP id 23mr1646883lju.54.1490989221333; Fri, 31 Mar 2017 12:40:21 -0700 (PDT) Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com. [209.85.215.52]) by smtp.gmail.com with ESMTPSA id y25sm1097864lja.7.2017.03.31.12.40.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Mar 2017 12:40:20 -0700 (PDT) Received: by mail-lf0-f52.google.com with SMTP id z15so48993954lfd.1 for ; Fri, 31 Mar 2017 12:40:20 -0700 (PDT) X-Received: by 10.25.20.101 with SMTP id k98mr1324142lfi.13.1490989220028; Fri, 31 Mar 2017 12:40:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.99.209 with HTTP; Fri, 31 Mar 2017 12:39:49 -0700 (PDT) From: Thomas Guilbert Date: Fri, 31 Mar 2017 12:39:49 -0700 X-Gmail-Original-Message-ID: Message-ID: To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Fix leaked dictionary in mp3dec X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Commit '65862f57ad2f7f49d715f334a9d892e0b20d42f1' overwrites s->metada with s->internal->id3v2_meta, which leaks an AVDictionary* if s->metada was not null. Please excuse any formatting problems in this email, this is my first time uploading a patch :) Thank you, Thomas RnJvbSBmY2VkNWFiMGUwOWY1MjkzOTdhZGRkY2I1NjBkMWEwOGYyZGY0ODQwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaG9tYXMgR3VpbGJlcnQgPHRndWlsYmVydEBjaHJvbWl1bS5v cmc+CkRhdGU6IFRodSwgMzAgTWFyIDIwMTcgMTg6MjM6MjkgLTA3MDAKU3ViamVjdDogW1BBVENI XSBGaXggZGljdGlvbm5hcnkgbGVhayBpbiBtcDNkZWMKCi0tLQogbGliYXZmb3JtYXQvbXAzZGVj LmMgfCAxICsKIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQoKZGlmZiAtLWdpdCBhL2xp YmF2Zm9ybWF0L21wM2RlYy5jIGIvbGliYXZmb3JtYXQvbXAzZGVjLmMKaW5kZXggMDkyNGE1Nzg0 My4uZmQ4MTg0Y2MwYiAxMDA2NDQKLS0tIGEvbGliYXZmb3JtYXQvbXAzZGVjLmMKKysrIGIvbGli YXZmb3JtYXQvbXAzZGVjLmMKQEAgLTM0OSw2ICszNDksNyBAQCBzdGF0aWMgaW50IG1wM19yZWFk X2hlYWRlcihBVkZvcm1hdENvbnRleHQgKnMpCiAgICAgaW50IHJldDsKICAgICBpbnQgaTsKIAor ICAgIGF2X2RpY3RfZnJlZSgmcy0+bWV0YWRhdGEpOwogICAgIHMtPm1ldGFkYXRhID0gcy0+aW50 ZXJuYWwtPmlkM3YyX21ldGE7CiAgICAgcy0+aW50ZXJuYWwtPmlkM3YyX21ldGEgPSBOVUxMOwog Ci0tIAoyLjEyLjIuNTY0LmcwNjNmZTg1OGI4LWdvb2cKCg==