[FFmpeg-devel] doc/APIChage: Add av_strireplace()

Submitted by Steven Liu on April 11, 2017, 3 a.m.

Details

Message ID 20170411030007.57380-1-lq@chinaffmpeg.org
State New
Headers show

Commit Message

Steven Liu April 11, 2017, 3 a.m.
Add av_strireplace() into APIChange

Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
---
 doc/APIchanges | 3 +++
 1 file changed, 3 insertions(+)

Comments

James Almer April 11, 2017, 3:09 a.m.
On 4/11/2017 12:00 AM, Steven Liu wrote:
> Add av_strireplace() into APIChange
> 
> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
> ---
>  doc/APIchanges | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/doc/APIchanges b/doc/APIchanges
> index 1aced2f6a4..9fc59945ed 100644
> --- a/doc/APIchanges
> +++ b/doc/APIchanges
> @@ -15,6 +15,9 @@ libavutil:     2015-08-28
>  
>  API changes, most recent first:
>  
> +2017-04-11 - xxxxxxx - lavu 55.60.101 - avstring.h
You're supposed to bump the minor version when you introduce
new API.

Update libavutil/version.h in this same patch to 55.61.100 and
report that version here instead.

> +  Add av_strireplace().
> +
>  2016-04-06 - xxxxxxx - lavc 57.92.100 - avcodec.h
>    Add AV_PKT_DATA_CONTENT_LIGHT_LEVEL packet side data.
>  
>
Steven Liu April 11, 2017, 3:49 a.m.
2017-04-11 11:09 GMT+08:00 James Almer <jamrial@gmail.com>:

> On 4/11/2017 12:00 AM, Steven Liu wrote:
> > Add av_strireplace() into APIChange
> >
> > Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
> > ---
> >  doc/APIchanges | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/doc/APIchanges b/doc/APIchanges
> > index 1aced2f6a4..9fc59945ed 100644
> > --- a/doc/APIchanges
> > +++ b/doc/APIchanges
> > @@ -15,6 +15,9 @@ libavutil:     2015-08-28
> >
> >  API changes, most recent first:
> >
> > +2017-04-11 - xxxxxxx - lavu 55.60.101 - avstring.h
> You're supposed to bump the minor version when you introduce
> new API.
>
> Update libavutil/version.h in this same patch to 55.61.100 and
> report that version here instead.
>
Do you mean: add the av_strrepleace for 55.61.100
and add intead by av_strireplace for 55.61.101 ?

>
> > +  Add av_strireplace().
> > +
> >  2016-04-06 - xxxxxxx - lavc 57.92.100 - avcodec.h
> >    Add AV_PKT_DATA_CONTENT_LIGHT_LEVEL packet side data.
> >
> >
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
James Almer April 11, 2017, 3:58 a.m.
On 4/11/2017 12:49 AM, Steven Liu wrote:
> 2017-04-11 11:09 GMT+08:00 James Almer <jamrial@gmail.com>:
> 
>> On 4/11/2017 12:00 AM, Steven Liu wrote:
>>> Add av_strireplace() into APIChange
>>>
>>> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
>>> ---
>>>  doc/APIchanges | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/doc/APIchanges b/doc/APIchanges
>>> index 1aced2f6a4..9fc59945ed 100644
>>> --- a/doc/APIchanges
>>> +++ b/doc/APIchanges
>>> @@ -15,6 +15,9 @@ libavutil:     2015-08-28
>>>
>>>  API changes, most recent first:
>>>
>>> +2017-04-11 - xxxxxxx - lavu 55.60.101 - avstring.h
>> You're supposed to bump the minor version when you introduce
>> new API.
>>
>> Update libavutil/version.h in this same patch to 55.61.100 and
>> report that version here instead.
>>
> Do you mean: add the av_strrepleace for 55.61.100
> and add intead by av_strireplace for 55.61.101 ?

No, just bump once to 55.61.100 and use that version in the
APIChanges line as the introductory version for
av_strireplace, and do it in the same patch.

You're only bumping once to introduce av_strireplace given
that av_strrepleace was technically never made official.

> 
>>
>>> +  Add av_strireplace().
>>> +
>>>  2016-04-06 - xxxxxxx - lavc 57.92.100 - avcodec.h
>>>    Add AV_PKT_DATA_CONTENT_LIGHT_LEVEL packet side data.
>>>
>>>
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

Patch hide | download patch | download mbox

diff --git a/doc/APIchanges b/doc/APIchanges
index 1aced2f6a4..9fc59945ed 100644
--- a/doc/APIchanges
+++ b/doc/APIchanges
@@ -15,6 +15,9 @@  libavutil:     2015-08-28
 
 API changes, most recent first:
 
+2017-04-11 - xxxxxxx - lavu 55.60.101 - avstring.h
+  Add av_strireplace().
+
 2016-04-06 - xxxxxxx - lavc 57.92.100 - avcodec.h
   Add AV_PKT_DATA_CONTENT_LIGHT_LEVEL packet side data.