[FFmpeg-devel,1/2] lavc/mediacodec_wrapper: do not declare JNIAMedia{Codec, Format}Fields on the stack

Submitted by Matthieu Bouron on May 21, 2017, 4:17 p.m.

Details

Message ID 20170521161728.31197-1-matthieu.bouron@gmail.com
State New
Headers show

Commit Message

Matthieu Bouron May 21, 2017, 4:17 p.m.
---
 libavcodec/mediacodec_wrapper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Matthieu Bouron May 21, 2017, 5:09 p.m.
On Sun, May 21, 2017 at 06:17:27PM +0200, Matthieu Bouron wrote:
> ---
>  libavcodec/mediacodec_wrapper.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/mediacodec_wrapper.c b/libavcodec/mediacodec_wrapper.c
> index 5e1beed43a..0f573bfc7a 100644
> --- a/libavcodec/mediacodec_wrapper.c
> +++ b/libavcodec/mediacodec_wrapper.c
> @@ -125,7 +125,7 @@ struct JNIAMediaFormatFields {
>  
>      jmethodID to_string_id;
>  
> -} JNIAMediaFormatFields;
> +};
>  
>  static const struct FFJniField jni_amediaformat_mapping[] = {
>      { "android/media/MediaFormat", NULL, NULL, FF_JNI_CLASS, offsetof(struct JNIAMediaFormatFields, mediaformat_class), 1 },
> @@ -210,7 +210,7 @@ struct JNIAMediaCodecFields {
>      jfieldID presentation_time_us_id;
>      jfieldID size_id;
>  
> -} JNIAMediaCodecFields;
> +};
>  
>  static const struct FFJniField jni_amediacodec_mapping[] = {
>      { "android/media/MediaCodec", NULL, NULL, FF_JNI_CLASS, offsetof(struct JNIAMediaCodecFields, mediacodec_class), 1 },
> -- 
> 2.12.0
> 

Updated locally to include also JNIAMediaCodecListFields.

Patch hide | download patch | download mbox

diff --git a/libavcodec/mediacodec_wrapper.c b/libavcodec/mediacodec_wrapper.c
index 5e1beed43a..0f573bfc7a 100644
--- a/libavcodec/mediacodec_wrapper.c
+++ b/libavcodec/mediacodec_wrapper.c
@@ -125,7 +125,7 @@  struct JNIAMediaFormatFields {
 
     jmethodID to_string_id;
 
-} JNIAMediaFormatFields;
+};
 
 static const struct FFJniField jni_amediaformat_mapping[] = {
     { "android/media/MediaFormat", NULL, NULL, FF_JNI_CLASS, offsetof(struct JNIAMediaFormatFields, mediaformat_class), 1 },
@@ -210,7 +210,7 @@  struct JNIAMediaCodecFields {
     jfieldID presentation_time_us_id;
     jfieldID size_id;
 
-} JNIAMediaCodecFields;
+};
 
 static const struct FFJniField jni_amediacodec_mapping[] = {
     { "android/media/MediaCodec", NULL, NULL, FF_JNI_CLASS, offsetof(struct JNIAMediaCodecFields, mediacodec_class), 1 },