[FFmpeg-devel] vp9: fix overwrite in ff_vp9_ipred_dr_16x16_16_avx2.

Submitted by Ronald S. Bultje on June 14, 2017, 12:46 p.m.

Details

Message ID 1497444372-11508-1-git-send-email-rsbultje@gmail.com
State New
Headers show

Commit Message

Ronald S. Bultje June 14, 2017, 12:46 p.m.
Fixes trac issue 6459.
---
 libavcodec/x86/vp9intrapred_16bpp.asm | 1 -
 1 file changed, 1 deletion(-)

Comments

James Almer June 14, 2017, 3:34 p.m.
On 6/14/2017 9:46 AM, Ronald S. Bultje wrote:
> Fixes trac issue 6459.
> ---
>  libavcodec/x86/vp9intrapred_16bpp.asm | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/libavcodec/x86/vp9intrapred_16bpp.asm b/libavcodec/x86/vp9intrapred_16bpp.asm
> index 764f704..c651c08 100644
> --- a/libavcodec/x86/vp9intrapred_16bpp.asm
> +++ b/libavcodec/x86/vp9intrapred_16bpp.asm
> @@ -1221,7 +1221,6 @@ cglobal vp9_ipred_dr_16x16_16, 4, 5, 6, dst, stride, l, a
>      mova      [dstq+strideq*0], m4                     ; 0
>      sub                   dstq, strideq

If you're not using dst anymore, then you can remove this one as well.

>      mova     [dst3q+strideq*4], m5                     ; 7
> -    mova     [ dstq+strideq*0], m1                     ; -1
>      RET
>  %endif
>  
>
Ronald S. Bultje June 14, 2017, 3:38 p.m.
Hi,

On Wed, Jun 14, 2017 at 11:34 AM, James Almer <jamrial@gmail.com> wrote:

> On 6/14/2017 9:46 AM, Ronald S. Bultje wrote:
> > Fixes trac issue 6459.
> > ---
> >  libavcodec/x86/vp9intrapred_16bpp.asm | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/libavcodec/x86/vp9intrapred_16bpp.asm
> b/libavcodec/x86/vp9intrapred_16bpp.asm
> > index 764f704..c651c08 100644
> > --- a/libavcodec/x86/vp9intrapred_16bpp.asm
> > +++ b/libavcodec/x86/vp9intrapred_16bpp.asm
> > @@ -1221,7 +1221,6 @@ cglobal vp9_ipred_dr_16x16_16, 4, 5, 6, dst,
> stride, l, a
> >      mova      [dstq+strideq*0], m4                     ; 0
> >      sub                   dstq, strideq
>
> If you're not using dst anymore, then you can remove this one as well.
>
> >      mova     [dst3q+strideq*4], m5                     ; 7
> > -    mova     [ dstq+strideq*0], m1                     ; -1
> >      RET
> >  %endif


Indeed, Ilia said the same thing (on IRC) - pushed with that changed.

Ronald

Patch hide | download patch | download mbox

diff --git a/libavcodec/x86/vp9intrapred_16bpp.asm b/libavcodec/x86/vp9intrapred_16bpp.asm
index 764f704..c651c08 100644
--- a/libavcodec/x86/vp9intrapred_16bpp.asm
+++ b/libavcodec/x86/vp9intrapred_16bpp.asm
@@ -1221,7 +1221,6 @@  cglobal vp9_ipred_dr_16x16_16, 4, 5, 6, dst, stride, l, a
     mova      [dstq+strideq*0], m4                     ; 0
     sub                   dstq, strideq
     mova     [dst3q+strideq*4], m5                     ; 7
-    mova     [ dstq+strideq*0], m1                     ; -1
     RET
 %endif