[FFmpeg-devel] avcodec: Rename ff_mpv_decode_mb() to ff_mpv_reconstruct_mb

Submitted by Michael Niedermayer on June 19, 2017, 1:46 a.m.

Details

Message ID 20170619014618.2107-1-michael@niedermayer.cc
State Accepted
Commit f670c13f13999d268c2d565d2e161d6a32fa9715
Headers show

Commit Message

Michael Niedermayer June 19, 2017, 1:46 a.m.
The new name more accuratly describes what the function does

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/avcodec.h        |  2 +-
 libavcodec/h261dec.c        |  4 ++--
 libavcodec/h263dec.c        |  4 ++--
 libavcodec/mpeg12dec.c      |  2 +-
 libavcodec/mpeg_er.c        |  2 +-
 libavcodec/mpegvideo.c      | 12 ++++++------
 libavcodec/mpegvideo.h      |  2 +-
 libavcodec/mpegvideo_enc.c  |  6 +++---
 libavcodec/mpegvideo_xvmc.c |  2 +-
 libavcodec/rv10.c           |  2 +-
 10 files changed, 19 insertions(+), 19 deletions(-)

Comments

Ronald S. Bultje June 19, 2017, 12:48 p.m.
Hi,

On Sun, Jun 18, 2017 at 9:46 PM, Michael Niedermayer <michael@niedermayer.cc
> wrote:

> The new name more accuratly describes what the function does
>
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavcodec/avcodec.h        |  2 +-
>  libavcodec/h261dec.c        |  4 ++--
>  libavcodec/h263dec.c        |  4 ++--
>  libavcodec/mpeg12dec.c      |  2 +-
>  libavcodec/mpeg_er.c        |  2 +-
>  libavcodec/mpegvideo.c      | 12 ++++++------
>  libavcodec/mpegvideo.h      |  2 +-
>  libavcodec/mpegvideo_enc.c  |  6 +++---
>  libavcodec/mpegvideo_xvmc.c |  2 +-
>  libavcodec/rv10.c           |  2 +-
>  10 files changed, 19 insertions(+), 19 deletions(-)


I think this is a good idea, thanks.

Ronald
Michael Niedermayer June 19, 2017, 1:29 p.m.
On Mon, Jun 19, 2017 at 08:48:09AM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Sun, Jun 18, 2017 at 9:46 PM, Michael Niedermayer <michael@niedermayer.cc
> > wrote:
> 
> > The new name more accuratly describes what the function does
> >
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavcodec/avcodec.h        |  2 +-
> >  libavcodec/h261dec.c        |  4 ++--
> >  libavcodec/h263dec.c        |  4 ++--
> >  libavcodec/mpeg12dec.c      |  2 +-
> >  libavcodec/mpeg_er.c        |  2 +-
> >  libavcodec/mpegvideo.c      | 12 ++++++------
> >  libavcodec/mpegvideo.h      |  2 +-
> >  libavcodec/mpegvideo_enc.c  |  6 +++---
> >  libavcodec/mpegvideo_xvmc.c |  2 +-
> >  libavcodec/rv10.c           |  2 +-
> >  10 files changed, 19 insertions(+), 19 deletions(-)
> 
> 
> I think this is a good idea, thanks.

applied

thx

[...]

Patch hide | download patch | download mbox

diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index 39be8cf717..b697afa0ae 100644
--- a/libavcodec/avcodec.h
+++ b/libavcodec/avcodec.h
@@ -3948,7 +3948,7 @@  typedef struct AVHWAccel {
     /**
      * Called for every Macroblock in a slice.
      *
-     * XvMC uses it to replace the ff_mpv_decode_mb().
+     * XvMC uses it to replace the ff_mpv_reconstruct_mb().
      * Instead of decoding to raw picture, MB parameters are
      * stored in an array provided by the video driver.
      *
diff --git a/libavcodec/h261dec.c b/libavcodec/h261dec.c
index 7f2fff8684..14a874c45d 100644
--- a/libavcodec/h261dec.c
+++ b/libavcodec/h261dec.c
@@ -223,7 +223,7 @@  static int h261_decode_mb_skipped(H261Context *h, int mba1, int mba2)
             s->current_picture.motion_val[0][b_xy][1] = s->mv[0][0][1];
         }
 
-        ff_mpv_decode_mb(s, s->block);
+        ff_mpv_reconstruct_mb(s, s->block);
     }
 
     return 0;
@@ -466,7 +466,7 @@  intra:
             s->block_last_index[i] = -1;
     }
 
-    ff_mpv_decode_mb(s, s->block);
+    ff_mpv_reconstruct_mb(s, s->block);
 
     return SLICE_OK;
 }
diff --git a/libavcodec/h263dec.c b/libavcodec/h263dec.c
index 077666470d..bcb2b08bb0 100644
--- a/libavcodec/h263dec.c
+++ b/libavcodec/h263dec.c
@@ -261,7 +261,7 @@  static int decode_slice(MpegEncContext *s)
             if (ret < 0) {
                 const int xy = s->mb_x + s->mb_y * s->mb_stride;
                 if (ret == SLICE_END) {
-                    ff_mpv_decode_mb(s, s->block);
+                    ff_mpv_reconstruct_mb(s, s->block);
                     if (s->loop_filter)
                         ff_h263_loop_filter(s);
 
@@ -294,7 +294,7 @@  static int decode_slice(MpegEncContext *s)
                 return AVERROR_INVALIDDATA;
             }
 
-            ff_mpv_decode_mb(s, s->block);
+            ff_mpv_reconstruct_mb(s, s->block);
             if (s->loop_filter)
                 ff_h263_loop_filter(s);
         }
diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c
index 186fbd27b6..58a5a20864 100644
--- a/libavcodec/mpeg12dec.c
+++ b/libavcodec/mpeg12dec.c
@@ -1867,7 +1867,7 @@  static int mpeg_decode_slice(MpegEncContext *s, int mb_y,
         s->dest[1] +=(16 >> lowres) >> s->chroma_x_shift;
         s->dest[2] +=(16 >> lowres) >> s->chroma_x_shift;
 
-        ff_mpv_decode_mb(s, s->block);
+        ff_mpv_reconstruct_mb(s, s->block);
 
         if (++s->mb_x >= s->mb_width) {
             const int mb_size = 16 >> s->avctx->lowres;
diff --git a/libavcodec/mpeg_er.c b/libavcodec/mpeg_er.c
index ee8b2a5e7b..5eca834072 100644
--- a/libavcodec/mpeg_er.c
+++ b/libavcodec/mpeg_er.c
@@ -91,7 +91,7 @@  static void mpeg_er_decode_mb(void *opaque, int ref, int mv_dir, int mv_type,
     if (ref)
         av_log(s->avctx, AV_LOG_DEBUG,
                "Interlaced error concealment is not fully implemented\n");
-    ff_mpv_decode_mb(s, s->block);
+    ff_mpv_reconstruct_mb(s, s->block);
 }
 
 int ff_mpeg_er_init(MpegEncContext *s)
diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
index e5424cbacf..63a30b93ce 100644
--- a/libavcodec/mpegvideo.c
+++ b/libavcodec/mpegvideo.c
@@ -2471,7 +2471,7 @@  void ff_clean_intra_table_entries(MpegEncContext *s)
    s->interlaced_dct : true if interlaced dct used (mpeg2)
  */
 static av_always_inline
-void mpv_decode_mb_internal(MpegEncContext *s, int16_t block[12][64],
+void mpv_reconstruct_mb_internal(MpegEncContext *s, int16_t block[12][64],
                             int lowres_flag, int is_mpeg12)
 {
     const int mb_xy = s->mb_y * s->mb_stride + s->mb_x;
@@ -2719,16 +2719,16 @@  skip_idct:
     }
 }
 
-void ff_mpv_decode_mb(MpegEncContext *s, int16_t block[12][64])
+void ff_mpv_reconstruct_mb(MpegEncContext *s, int16_t block[12][64])
 {
 #if !CONFIG_SMALL
     if(s->out_format == FMT_MPEG1) {
-        if(s->avctx->lowres) mpv_decode_mb_internal(s, block, 1, 1);
-        else                 mpv_decode_mb_internal(s, block, 0, 1);
+        if(s->avctx->lowres) mpv_reconstruct_mb_internal(s, block, 1, 1);
+        else                 mpv_reconstruct_mb_internal(s, block, 0, 1);
     } else
 #endif
-    if(s->avctx->lowres) mpv_decode_mb_internal(s, block, 1, 0);
-    else                  mpv_decode_mb_internal(s, block, 0, 0);
+    if(s->avctx->lowres) mpv_reconstruct_mb_internal(s, block, 1, 0);
+    else                  mpv_reconstruct_mb_internal(s, block, 0, 0);
 }
 
 void ff_mpeg_draw_horiz_band(MpegEncContext *s, int y, int h)
diff --git a/libavcodec/mpegvideo.h b/libavcodec/mpegvideo.h
index 85df19154f..e9eb633d1b 100644
--- a/libavcodec/mpegvideo.h
+++ b/libavcodec/mpegvideo.h
@@ -680,7 +680,7 @@  void ff_mpv_common_end(MpegEncContext *s);
 
 void ff_mpv_decode_defaults(MpegEncContext *s);
 void ff_mpv_decode_init(MpegEncContext *s, AVCodecContext *avctx);
-void ff_mpv_decode_mb(MpegEncContext *s, int16_t block[12][64]);
+void ff_mpv_reconstruct_mb(MpegEncContext *s, int16_t block[12][64]);
 void ff_mpv_report_decode_progress(MpegEncContext *s);
 
 int ff_mpv_frame_start(MpegEncContext *s, AVCodecContext *avctx);
diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c
index 1003dea5b7..fffb113096 100644
--- a/libavcodec/mpegvideo_enc.c
+++ b/libavcodec/mpegvideo_enc.c
@@ -2774,7 +2774,7 @@  static inline void encode_mb_hq(MpegEncContext *s, MpegEncContext *backup, MpegE
     }
 
     if(s->avctx->mb_decision == FF_MB_DECISION_RD){
-        ff_mpv_decode_mb(s, s->block);
+        ff_mpv_reconstruct_mb(s, s->block);
 
         score *= s->lambda2;
         score += sse_mb(s) << FF_LAMBDA_SHIFT;
@@ -3479,7 +3479,7 @@  FF_ENABLE_DEPRECATION_WARNINGS
                 }
 
                 if(s->avctx->mb_decision == FF_MB_DECISION_BITS)
-                    ff_mpv_decode_mb(s, s->block);
+                    ff_mpv_reconstruct_mb(s, s->block);
             } else {
                 int motion_x = 0, motion_y = 0;
                 s->mv_type=MV_TYPE_16X16;
@@ -3598,7 +3598,7 @@  FF_ENABLE_DEPRECATION_WARNINGS
                     s->out_format == FMT_H263 && s->pict_type!=AV_PICTURE_TYPE_B)
                     ff_h263_update_motion_val(s);
 
-                ff_mpv_decode_mb(s, s->block);
+                ff_mpv_reconstruct_mb(s, s->block);
             }
 
             /* clean the MV table in IPS frames for direct mode in B-frames */
diff --git a/libavcodec/mpegvideo_xvmc.c b/libavcodec/mpegvideo_xvmc.c
index b469c4e26f..519a448161 100644
--- a/libavcodec/mpegvideo_xvmc.c
+++ b/libavcodec/mpegvideo_xvmc.c
@@ -182,7 +182,7 @@  static void ff_xvmc_decode_mb(struct MpegEncContext *s)
         return;
     }
 
-    // from ff_mpv_decode_mb(), update DC predictors for P macroblocks
+    // from ff_mpv_reconstruct_mb(), update DC predictors for P macroblocks
     if (!s->mb_intra) {
         s->last_dc[0] =
         s->last_dc[1] =
diff --git a/libavcodec/rv10.c b/libavcodec/rv10.c
index 81aa9ae587..595e217519 100644
--- a/libavcodec/rv10.c
+++ b/libavcodec/rv10.c
@@ -670,7 +670,7 @@  static int rv10_decode_packet(AVCodecContext *avctx, const uint8_t *buf,
         }
         if (s->pict_type != AV_PICTURE_TYPE_B)
             ff_h263_update_motion_val(s);
-        ff_mpv_decode_mb(s, s->block);
+        ff_mpv_reconstruct_mb(s, s->block);
         if (s->loop_filter)
             ff_h263_loop_filter(s);