| Message ID | 20160905175839.19118-2-michael@niedermayer.cc |
|---|---|
| State | Accepted |
| Headers | show |
On 9/5/2016 2:58 PM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > tests/fate/ffmpeg.mak | 5 +++++ > tests/ref/fate/copy-236 | 2 ++ > 2 files changed, 7 insertions(+) > create mode 100644 tests/ref/fate/copy-236 > > diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak > index 3b91c12..e896d05 100644 > --- a/tests/fate/ffmpeg.mak > +++ b/tests/fate/ffmpeg.mak > @@ -51,6 +51,11 @@ fate-unknown_layout-ac3: CMD = md5 \ > -guess_layout_max 0 -f s16le -ac 1 -ar 44100 -i $(TARGET_PATH)/$(AREF) \ > -f ac3 -flags +bitexact -c ac3_fixed > > +FATE_SAMPLES_FFMPEG-$(call ALLYES, MOV_DEMUXER MOV_MUXER) += fate-copy-236 > +fate-copy-236: $(TARGET_SAMPLES)/mov/fcp_export8-236.mov trac236? Otherwise the name gives no hints about what it's testing. We already named some tests like this. See vpx.mak This also applies for Patch 3/4. > +fate-copy-236: CMD = transcode mov $(TARGET_SAMPLES)/mov/fcp_export8-236.mov\ > + mov "-codec copy -map 0" > + > FATE_SAMPLES_FFMPEG-$(call DEMMUX, OGG, OGG) += fate-limited_input_seek fate-limited_input_seek-copyts > fate-limited_input_seek: $(TARGET_SAMPLES)/vorbis/moog_small.ogg > fate-limited_input_seek: CMD = md5 -ss 1.5 -t 1.3 -i $(TARGET_SAMPLES)/vorbis/moog_small.ogg -c:a copy -fflags +bitexact -f ogg > diff --git a/tests/ref/fate/copy-236 b/tests/ref/fate/copy-236 > new file mode 100644 > index 0000000..58a5537 > --- /dev/null > +++ b/tests/ref/fate/copy-236 > @@ -0,0 +1,2 @@ > +9b95afdb39b426a33bc962889f820aed *tests/data/fate/copy-236.mov > +630802 tests/data/fate/copy-236.mov >
On Mon, Sep 05, 2016 at 03:20:27PM -0300, James Almer wrote: > On 9/5/2016 2:58 PM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > > --- > > tests/fate/ffmpeg.mak | 5 +++++ > > tests/ref/fate/copy-236 | 2 ++ > > 2 files changed, 7 insertions(+) > > create mode 100644 tests/ref/fate/copy-236 > > > > diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak > > index 3b91c12..e896d05 100644 > > --- a/tests/fate/ffmpeg.mak > > +++ b/tests/fate/ffmpeg.mak > > @@ -51,6 +51,11 @@ fate-unknown_layout-ac3: CMD = md5 \ > > -guess_layout_max 0 -f s16le -ac 1 -ar 44100 -i $(TARGET_PATH)/$(AREF) \ > > -f ac3 -flags +bitexact -c ac3_fixed > > > > +FATE_SAMPLES_FFMPEG-$(call ALLYES, MOV_DEMUXER MOV_MUXER) += fate-copy-236 > > +fate-copy-236: $(TARGET_SAMPLES)/mov/fcp_export8-236.mov > > trac236? Otherwise the name gives no hints about what it's testing. > We already named some tests like this. See vpx.mak > > This also applies for Patch 3/4. fixed and applied thx [...]
diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak index 3b91c12..e896d05 100644 --- a/tests/fate/ffmpeg.mak +++ b/tests/fate/ffmpeg.mak @@ -51,6 +51,11 @@ fate-unknown_layout-ac3: CMD = md5 \ -guess_layout_max 0 -f s16le -ac 1 -ar 44100 -i $(TARGET_PATH)/$(AREF) \ -f ac3 -flags +bitexact -c ac3_fixed +FATE_SAMPLES_FFMPEG-$(call ALLYES, MOV_DEMUXER MOV_MUXER) += fate-copy-236 +fate-copy-236: $(TARGET_SAMPLES)/mov/fcp_export8-236.mov +fate-copy-236: CMD = transcode mov $(TARGET_SAMPLES)/mov/fcp_export8-236.mov\ + mov "-codec copy -map 0" + FATE_SAMPLES_FFMPEG-$(call DEMMUX, OGG, OGG) += fate-limited_input_seek fate-limited_input_seek-copyts fate-limited_input_seek: $(TARGET_SAMPLES)/vorbis/moog_small.ogg fate-limited_input_seek: CMD = md5 -ss 1.5 -t 1.3 -i $(TARGET_SAMPLES)/vorbis/moog_small.ogg -c:a copy -fflags +bitexact -f ogg diff --git a/tests/ref/fate/copy-236 b/tests/ref/fate/copy-236 new file mode 100644 index 0000000..58a5537 --- /dev/null +++ b/tests/ref/fate/copy-236 @@ -0,0 +1,2 @@ +9b95afdb39b426a33bc962889f820aed *tests/data/fate/copy-236.mov +630802 tests/data/fate/copy-236.mov
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- tests/fate/ffmpeg.mak | 5 +++++ tests/ref/fate/copy-236 | 2 ++ 2 files changed, 7 insertions(+) create mode 100644 tests/ref/fate/copy-236