diff mbox

[FFmpeg-devel] coverage: filter /usr/include*, not entire /usr*

Message ID 20170731202758.17569-1-foobaz86@gmail.com
State New
Headers show

Commit Message

foo86 July 31, 2017, 8:27 p.m. UTC 
/usr* filters all sources when building in /usr/src, which is probably
not intended.
---
 tests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Nicolas George July 31, 2017, 9:06 p.m. UTC | #1 
Le tridi 13 thermidor, an CCXXV, foo86 a écrit :
> /usr* filters all sources when building in /usr/src, which is probably
> not intended.

This is leaving /usr/local/include, and many less known directories,
like compiler-specific includes.

Regards,
foo86 Aug. 1, 2017, 12:09 a.m. UTC | #2 
On Mon, Jul 31, 2017 at 11:06:01PM +0200, Nicolas George wrote:
> Le tridi 13 thermidor, an CCXXV, foo86 a écrit :
> > /usr* filters all sources when building in /usr/src, which is probably
> > not intended.
> 
> This is leaving /usr/local/include, and many less known directories,
> like compiler-specific includes.

I see. Consider this patch withdrawn then.

> 
> Regards,
> 
> -- 
>   Nicolas George
diff mbox

Patch

diff --git a/tests/Makefile b/tests/Makefile
index ab83ae855d..2c67095052 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -228,7 +228,7 @@  coverage.info: TAG = LCOV
 coverage.info:
 	$(M)lcov -q -d $(CURDIR) -b $(patsubst src%,./,$(SRC_LINK)) --capture | \
 	    sed "s,$(CURDIR)/\./,$(CURDIR)/," > $@.in
-	$(M)lcov -q --remove $@.in "/usr*" > $@
+	$(M)lcov -q --remove $@.in "/usr/include*" > $@
 	$(Q)$(RM) $@.in
 
 lcov:  TAG = GENHTML