From patchwork Wed Aug 16 16:19:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 4723 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.46.211 with SMTP id u202csp940078vsu; Wed, 16 Aug 2017 09:21:15 -0700 (PDT) X-Received: by 10.223.180.69 with SMTP id v5mr1707587wrd.199.1502900475817; Wed, 16 Aug 2017 09:21:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502900475; cv=none; d=google.com; s=arc-20160816; b=wIEiEARyhjy3ozmB9KSmvdiZ2eH4k/Z++x5VYZsX+OyQh5Lv6gCFWle2Nee6wZNu5/ zjFyaDAfpbBPuvkkKMa/Yzt+QegGs9sgpkUxiko0C447MMpqUk3lFgxL9k8nuHsdXJwr SbWIgy8ePgpd0cZpVzLC03FCc0/1eCzI3ioPyZ/+JUOlEXRk2bo5eFtMecRtHlFW32X+ 0cs9C9+8nucD0iodDlMqQgK+YPF+2W+65/illZob4IYGwGavz7u7xGeJEllygoEudH37 k3b8BRUfamMkJCEcJhXYvi/F/Ctt/VmJiv7PE7ZNRR+Pgd0vyRaMLgvsXxsLOD73Xv0j lDHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :in-reply-to:mime-version:references:message-id:to:from:date :delivered-to:arc-authentication-results; bh=pi9dpaFPU5x6HkRyFWsPsEAM6chC9/FOjValQGypUEQ=; b=oMuh7G3ei3fy8Zsw0ZPEvGn8LYj4R2OjhA0Nl8wkwEWctKQNKRuA8BVdHEpzG/mLHZ Gatw7/9APXtfI3BLiOl1si7E54FAAuMZxN3wTXVDn9xAgyvrUT+X7MuyiyNSXdITklSP /KxCGsYfEhzXVPpf4YDqpJ/FiHqW2DR+J8Luaqp41OxObUy5XzRxZbGpAaJ+ioQHi1Fh 1YLhwB2mCHLxhVvwnTC1PVrd639mYZ/V0oWOQz9d3MDLnkIYSvIaEc9PhNGay3RJ/Qm+ eczpYp5uzCEVh9meoqCUpBgI3njMfFAaKZ5exTsYG3Qq09frPnC1yNSEQncY+x10oR0o JdYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id q138si1101283wmg.213.2017.08.16.09.21.14; Wed, 16 Aug 2017 09:21:15 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BC4AF681872; Wed, 16 Aug 2017 19:21:06 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 454396805C0 for ; Wed, 16 Aug 2017 19:21:00 +0300 (EEST) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id D4C26A80C1 for ; Wed, 16 Aug 2017 18:21:04 +0200 (CEST) Date: Wed, 16 Aug 2017 18:19:48 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20170816161948.GI7094@nb4> References: <20170813200004.27388-1-cus@passwd.hu> <20170815222218.GD7094@nb4> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [FFmpeg-devel] [PATCH] fate: add overlay filter tests with alpha X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Wed, Aug 16, 2017 at 01:03:46AM +0200, Marton Balint wrote: > > On Wed, 16 Aug 2017, Michael Niedermayer wrote: > > >On Sun, Aug 13, 2017 at 10:00:04PM +0200, Marton Balint wrote: > >>Signed-off-by: Marton Balint > >>--- > >> tests/fate/filter-video.mak | 19 +++++++++++++++++++ > >> tests/ref/fate/filter-overlay_gbrap_gbrap | 6 ++++++ > >> tests/ref/fate/filter-overlay_gbrp_gbrap | 6 ++++++ > >> tests/ref/fate/filter-overlay_rgb_rgba | 6 ++++++ > >> tests/ref/fate/filter-overlay_rgba_rgba | 6 ++++++ > >> tests/ref/fate/filter-overlay_yuv420_yuva420 | 6 ++++++ > >> tests/ref/fate/filter-overlay_yuv422_yuva422 | 6 ++++++ > >> tests/ref/fate/filter-overlay_yuv444_yuva444 | 6 ++++++ > >> tests/ref/fate/filter-overlay_yuva420_yuva420 | 6 ++++++ > >> tests/ref/fate/filter-overlay_yuva422_yuva422 | 6 ++++++ > >> tests/ref/fate/filter-overlay_yuva444_yuva444 | 6 ++++++ > >> 11 files changed, 79 insertions(+) > >> create mode 100644 tests/ref/fate/filter-overlay_gbrap_gbrap > >> create mode 100644 tests/ref/fate/filter-overlay_gbrp_gbrap > >> create mode 100644 tests/ref/fate/filter-overlay_rgb_rgba > >> create mode 100644 tests/ref/fate/filter-overlay_rgba_rgba > >> create mode 100644 tests/ref/fate/filter-overlay_yuv420_yuva420 > >> create mode 100644 tests/ref/fate/filter-overlay_yuv422_yuva422 > >> create mode 100644 tests/ref/fate/filter-overlay_yuv444_yuva444 > >> create mode 100644 tests/ref/fate/filter-overlay_yuva420_yuva420 > >> create mode 100644 tests/ref/fate/filter-overlay_yuva422_yuva422 > >> create mode 100644 tests/ref/fate/filter-overlay_yuva444_yuva444 > > > >fails on arm & mips qemu > > If you add -sws_flags +accurate_rnd+bitexact to the framecrc command > does that help? yes, the following works: [...] diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak index 37d3e25b1d..0d953f25f2 100644 --- a/tests/fate/filter-video.mak +++ b/tests/fate/filter-video.mak @@ -207,7 +207,7 @@ fate-filter-overlay_yuv444: CMD = framecrc -c:v pgmyuv -i $(SRC) -filter_complex FATE_FILTER_OVERLAY_ALPHA += fate-filter-overlay_yuv420_yuva420 fate-filter-overlay_yuv422_yuva422 fate-filter-overlay_yuv444_yuva444 fate-filter-overlay_rgb_rgba fate-filter-overlay_gbrp_gbrap FATE_FILTER_OVERLAY_ALPHA += fate-filter-overlay_yuva420_yuva420 fate-filter-overlay_yuva422_yuva422 fate-filter-overlay_yuva444_yuva444 fate-filter-overlay_rgba_rgba fate-filter-overlay_gbrap_gbrap $(FATE_FILTER_OVERLAY_ALPHA): SRC = $(TARGET_SAMPLES)/png1/lena-rgba.png -$(FATE_FILTER_OVERLAY_ALPHA): CMD = framecrc -i $(SRC) -vf $(FILTER) -frames:v 1 +$(FATE_FILTER_OVERLAY_ALPHA): CMD = framecrc -i $(SRC) -sws_flags +accurate_rnd+bitexact -vf $(FILTER) -frames:v 1 fate-filter-overlay_yuv420_yuva420: FILTER = "format=yuva420p[over];color=black:128x128,format=yuv420p[main];[main][over]overlay=format=yuv420" fate-filter-overlay_yuv422_yuva422: FILTER = "format=yuva422p[over];color=black:128x128,format=yuv422p[main];[main][over]overlay=format=yuv422" diff --git a/tests/ref/fate/filter-overlay_yuv420_yuva420 b/tests/ref/fate/filter-overlay_yuv420_yuva420 index caa3442de2..ee0c82e062 100644 --- a/tests/ref/fate/filter-overlay_yuv420_yuva420 +++ b/tests/ref/fate/filter-overlay_yuv420_yuva420 @@ -3,4 +3,4 @@ #codec_id 0: rawvideo #dimensions 0: 128x128 #sar 0: 1/1 -0, 0, 0, 1, 24576, 0xedb7ef1c +0, 0, 0, 1, 24576, 0x1505f000 diff --git a/tests/ref/fate/filter-overlay_yuva420_yuva420 b/tests/ref/fate/filter-overlay_yuva420_yuva420 index ef39176b6f..a17cc5c2e5 100644 --- a/tests/ref/fate/filter-overlay_yuva420_yuva420 +++ b/tests/ref/fate/filter-overlay_yuva420_yuva420 @@ -3,4 +3,4 @@ #codec_id 0: rawvideo #dimensions 0: 128x128 #sar 0: 1/1 -0, 0, 0, 1, 40960, 0xdf75b2dc +0, 0, 0, 1, 40960, 0x0a1ab3c0