From patchwork Wed Aug 16 17:47:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ronald S. Bultje" X-Patchwork-Id: 4724 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.46.211 with SMTP id u202csp1029234vsu; Wed, 16 Aug 2017 10:54:32 -0700 (PDT) X-Received: by 10.28.101.5 with SMTP id z5mr1949931wmb.136.1502906072911; Wed, 16 Aug 2017 10:54:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502906072; cv=none; d=google.com; s=arc-20160816; b=BjsyGYZ6N6u3NiLPRXAvWnaZq2iwoCkGpUQ+vcsZ0eWKKlrbUBeGU3NBJpyhBcdEsd d75Vz4qn7BloJ8+cweoVmpJsk3ZCzFr/QT4puN2v77O0TzfhApCrAy+cJxR7Gw8vS1ka CYtocT24o+VNZeWpOisFGmWmGSOML41Egv6gl9X3/x1/ghiLHhUm+Bzj8LJzVM+BXEKc z++eTw8GNlOo0lq/+3mWgXNDjCiwrbXHtW14dk65gmky/GfKfM3q1FRKyK6XoUBMjxST Qk9XekxU7HHVdvK+SFlGYyd3qrwHaiFJySrlDjeQqX2n0wXT/GFaFnGhT8CxpqQNViXC iAhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:to:message-id:date:from:references:in-reply-to :mime-version:dkim-signature:delivered-to:arc-authentication-results; bh=Gc6swv90VCCvGwQhlToYJHzxOsr8oJP96RAo4t4rBQk=; b=srCO2RYguCbuC3JZzc0hBgj8V/qAoCVJzHOQPEDuN5u65x9VGJdWBCnkpd1PgsBiL1 g/ANMiA+2f8kCVn1qIvB9pZFZMX011kOX3cpG5CpAeC8wYCanB9uVvEgeeMo0pGAB8gi zaLd1O6Yui1CB8QOePKw1QdceTYUM8kBXnTCW1IjuXqD6fe2np8bqLR0DtzXx0cZoZUa 16N8IW64g5OpxunxZV+IsH+lgpuWP5sXAhLVvw2Twap47FnHystYx6SMGKYy1IMHlRJ3 REHLckH4Fz9fwZcbAdz3Qw3uTIksYHy6mqLnwv6ACltkIXK3yGh5lYrSf9rGX6xznNTm e9FQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=agI9hB+B; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id n12si1053847wrg.197.2017.08.16.10.54.31; Wed, 16 Aug 2017 10:54:32 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=agI9hB+B; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 82FFE6882B9; Wed, 16 Aug 2017 20:54:23 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qt0-f175.google.com (mail-qt0-f175.google.com [209.85.216.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 65CAB68041E for ; Wed, 16 Aug 2017 20:54:16 +0300 (EEST) Received: by mail-qt0-f175.google.com with SMTP id v29so25112952qtv.3 for ; Wed, 16 Aug 2017 10:54:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=/zVE2aZBRDJYVdfnWSZpv9Bs+cNgCNyJfRqDvvYNSXs=; b=agI9hB+B0dQtgcHH3dteat9m4TpBaNj5HvTc1ftQ2v+2fIjQzrR1vezYViGDKXzn9r w16O0RSTzdm0GGAdiVK4Qih/y/YaadKYk0vt9qTY7aaBHjjH7V5wt9VG6M/AL8Rf6j9o wcTnf6QEobeN31JB9yRh3AZukEIY2OhKdl9f2xAMjeJroxK9DFh7BHTWibX44Kv3uMv3 z2a026ku7mkoSNVm7o/FywbIL747nApSGgUckjuE3P/hPH8wCIAzDmWEGhihPKrXrTpK jjYOhTbrIB1VQnGR6pviTz9gjEYZNSiiaPFqT5UzTl/uI1oE8FgdmQ+TQ9YgtMB0G2ix TMGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=/zVE2aZBRDJYVdfnWSZpv9Bs+cNgCNyJfRqDvvYNSXs=; b=l0plIWWxTD5SK+sVk2dQXaHLS9uDRveE+ld4bF4PkONDRZzYpCd3S5av0aEDVvQIBY UZkvbvb0u6hZkHJHl1tBLVv1S/F0WPYwY1INNW1oBXlOz72M0EoyeRPr7PF8/FoJ+m3I KMnZoSiiVprzarJ5zp69M4ieFMOO7yR73XQoLJoW1p0FXVD2NF5Ea6t8OIMvdNFQcq1s tFd3G1iKFMfS1qVbLOH/XLbAfmtnAsIrQLj7fQ0eggfUcuaJHk1YcD5BDKhEUWfdab4E 2uWS0QND1BAPXj87db+evQtdRorb4K5rBEhnFB1pTrPIZYKt28d9bcryUPEVToB253F/ 9aww== X-Gm-Message-State: AHYfb5hxtCgYwVokUBHEkNBOvbzP08tvMJ03aCmxEx7gJz0LyewCRCkE VAprs2cWESu3BAqbF/vaZierMR9Sg/7/ X-Received: by 10.237.34.185 with SMTP id p54mr3508930qtc.250.1502905677142; Wed, 16 Aug 2017 10:47:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.87.7 with HTTP; Wed, 16 Aug 2017 10:47:55 -0700 (PDT) Received: by 10.140.87.7 with HTTP; Wed, 16 Aug 2017 10:47:55 -0700 (PDT) In-Reply-To: <20170815013244.21614-1-michael@niedermayer.cc> References: <20170815013244.21614-1-michael@niedermayer.cc> From: "Ronald S. Bultje" Date: Wed, 16 Aug 2017 13:47:55 -0400 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.20 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/diracdec: Check perspective_exp and zrs_exp. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi, On Aug 15, 2017 3:32 AM, "Michael Niedermayer" wrote: Fixes: undefined shift Fixes: runtime error: shift exponent 264 is too large for 32-bit type 'int' Fixes: 2860/clusterfuzz-testcase-minimized-4672811689836544 Found-by: continuous fuzzing process https://github.com/google/oss- fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/diracdec.c | 5 +++++ 1 file changed, 5 insertions(+) This message is utterly unhelpful. Why is it there? Please don't waste binary size with crap logs. Ronald diff --git a/libavcodec/diracdec.c b/libavcodec/diracdec.c index f2837aca69..be8b282314 100644 --- a/libavcodec/diracdec.c +++ b/libavcodec/diracdec.c @@ -1161,6 +1161,11 @@ static int dirac_unpack_prediction_parameters(DiracContext *s) s->globalmc[ref].perspective[0] = dirac_get_se_golomb(gb); s->globalmc[ref].perspective[1] = dirac_get_se_golomb(gb); } + if (s->globalmc[ref].perspective_exp + (uint64_t)s->globalmc[ref].zrs_exp > 30) { + av_log(s->avctx, AV_LOG_ERROR, "exp %d %d too large\n", s->globalmc[ref].perspective_exp, s->globalmc[ref].zrs_exp);