diff mbox

[FFmpeg-devel] Videotoolbox encoder: Enable Videotoolbox encoder

Message ID CAGPT-GJwdkXYW5K2t6kyp-mrMB79TchGdJcfyQgcJ3DW2d09yw@mail.gmail.com
State New
Headers show

Commit Message

pon pon Oct. 4, 2017, 10:45 a.m. UTC 
Thank you for pointing out.

>i t doesn't belong in this list.
Doesn't this mean videotoolbox_encoder belongs to
EXTERNAL_AUTODETECT_LIBRARY_LIST,
also?
If so, I think the integrated
<https://eow.alc.co.jp/search?q=integrated&ref=awlj> modifications of
videotoolbox"enc".c and videotoolbox.c are need.
This is because videotoolboxenc.c doesn't include videotoolbox.h.
independent each other?

Your idea is correct. Videotoolbox has decoder , encoder, videofilters.
Moreover, its work  switches between soft- and hard-ware. But, My
understanding of hw accelation policy of ffmpeg isn't enough and this is
beyond my ability. For example, ./configure
--disable-decoder=h264_videotoolbox and ffmpeg -c:v h264_videotoolbox  -i
input output don't work. On the other hand, qsv isn't so.

As a temporal handling to autodetect, the previous patch or
can be used. ffmpeg -i input -c:v h264_videotoolbox output, ./configure
--disable-encoder=h264_videotoolbox, and ./configure --disable-videotoolbox
well work in my tests.

Of course, this depends on the policy of ffmpeg. I like ffmpeg.

Thank you.
ponpon
<https://eow.alc.co.jp/search?q=handling&ref=awlj>

2017-10-04 15:42 GMT+09:00 Clément Bœsch <u@pkh.me>:

> On Wed, Oct 04, 2017 at 09:55:04AM +0900, pon pon wrote:
> > I reported that Videotoolbox encoder isn't enabled since commit
> > 9ef5a2f5f30bdc4ac86275ae4b4708ab4681b21
> > <http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=
> 9ef5a2f5f30bdc4ac86275ae4b4708ab4681b21d>
> > in ticket 6702.
> > This is a simple patch correcting it.
> >
> > diff --git a/configure b/configure
> > index ae0eddac6c..8922303c89 100755
> > --- a/configure
> > +++ b/configure
> > @@ -1652,6 +1652,7 @@ HWACCEL_AUTODETECT_LIBRARY_LIST="
> >      vda
> >      vdpau
> >      videotoolbox
> > +    videotoolbox_encoder
> >      v4l2_m2m
> >      xvmc
> >  "
> >
>
> "videotoolbox_encoder" is not an autodetected library, it's a component
> depending on videotoolbox, so i t doesn't belong in this list.
>
> Please see http://ffmpeg.org/pipermail/ffmpeg-devel/2017-September/
> 217075.html
>
> If you can test it I'll apply it.
>
> --
> Clément B.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>

Comments

Clément Bœsch Oct. 4, 2017, 11:01 a.m. UTC | #1 
On Wed, Oct 04, 2017 at 07:45:50PM +0900, pon pon wrote:
> Thank you for pointing out.
> 
> >i t doesn't belong in this list.
> Doesn't this mean videotoolbox_encoder belongs to
> EXTERNAL_AUTODETECT_LIBRARY_LIST,
> also?

My point was that it doesn't belong in these lists. I applied my patch
(8be3fc88d), please test if that works for you.

[...]

Regards,
pon pon Oct. 5, 2017, 12:31 a.m. UTC | #2 
Sorry for my misunderstanding.

I tests your patch.
./configure
ffmpeg -i input -c:v h264_videotoolbox output
./configure --disable-encoder=h264_videotoolbox
./configure --disable-videotoolbox
All work! Good!

ponpon

2017-10-04 20:01 GMT+09:00 Clément Bœsch <u@pkh.me>:

> On Wed, Oct 04, 2017 at 07:45:50PM +0900, pon pon wrote:
> > Thank you for pointing out.
> >
> > >i t doesn't belong in this list.
> > Doesn't this mean videotoolbox_encoder belongs to
> > EXTERNAL_AUTODETECT_LIBRARY_LIST,
> > also?
>
> My point was that it doesn't belong in these lists. I applied my patch
> (8be3fc88d), please test if that works for you.
>
> [...]
>
> Regards,
>
> --
> Clément B.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>
diff mbox

Patch

diff --git a/configure b/configure
index 0d86c4cb2a..d3886b6d41 100755
--- a/configure
+++ b/configure
@@ -1542,6 +1542,7 @@  EXTERNAL_AUTODETECT_LIBRARY_LIST="
     sdl2
     securetransport
     sndio
+    videotoolbox_encoder
     xlib
     zlib
 "