| Message ID | 20171010003417.8296-1-jamrial@gmail.com |
|---|---|
| State | New |
| Headers | show |
On Mon, Oct 09, 2017 at 09:34:17PM -0300, James Almer wrote: > The PERSIST_RPARAM_A_RExt_Sony_1 bitstream has an out-of-range value > and has therefore been superseded. > It is otherwise identical, and decodes the same. > > Signed-off-by: James Almer <jamrial@gmail.com> > --- > tests/fate/hevc.mak | 3 +-- > ...RAM_A_RExt_Sony_1 => hevc-conformance-PERSIST_RPARAM_A_RExt_Sony_3} | 0 > 2 files changed, 1 insertion(+), 2 deletions(-) > rename tests/ref/fate/{hevc-conformance-PERSIST_RPARAM_A_RExt_Sony_1 => hevc-conformance-PERSIST_RPARAM_A_RExt_Sony_3} (100%) > > diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak > index 2e798eca60..423b0630c7 100644 > --- a/tests/fate/hevc.mak > +++ b/tests/fate/hevc.mak > @@ -167,7 +167,7 @@ HEVC_SAMPLES_444_8BIT = \ > > HEVC_SAMPLES_444_12BIT = \ > IPCM_B_RExt_NEC \ > - PERSIST_RPARAM_A_RExt_Sony_1\ > + PERSIST_RPARAM_A_RExt_Sony_3\ > SAO_A_RExt_MediaTek_1 \ I think we should add but not replace tests what created a file with a out of range value can have created more or could have been used as reference. [...]
On 10/10/2017 7:32 AM, Michael Niedermayer wrote: > On Mon, Oct 09, 2017 at 09:34:17PM -0300, James Almer wrote: >> The PERSIST_RPARAM_A_RExt_Sony_1 bitstream has an out-of-range value >> and has therefore been superseded. >> It is otherwise identical, and decodes the same. >> >> Signed-off-by: James Almer <jamrial@gmail.com> >> --- >> tests/fate/hevc.mak | 3 +-- >> ...RAM_A_RExt_Sony_1 => hevc-conformance-PERSIST_RPARAM_A_RExt_Sony_3} | 0 >> 2 files changed, 1 insertion(+), 2 deletions(-) >> rename tests/ref/fate/{hevc-conformance-PERSIST_RPARAM_A_RExt_Sony_1 => hevc-conformance-PERSIST_RPARAM_A_RExt_Sony_3} (100%) >> >> diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak >> index 2e798eca60..423b0630c7 100644 >> --- a/tests/fate/hevc.mak >> +++ b/tests/fate/hevc.mak >> @@ -167,7 +167,7 @@ HEVC_SAMPLES_444_8BIT = \ >> >> HEVC_SAMPLES_444_12BIT = \ >> IPCM_B_RExt_NEC \ >> - PERSIST_RPARAM_A_RExt_Sony_1\ >> + PERSIST_RPARAM_A_RExt_Sony_3\ >> SAO_A_RExt_MediaTek_1 \ > > I think we should add but not replace tests > > what created a file with a out of range value can have created more > or could have been used as reference. Alright, added the new test without replacing the old one. Still, though, it will have to be removed if we port the hevc decoder to the cbs API, where range checks are strict.
diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak index 2e798eca60..423b0630c7 100644 --- a/tests/fate/hevc.mak +++ b/tests/fate/hevc.mak @@ -167,7 +167,7 @@ HEVC_SAMPLES_444_8BIT = \ HEVC_SAMPLES_444_12BIT = \ IPCM_B_RExt_NEC \ - PERSIST_RPARAM_A_RExt_Sony_1\ + PERSIST_RPARAM_A_RExt_Sony_3\ SAO_A_RExt_MediaTek_1 \ @@ -182,7 +182,6 @@ HEVC_SAMPLES_444_12BIT = \ # do not pass: # TSUNEQBD_A_MAIN10_Technicolor_2.bit (segfault mix 9-10bits) -# PERSIST_RPARAM_A_RExt_Sony_1 (rext) define FATE_HEVC_TEST diff --git a/tests/ref/fate/hevc-conformance-PERSIST_RPARAM_A_RExt_Sony_1 b/tests/ref/fate/hevc-conformance-PERSIST_RPARAM_A_RExt_Sony_3 similarity index 100% rename from tests/ref/fate/hevc-conformance-PERSIST_RPARAM_A_RExt_Sony_1 rename to tests/ref/fate/hevc-conformance-PERSIST_RPARAM_A_RExt_Sony_3
The PERSIST_RPARAM_A_RExt_Sony_1 bitstream has an out-of-range value and has therefore been superseded. It is otherwise identical, and decodes the same. Signed-off-by: James Almer <jamrial@gmail.com> --- tests/fate/hevc.mak | 3 +-- ...RAM_A_RExt_Sony_1 => hevc-conformance-PERSIST_RPARAM_A_RExt_Sony_3} | 0 2 files changed, 1 insertion(+), 2 deletions(-) rename tests/ref/fate/{hevc-conformance-PERSIST_RPARAM_A_RExt_Sony_1 => hevc-conformance-PERSIST_RPARAM_A_RExt_Sony_3} (100%)