diff mbox

[FFmpeg-devel] configure: remove libdl dependency from libndi_newtek

Message ID 20171010213428.3443-1-cus@passwd.hu
State Accepted
Commit 58143b15adda6391ec07f3eb19e80ed91d801edd
Headers show

Commit Message

Marton Balint Oct. 10, 2017, 9:34 p.m. UTC
We are not using dynamic loading for libndi.

Signed-off-by: Marton Balint <cus@passwd.hu>
---
 configure | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

James Almer Oct. 10, 2017, 10:27 p.m. UTC | #1
On 10/10/2017 6:34 PM, Marton Balint wrote:
> We are not using dynamic loading for libndi.
> 
> Signed-off-by: Marton Balint <cus@passwd.hu>
> ---
>  configure | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index e2ef54fb3b..259619cccd 100755
> --- a/configure
> +++ b/configure
> @@ -3089,9 +3089,9 @@ decklink_indev_deps="decklink threads"
>  decklink_indev_extralibs="-lstdc++"
>  decklink_outdev_deps="decklink threads"
>  decklink_outdev_extralibs="-lstdc++"
> -libndi_newtek_indev_deps="libndi_newtek libdl"
> +libndi_newtek_indev_deps="libndi_newtek"
>  libndi_newtek_indev_extralibs="-lndi"
> -libndi_newtek_outdev_deps="libndi_newtek libdl"
> +libndi_newtek_outdev_deps="libndi_newtek"
>  libndi_newtek_outdev_extralibs="-lndi"
>  dshow_indev_deps="IBaseFilter"
>  dshow_indev_extralibs="-lpsapi -lole32 -lstrmiids -luuid -loleaut32 -lshlwapi"

Should be good.
Marton Balint Oct. 11, 2017, 8:54 p.m. UTC | #2
On Tue, 10 Oct 2017, James Almer wrote:

> On 10/10/2017 6:34 PM, Marton Balint wrote:
>> We are not using dynamic loading for libndi.
>> 
>> Signed-off-by: Marton Balint <cus@passwd.hu>
>> ---
>>  configure | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/configure b/configure
>> index e2ef54fb3b..259619cccd 100755
>> --- a/configure
>> +++ b/configure
>> @@ -3089,9 +3089,9 @@ decklink_indev_deps="decklink threads"
>>  decklink_indev_extralibs="-lstdc++"
>>  decklink_outdev_deps="decklink threads"
>>  decklink_outdev_extralibs="-lstdc++"
>> -libndi_newtek_indev_deps="libndi_newtek libdl"
>> +libndi_newtek_indev_deps="libndi_newtek"
>>  libndi_newtek_indev_extralibs="-lndi"
>> -libndi_newtek_outdev_deps="libndi_newtek libdl"
>> +libndi_newtek_outdev_deps="libndi_newtek"
>>  libndi_newtek_outdev_extralibs="-lndi"
>>  dshow_indev_deps="IBaseFilter"
>>  dshow_indev_extralibs="-lpsapi -lole32 -lstrmiids -luuid -loleaut32 -lshlwapi"
>
> Should be good.

Pushed and backported to 3.4.

Regards,
Marton
diff mbox

Patch

diff --git a/configure b/configure
index e2ef54fb3b..259619cccd 100755
--- a/configure
+++ b/configure
@@ -3089,9 +3089,9 @@  decklink_indev_deps="decklink threads"
 decklink_indev_extralibs="-lstdc++"
 decklink_outdev_deps="decklink threads"
 decklink_outdev_extralibs="-lstdc++"
-libndi_newtek_indev_deps="libndi_newtek libdl"
+libndi_newtek_indev_deps="libndi_newtek"
 libndi_newtek_indev_extralibs="-lndi"
-libndi_newtek_outdev_deps="libndi_newtek libdl"
+libndi_newtek_outdev_deps="libndi_newtek"
 libndi_newtek_outdev_extralibs="-lndi"
 dshow_indev_deps="IBaseFilter"
 dshow_indev_extralibs="-lpsapi -lole32 -lstrmiids -luuid -loleaut32 -lshlwapi"