[FFmpeg-devel] configure: use pkg-config for libilbc

Submitted by James Almer on Oct. 13, 2017, 6:09 p.m.

Details

Message ID 20171013180943.7172-1-jamrial@gmail.com
State New
Headers show

Commit Message

James Almer Oct. 13, 2017, 6:09 p.m.
With this, the check will include the needed pthreads ldflags when
pkg-config is invoked with the --static flag.

Signed-off-by: James Almer <jamrial@gmail.com>
---
Alternatively, i can keep the current check and add $pthreads_extralibs
to it.

 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

James Almer Oct. 13, 2017, 11:34 p.m.
On 10/13/2017 3:09 PM, James Almer wrote:
> With this, the check will include the needed pthreads ldflags when
> pkg-config is invoked with the --static flag.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> Alternatively, i can keep the current check and add $pthreads_extralibs
> to it.

Patch dropped. It seems the pkg-config file is not guaranteed to always
include the pthreads ldflag.
Added $pthreads_extralibs instead and pushed.

> 
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index dc486ed756..749fc073a1 100755
> --- a/configure
> +++ b/configure
> @@ -5997,7 +5997,7 @@ enabled libgme            && { use_pkg_config libgme libgme gme/gme.h gme_new_em
>  enabled libgsm            && { for gsm_hdr in "gsm.h" "gsm/gsm.h"; do
>                                     check_lib libgsm "${gsm_hdr}" gsm_create -lgsm && break;
>                                 done || die "ERROR: libgsm not found"; }
> -enabled libilbc           && require libilbc ilbc.h WebRtcIlbcfix_InitDecode -lilbc
> +enabled libilbc           && require_pkg_config libilbc libilbc ilbc.h WebRtcIlbcfix_InitDecode
>  enabled libkvazaar        && require_pkg_config libkvazaar "kvazaar >= 0.8.1" kvazaar.h kvz_api_get
>  # While it may appear that require is being used as a pkg-config
>  # fallback for libmfx, it is actually being used to detect a different
>

Patch hide | download patch | download mbox

diff --git a/configure b/configure
index dc486ed756..749fc073a1 100755
--- a/configure
+++ b/configure
@@ -5997,7 +5997,7 @@  enabled libgme            && { use_pkg_config libgme libgme gme/gme.h gme_new_em
 enabled libgsm            && { for gsm_hdr in "gsm.h" "gsm/gsm.h"; do
                                    check_lib libgsm "${gsm_hdr}" gsm_create -lgsm && break;
                                done || die "ERROR: libgsm not found"; }
-enabled libilbc           && require libilbc ilbc.h WebRtcIlbcfix_InitDecode -lilbc
+enabled libilbc           && require_pkg_config libilbc libilbc ilbc.h WebRtcIlbcfix_InitDecode
 enabled libkvazaar        && require_pkg_config libkvazaar "kvazaar >= 0.8.1" kvazaar.h kvz_api_get
 # While it may appear that require is being used as a pkg-config
 # fallback for libmfx, it is actually being used to detect a different