From patchwork Tue Oct 17 21:12:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Thompson X-Patchwork-Id: 5606 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.161.90 with SMTP id m26csp636563jah; Tue, 17 Oct 2017 14:18:59 -0700 (PDT) X-Received: by 10.28.232.75 with SMTP id f72mr4340764wmh.90.1508275139185; Tue, 17 Oct 2017 14:18:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508275139; cv=none; d=google.com; s=arc-20160816; b=XZDTuXqSBrk7QTxdxlDLz0EQikJ4v8XtPXjtE2I7hhgP5fg25jKg8vKgbnftHWWK++ Wp9I/ffmvVbIbXcaRi8VWZ3IiwJ2fOfg+TuhlrzjJA5PlePT4xs9+LX1lmD7FRPveD4K QORn5dnKgerz+b0UN8gGIxi/rWZafaTej4oBDDn+KgrxuQnggMeJjFp13iELmWwv3M3j TqZIXCFuLAa6kcZfI46IaTwJxA3iVedPIQwO9n0mMTS3uBQqwhQ5uGl7n1GZIw2BBoOP 8qZVDZjNsGjuVwg//1TSJSY18ultixDbZKBFqR2vGTMgo1cm59ishsUHXG329FHaosde nJ+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=0qbvB+gFtYCvYC+v4F6X6OpxgYd4cwWNcdFq6l1rv2A=; b=K7kLAfc4Q8j4ks1fhjKxX5bX9zXRkm+jk19H9hTuF0m4XAiJm+Vt7rJxj7bIO2w2kF L8ZTf9puxDTvcmm4IINDge2T3r/1Z9xu4CLcF+EzoGU4vmO2byql/AdPtIb9k/400awH Dr3SSfkETcRyVVa4Lls3kwI43ED+OlfCgLUC0dfn1HxflSWiDvYAssYBVvSyUEOtijjH UwZ36QfIX7yzS8z/233+sXJ+1GXnzjs4JX1YV5wcPQDglBte995InApTpzTMqCL2wsfA /7YxFkFmGUp3/vR6+l1QXG+P5R5xdrDHCXivaeR9ySpdTrQr7sRrGR0OH4NnUJ3CHJ3A +txA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@jkqxz-net.20150623.gappssmtp.com header.s=20150623 header.b=iG16w/QE; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id y202si2854355wmd.179.2017.10.17.14.18.58; Tue, 17 Oct 2017 14:18:59 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@jkqxz-net.20150623.gappssmtp.com header.s=20150623 header.b=iG16w/QE; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 01192689FE9; Wed, 18 Oct 2017 00:18:53 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr0-f176.google.com (mail-wr0-f176.google.com [209.85.128.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8A0C7689C81 for ; Wed, 18 Oct 2017 00:18:46 +0300 (EEST) Received: by mail-wr0-f176.google.com with SMTP id o44so3060520wrf.11 for ; Tue, 17 Oct 2017 14:18:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=LdaAqASkquL0Nc4Uvf+uN7uzPSBFCxHma0IeiKkXmis=; b=iG16w/QE/TiJ6W+m/nNIhNW5im1F7vcmbUoOGp+nOd49tCUEFA/EMKi/NgQHyKJ+dI h3vY9YwcpzHB5U8BY+tAA/weuxzm9OMWTm/aVyt/A3k0U32NCwanikPE4Ew948f0tOvn o53gDVkAunKv0d5yY4PadkODRNTlEvF8+e+Vv6T4sGDPtFytkutXjbmyMNdhzFvZWEgl +Bgz8M9sJJd4wNXEOk5Ilmju5PdxpJyB2NtcNktpuEjd8i3rvo0fAue1bPQwYQF+P4Fa 9Zhwp7hGy5JlBbbc04yFa8ZS7HTYkdSapyMfVYcJ2Pn0foKquKqbRZtdAHx0454+xUYB YtpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=LdaAqASkquL0Nc4Uvf+uN7uzPSBFCxHma0IeiKkXmis=; b=axShicFNMQw2W4H6PfVJxcEpU9yS00XhaMofCyWOgfNAfcQyZnXII56BgfyoUCPAr9 C9eE7Vy//86qKmoQidYpzpnhhtsTWM5vOp8GRwh3WTNTQlr2YtK63L+BFRVq1kFqIW/V R2Pj1+UerqcrsKqShCrbbct1kScdfJR6zWTp1q/Lszoa73G73btBo2lIO39+eUEgCBzK OHcKALbZbbOEzukLtlXpRAMrFdp/oage7QjJMkQnTYnr1wyLR6DciMCFXstIYVdFhc48 h2I+G8VcVB0FU5NfZC/82mBxgKMnrYI4yWCzfsyMAa04FEmlbHeubkPdvnf5Bk2D4U+8 jZjQ== X-Gm-Message-State: AMCzsaWQPaHCGer5BVkjnLAt7EM++Bons+r+a2dLmhOf/C+7hUYC681e s2IXprVVAa1SGOrHOCyCQCq9jFF2 X-Google-Smtp-Source: ABhQp+TzaS45HMCjixdA9egn9vuwRWe/2cXE6FIB3G3vX4k6dpkMhRxSQkVs0/C14nLSvXojYEnbXQ== X-Received: by 10.223.146.101 with SMTP id 92mr4360103wrj.21.1508274750845; Tue, 17 Oct 2017 14:12:30 -0700 (PDT) Received: from rywe.jkqxz.net (cpc91242-cmbg18-2-0-cust650.5-4.cable.virginm.net. [82.8.130.139]) by smtp.gmail.com with ESMTPSA id m25sm10810335wmi.7.2017.10.17.14.12.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Oct 2017 14:12:30 -0700 (PDT) From: Mark Thompson To: ffmpeg-devel@ffmpeg.org Date: Tue, 17 Oct 2017 22:12:17 +0100 Message-Id: <20171017211225.3175-1-sw@jkqxz.net> X-Mailer: git-send-email 2.11.0 Subject: [FFmpeg-devel] [PATCH 1/9] lavc: Mark functions where ignoring returned error code is always wrong X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" --- libavcodec/avcodec.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 18c3e3ea1e..8fc2f6920e 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -4492,6 +4492,7 @@ int avcodec_parameters_to_context(AVCodecContext *codec, * @see avcodec_alloc_context3(), avcodec_find_decoder(), avcodec_find_encoder(), * av_dict_set(), av_opt_find(). */ +av_warn_unused_result int avcodec_open2(AVCodecContext *avctx, const AVCodec *codec, AVDictionary **options); /** @@ -4577,6 +4578,7 @@ void av_init_packet(AVPacket *pkt); * @param size wanted payload size * @return 0 if OK, AVERROR_xxx otherwise */ +av_warn_unused_result int av_new_packet(AVPacket *pkt, int size); /** @@ -4593,6 +4595,7 @@ void av_shrink_packet(AVPacket *pkt, int size); * @param pkt packet * @param grow_by number of bytes by which to increase the size of the packet */ +av_warn_unused_result int av_grow_packet(AVPacket *pkt, int grow_by); /** @@ -4751,6 +4754,7 @@ void av_packet_free_side_data(AVPacket *pkt); * * @return 0 on success, a negative AVERROR on error. */ +av_warn_unused_result int av_packet_ref(AVPacket *dst, const AVPacket *src); /** @@ -4829,6 +4833,7 @@ AVCodec *avcodec_find_decoder_by_name(const char *name); * it can be called by custom get_buffer2() implementations for decoders without * AV_CODEC_CAP_DR1 set. */ +av_warn_unused_result int avcodec_default_get_buffer2(AVCodecContext *s, AVFrame *frame, int flags); #if FF_API_EMU_EDGE @@ -5095,6 +5100,7 @@ int avcodec_send_packet(AVCodecContext *avctx, const AVPacket *avpkt); * AVERROR(EINVAL): codec not opened, or it is an encoder * other negative values: legitimate decoding errors */ +av_warn_unused_result int avcodec_receive_frame(AVCodecContext *avctx, AVFrame *frame); /** @@ -5149,6 +5155,7 @@ int avcodec_send_frame(AVCodecContext *avctx, const AVFrame *frame); * AVERROR(EINVAL): codec not opened, or it is an encoder * other errors: legitimate decoding errors */ +av_warn_unused_result int avcodec_receive_packet(AVCodecContext *avctx, AVPacket *avpkt); @@ -6106,12 +6113,14 @@ const AVBitStreamFilter *av_bsf_next(void **opaque); * * @return 0 on success, a negative AVERROR code on failure */ +av_warn_unused_result int av_bsf_alloc(const AVBitStreamFilter *filter, AVBSFContext **ctx); /** * Prepare the filter for use, after all the parameters and options have been * set. */ +av_warn_unused_result int av_bsf_init(AVBSFContext *ctx); /** @@ -6155,6 +6164,7 @@ int av_bsf_send_packet(AVBSFContext *ctx, AVPacket *pkt); * output fewer packets than were sent to it, so this function may return * AVERROR(EAGAIN) immediately after a successful av_bsf_send_packet() call. */ +av_warn_unused_result int av_bsf_receive_packet(AVBSFContext *ctx, AVPacket *pkt); /**