From patchwork Sun Nov 5 18:59:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Thompson X-Patchwork-Id: 5869 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.161.90 with SMTP id m26csp2143523jah; Sun, 5 Nov 2017 10:59:51 -0800 (PST) X-Google-Smtp-Source: ABhQp+SU5T5BhbN8Td/6M/z7hB9AvCRE2U8mcWK3bfWJX58xfuarE5CgTe5leBeOfRt5DXFjaZUV X-Received: by 10.28.152.76 with SMTP id a73mr3143657wme.127.1509908391656; Sun, 05 Nov 2017 10:59:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1509908391; cv=none; d=google.com; s=arc-20160816; b=StQydEjDXztJ1zBDpK1XwshbtaC8tBmwWzI4YKgpm0/zulg8W3hT58yfwcmYeNC6Jw +1w36kIzzQ8sAZ/5dIMSyG+VpNyvstPzjcZcXY74qE3FcuAwd2wMb+aHKIh2VM0H/Eq/ RwltBLTr6w573Abhs9AOb6xmLLStEreD4FEBOnh9uJb1wgBVYSenI3+9QlRFMgWEBN8Q Pb1FysJJh1Fg1Ex5idVkvW73U0AJBf2//h30udLoP5xJT83ZSKYdu5+V2v0RTt7sZEp9 A44YWNIuTX5cz/akCMVb3vjBkZ0z0aBIFvvyRMs1HHrNhyq0HezLGAeJEw/BTisv6idK AzvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:dkim-signature :delivered-to:arc-authentication-results; bh=6PWDpxk7p7fx9kxQ3z/Iojn4Lorgm78mUz9XXam9BPc=; b=kc2G3EclfD2W9YS8x7BueCVU0JOVTi+ZGm+m4SuNo7KC6ADslHkiMTwZcVhT/3jiFf IboWZLeDhRHVHdaPIANJ7/h/8gCGO06FzQ7GO3AGriXutP8c9qjOu5GddWV2xaMRnyvk Mzv0/Ka4xEQOudMrutPWaZJZ9iAhFf/x74f7ftEcdo3MXIFcugnKNwhXv4PFj6p47bSA 4joK79L1D8fhT6qdECuAxK444+wHFrJ7faycSxxp7jiR2S2CAD/vXttp35kMhNX1eWEl tcsN/sYwSAdspIezTQMLCYMfPSgHQbG+Ay0ETeDbRQZtOdV08qmdQv9JFhZeDt4jMax6 OAUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@jkqxz-net.20150623.gappssmtp.com header.s=20150623 header.b=znB5T1yZ; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id s81si5519951wma.42.2017.11.05.10.59.50; Sun, 05 Nov 2017 10:59:51 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@jkqxz-net.20150623.gappssmtp.com header.s=20150623 header.b=znB5T1yZ; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 38D55689E70; Sun, 5 Nov 2017 20:59:38 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9876F689C91 for ; Sun, 5 Nov 2017 20:59:32 +0200 (EET) Received: by mail-wr0-f180.google.com with SMTP id o44so6631824wrf.11 for ; Sun, 05 Nov 2017 10:59:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=TvbRmD4mYg1SfMWivTIJggXvlxkwDsCNfCc84S+/YzQ=; b=znB5T1yZ5D8wVHIXaXdiXjzycFmdIH2HU/lNtRzFYWJjb7IouexYCEvPvi+Yifn/oo W3SXTOtArzZQ6BwIhOBcFscIsGT1wiNe/d6QfySsVj/fQku49I5IvcSuniSjVjO60VRK wmewnCfzQmiH9zo6V9APmpvsr1gCnDLIXok7jh/SuzyFMUD3G5q5QdG6wDShkYt3/KXP aaWNvjQgPLAYi8pN6488hzm20P7H3js8iVhbzVVoz7ub9OySO89rUgw3wA/Ty7O6+u1e Er+8z52DRUi43ADokiXHrdM2tkvFULYRLzYcpf5rFl+ur2XJgWzWy6oRlQxJpJJn1PwZ 5tVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TvbRmD4mYg1SfMWivTIJggXvlxkwDsCNfCc84S+/YzQ=; b=B6qlRso/0XaeWBwqc/HH17p5lHIy8sdq05KSmlDeOHjCB5rPAP9t0wEpwpg+eOFFO2 EQtWLEvMY4XtNHofcVruV//h6EvgYPjTVnKUhLXTuxTUbPBdQNnFQ5Ew6Wh0OAQ8D5SU 7mb8blKsJH9sN7kf7XmxbI9mJd3BA2EwzrOK39CRpzmdMTgDXd8jbvNzNPyWodsrgzMp QzxvqMMZWvRNqklhBnF+m4NcyLF1MMa0x0adNcnJESTHiw0rJXy+tZchdqnfl0ZBBGS+ 4smRSmEOOB7ESOsSjFiDcoIIfDCo6YwSrTmghCNZMb+hdhhFsqL8Wg0XI9iZakPZ40xl KfOg== X-Gm-Message-State: AMCzsaXZb3gEY/Q4AAdqfHET26iBREPDOygCynTL5a2WTHuKf2VLfXzt WMHVBgdckoOcXFlEHJ3On7CK3kIx X-Received: by 10.223.161.210 with SMTP id v18mr11285572wrv.76.1509908383725; Sun, 05 Nov 2017 10:59:43 -0800 (PST) Received: from [192.168.0.9] (cpc91242-cmbg18-2-0-cust650.5-4.cable.virginm.net. [82.8.130.139]) by smtp.gmail.com with ESMTPSA id j2sm12995879wrj.82.2017.11.05.10.59.42 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 05 Nov 2017 10:59:43 -0800 (PST) To: ffmpeg-devel@ffmpeg.org References: <1a7cbe3b-e4d6-62f9-d6d4-85b0a1d4c099@jkqxz.net> <1e136607-9a69-de80-1733-93b1070eeb15@jkqxz.net> <423bc327-8a9e-b1a5-346d-ae4f5371ae19@jkqxz.net> From: Mark Thompson Message-ID: <2b14914a-6e18-87f9-0483-d9f973e524b8@jkqxz.net> Date: Sun, 5 Nov 2017 18:59:42 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Subject: Re: [FFmpeg-devel] On in-tree external headers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On 05/11/17 18:42, Carl Eugen Hoyos wrote: > 2017-11-05 19:35 GMT+01:00 Mark Thompson : >> On 05/11/17 18:28, Carl Eugen Hoyos wrote: >>> 2017-11-05 15:24 GMT+01:00 Mark Thompson : >>>> On 30/10/17 19:51, Mark Thompson wrote: >>> >>>> "No external headers may be included in the ffmpeg tree." >>> >>> So you suggest to remove the Nvidia header? >> If that specific policy is adopted then it would have to be. > > Then I don't think this policy is useful. > > Iirc, there is a second external header, I have never used > either of those but judging from user response, both features > are heavily used making a removal a no-go. Ok, sure. How about: "No external headers may be added to the ffmpeg tree, unless they are for AviSynth or Nvidia." (Documentation patch below.) >> Alternative proposals are welcome. > > I don't really understand: > It was mentioned several times in the relevant thread - and > I completely agree - that the fact that one external header > is present is no argument to add another. (And iirc - and > again I agree - it was also argued that pushing on this > argument is not a good idea.) > If you believe adding the AMD header makes sense, it may > possibly be added, if you are against it, it will likely not be > added. I do not believe that adding the AMD header is the right thing to do. But, I want to be clear what the rules are so that they can be applied consistently. There currently appear to be no written rules, so I would like to write some so that we have a clear answer in this case and don't have this same dispute again in future (see V4L2 two months ago, where there was a pretty much identical argument with a contributor wanting to add their headers to the tree). - Mark diff --git a/doc/developer.texi b/doc/developer.texi index a7b4f1d737..c76e0083ce 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -381,6 +381,16 @@ Never write to unallocated memory, never write over the end of arrays, always check values read from some untrusted source before using them as array index or other risky things. +@subheading External headers +Do not include external headers directly in FFmpeg. Most packages provide +suitable headers and linkable libraries when installed, and these should be +used. References to external packages in configure should use pkg-config +if possible to find paths and options - ad-hoc build tests with hard-coded +paths are to be avoided, but can be used if there is no other possibility. +If an external package does not provide usable headers or libraries then +please add directions for how to use it to the documentation. +AviSynth and Nvidia are exempt from this prohibition on external headers. + @subsection Documentation/Other @subheading Subscribe to the ffmpeg-cvslog mailing list. It is important to do this as the diffs of all commits are sent there and