diff mbox

[FFmpeg-devel,1/2] avcodec: fix whitespace on AVPanScan struct definition

Message ID 20171114180402.21244-1-ffmpeg@tmm1.net
State Accepted
Commit 034e1f82d924bb3038873798b2cc8d84f9701f62
Headers show

Commit Message

Aman Karmani Nov. 14, 2017, 6:04 p.m. UTC
From: Aman Gupta <aman@tmm1.net>

---
 libavcodec/avcodec.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

James Almer Nov. 14, 2017, 6:23 p.m. UTC | #1
On 11/14/2017 3:04 PM, Aman Gupta wrote:
> From: Aman Gupta <aman@tmm1.net>
> 
> ---
>  libavcodec/avcodec.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index 74b097cdd8..0875ae3ba0 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -1049,7 +1049,7 @@ typedef struct RcOverride{
>   * This specifies the area which should be displayed.
>   * Note there may be multiple such areas for one frame.
>   */
> -typedef struct AVPanScan{
> +typedef struct AVPanScan {
>      /**
>       * id
>       * - encoding: Set by user.
> @@ -1071,7 +1071,7 @@ typedef struct AVPanScan{
>       * - decoding: Set by libavcodec.
>       */
>      int16_t position[3][2];
> -}AVPanScan;
> +} AVPanScan;

LGTM, but minimal cosmetic changes like this don't need a patch if you
have push rights.

>  
>  /**
>   * This structure describes the bitrate properties of an encoded bitstream. It
>
Aman Karmani Nov. 14, 2017, 6:24 p.m. UTC | #2
On Tue, Nov 14, 2017 at 10:23 AM, James Almer <jamrial@gmail.com> wrote:

> On 11/14/2017 3:04 PM, Aman Gupta wrote:
> > From: Aman Gupta <aman@tmm1.net>
> >
> > ---
> >  libavcodec/avcodec.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> > index 74b097cdd8..0875ae3ba0 100644
> > --- a/libavcodec/avcodec.h
> > +++ b/libavcodec/avcodec.h
> > @@ -1049,7 +1049,7 @@ typedef struct RcOverride{
> >   * This specifies the area which should be displayed.
> >   * Note there may be multiple such areas for one frame.
> >   */
> > -typedef struct AVPanScan{
> > +typedef struct AVPanScan {
> >      /**
> >       * id
> >       * - encoding: Set by user.
> > @@ -1071,7 +1071,7 @@ typedef struct AVPanScan{
> >       * - decoding: Set by libavcodec.
> >       */
> >      int16_t position[3][2];
> > -}AVPanScan;
> > +} AVPanScan;
>
> LGTM, but minimal cosmetic changes like this don't need a patch if you
> have push rights.
>

Ah, I did not know that. Will push, thanks!

Aman


>
> >
> >  /**
> >   * This structure describes the bitrate properties of an encoded
> bitstream. It
> >
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
diff mbox

Patch

diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index 74b097cdd8..0875ae3ba0 100644
--- a/libavcodec/avcodec.h
+++ b/libavcodec/avcodec.h
@@ -1049,7 +1049,7 @@  typedef struct RcOverride{
  * This specifies the area which should be displayed.
  * Note there may be multiple such areas for one frame.
  */
-typedef struct AVPanScan{
+typedef struct AVPanScan {
     /**
      * id
      * - encoding: Set by user.
@@ -1071,7 +1071,7 @@  typedef struct AVPanScan{
      * - decoding: Set by libavcodec.
      */
     int16_t position[3][2];
-}AVPanScan;
+} AVPanScan;
 
 /**
  * This structure describes the bitrate properties of an encoded bitstream. It