diff mbox

[FFmpeg-devel,09/11] avformat/swfenc: use FFABS to instead of abs

Message ID 20171115074503.25538-1-lq@chinaffmpeg.org
State Accepted
Commit 462a14b1e9373bc4e4c535b0417eae5773a6172a
Headers show

Commit Message

Liu Steven Nov. 15, 2017, 7:45 a.m. UTC 
Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
---
 libavformat/swfenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Niedermayer Nov. 16, 2017, 3 p.m. UTC | #1 
On Wed, Nov 15, 2017 at 03:45:03PM +0800, Steven Liu wrote:
> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
> ---
>  libavformat/swfenc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

LGTM

thx

[...]
Steven Liu Nov. 20, 2017, 3:08 a.m. UTC | #2 
2017-11-16 23:00 GMT+08:00 Michael Niedermayer <michael@niedermayer.cc>:
> On Wed, Nov 15, 2017 at 03:45:03PM +0800, Steven Liu wrote:
>> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
>> ---
>>  libavformat/swfenc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> LGTM
>

Pushed

Thx
> thx
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Its not that you shouldnt use gotos but rather that you should write
> readable code and code with gotos often but not always is less readable
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
diff mbox

Patch

diff --git a/libavformat/swfenc.c b/libavformat/swfenc.c
index cada45ef9a..f53db0fb2b 100644
--- a/libavformat/swfenc.c
+++ b/libavformat/swfenc.c
@@ -69,7 +69,7 @@  static inline void max_nbits(int *nbits_ptr, int val)
 
     if (val == 0)
         return;
-    val = abs(val);
+    val = FFABS(val);
     n = 1;
     while (val != 0) {
         n++;