diff mbox

[FFmpeg-devel] avformat/avio: remove must_flush from AVIOContext

Message ID 20171115212615.18592-1-cus@passwd.hu
State Accepted
Commit ca940ed2d5ad8b0f00d289f0216bb19f115bac85
Headers show

Commit Message

Marton Balint Nov. 15, 2017, 9:26 p.m. UTC 
It is unused.

Signed-off-by: Marton Balint <cus@passwd.hu>
---
 libavformat/avio.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Nicolas George Nov. 15, 2017, 9:27 p.m. UTC | #1 
Le quintidi 25 brumaire, an CCXXVI, Marton Balint a écrit :
> It is unused.
> 
> Signed-off-by: Marton Balint <cus@passwd.hu>
> ---
>  libavformat/avio.h | 1 -
>  1 file changed, 1 deletion(-)

Breaks ABI by moving all the fields below.

Regards,
Marton Balint Nov. 15, 2017, 9:45 p.m. UTC | #2 
On Wed, 15 Nov 2017, Nicolas George wrote:

> Le quintidi 25 brumaire, an CCXXVI, Marton Balint a écrit :
>> It is unused.
>>
>> Signed-off-by: Marton Balint <cus@passwd.hu>
>> ---
>>  libavformat/avio.h | 1 -
>>  1 file changed, 1 deletion(-)
>
> Breaks ABI by moving all the fields below.

We are still in unstable ABI period AFAIK.

Regards,
Marton
Marton Balint Nov. 19, 2017, 9:56 p.m. UTC | #3 
On Wed, 15 Nov 2017, Marton Balint wrote:

>
> On Wed, 15 Nov 2017, Nicolas George wrote:
>
>> Le quintidi 25 brumaire, an CCXXVI, Marton Balint a écrit :
>>> It is unused.
>>>
>>> Signed-off-by: Marton Balint <cus@passwd.hu>
>>> ---
>>>  libavformat/avio.h | 1 -
>>>  1 file changed, 1 deletion(-)
>>
>> Breaks ABI by moving all the fields below.
>
> We are still in unstable ABI period AFAIK.

Will apply soon.

Regards,
Marton
Marton Balint Nov. 20, 2017, 9:04 p.m. UTC | #4 
On Sun, 19 Nov 2017, Marton Balint wrote:

>
>
> On Wed, 15 Nov 2017, Marton Balint wrote:
>
>>
>> On Wed, 15 Nov 2017, Nicolas George wrote:
>>
>>> Le quintidi 25 brumaire, an CCXXVI, Marton Balint a écrit :
>>>> It is unused.
>>>>
>>>> Signed-off-by: Marton Balint <cus@passwd.hu>
>>>> ---
>>>>  libavformat/avio.h | 1 -
>>>>  1 file changed, 1 deletion(-)
>>>
>>> Breaks ABI by moving all the fields below.
>>
>> We are still in unstable ABI period AFAIK.
>
> Will apply soon.

Pushed.

Regards,
Marton
diff mbox

Patch

diff --git a/libavformat/avio.h b/libavformat/avio.h
index 76ff7cd81e..75912ce6be 100644
--- a/libavformat/avio.h
+++ b/libavformat/avio.h
@@ -236,7 +236,6 @@  typedef struct AVIOContext {
     int (*write_packet)(void *opaque, uint8_t *buf, int buf_size);
     int64_t (*seek)(void *opaque, int64_t offset, int whence);
     int64_t pos;            /**< position in the file of the current buffer */
-    int must_flush;         /**< unused */
     int eof_reached;        /**< true if eof reached */
     int write_flag;         /**< true if open for writing */
     int max_packet_size;