| Message ID | alpine.DEB.2.02.1711232017181.31462@leontynka |
|---|---|
| State | Accepted |
| Commit | 279d2599dd6be8e2030a4543b4efa245fd75de5c |
| Headers | show |
On Thu, Nov 23, 2017 at 8:22 PM, Mikulas Patocka <mikulas@twibright.com> wrote: > This patch fixes the following error when compiling mplayer with libopus. > > libavcodec/libopusdec.c: In function 'libopus_decode_init': > libavcodec/libopusdec.c:130:27: error: implicit declaration of function 'ff_exp10'; did you mean 'ff_exp2fi'? [-Werror=implicit-function-declaration] > double gain_lin = ff_exp10(gain_db / (20.0 * 256)); > ^~~~~~~~ > ff_exp2fi > Can this issue be reproduced with ffmpeg alone, without mplayer? - Hendrik
2017-11-23 23:41 GMT+01:00 Hendrik Leppkes <h.leppkes@gmail.com>: > On Thu, Nov 23, 2017 at 8:22 PM, Mikulas Patocka <mikulas@twibright.com> wrote: >> This patch fixes the following error when compiling mplayer with libopus. >> >> libavcodec/libopusdec.c: In function 'libopus_decode_init': >> libavcodec/libopusdec.c:130:27: error: implicit declaration of function 'ff_exp10'; did you mean 'ff_exp2fi'? >> double gain_lin = ff_exp10(gain_db / (20.0 * 256)); >> ^~~~~~~~ >> ff_exp2fi > > Can this issue be reproduced with ffmpeg alone, without mplayer? Yes, regression since 48cd3d23 on affected systems. Carl Eugen
On Fri, Nov 24, 2017 at 12:30:55AM +0100, Carl Eugen Hoyos wrote: > 2017-11-23 23:41 GMT+01:00 Hendrik Leppkes <h.leppkes@gmail.com>: > > On Thu, Nov 23, 2017 at 8:22 PM, Mikulas Patocka <mikulas@twibright.com> wrote: > >> This patch fixes the following error when compiling mplayer with libopus. > >> > >> libavcodec/libopusdec.c: In function 'libopus_decode_init': > >> libavcodec/libopusdec.c:130:27: error: implicit declaration of function 'ff_exp10'; did you mean 'ff_exp2fi'? > >> double gain_lin = ff_exp10(gain_db / (20.0 * 256)); > >> ^~~~~~~~ > >> ff_exp2fi > > > > Can this issue be reproduced with ffmpeg alone, without mplayer? > > Yes, regression since 48cd3d23 on affected systems. will apply unless someone else is faster thx [...]
Index: ffmpeg/libavcodec/libopusdec.c =================================================================== --- ffmpeg.orig/libavcodec/libopusdec.c 2017-11-19 23:44:55.000000000 +0100 +++ ffmpeg/libavcodec/libopusdec.c 2017-11-23 03:54:43.000000000 +0100 @@ -24,6 +24,7 @@ #include "libavutil/internal.h" #include "libavutil/intreadwrite.h" +#include "libavutil/ffmath.h" #include "avcodec.h" #include "internal.h"
This patch fixes the following error when compiling mplayer with libopus. libavcodec/libopusdec.c: In function 'libopus_decode_init': libavcodec/libopusdec.c:130:27: error: implicit declaration of function 'ff_exp10'; did you mean 'ff_exp2fi'? [-Werror=implicit-function-declaration] double gain_lin = ff_exp10(gain_db / (20.0 * 256)); ^~~~~~~~ ff_exp2fi Signed-off-by: Mikulas Patocka <mikulas@twibright.com> --- libavcodec/libopusdec.c | 1 + 1 file changed, 1 insertion(+)