diff mbox

[FFmpeg-devel] avcodec/samidec: check av_strdup() return value

Message ID 1511744002-21548-1-git-send-email-bianpan2016@163.com
State Superseded
Headers show

Commit Message

Pan Bian Nov. 27, 2017, 12:53 a.m. UTC 
From: Pan Bian <bianpan@163.com>

In function sami_paragraph_to_ass(), the return value of av_strdup() is
not checked. To avoid potential NULL dereference, the return value
should be checked against NULL.

Signed-off-by: Pan Bian <bianpan@163.com>
---
 libavcodec/samidec.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Moritz Barsnick Nov. 27, 2017, 12:54 p.m. UTC | #1 
On Mon, Nov 27, 2017 at 08:53:22 +0800, Pan Bian wrote:
> +	if (!dupsrc)
> +		return AVERROR(ENOMEM);
> +

Tabs are not allowed, please check your indentation. You can use
tools/patcheck to find these kinds of issues.

Moritz
diff mbox

Patch

diff --git a/libavcodec/samidec.c b/libavcodec/samidec.c
index 2620424..35fcc41 100644
--- a/libavcodec/samidec.c
+++ b/libavcodec/samidec.c
@@ -48,6 +48,9 @@  static int sami_paragraph_to_ass(AVCodecContext *avctx, const char *src)
     AVBPrint *dst_content = &sami->encoded_content;
     AVBPrint *dst_source = &sami->encoded_source;
 
+	if (!dupsrc)
+		return AVERROR(ENOMEM);
+
     av_bprint_clear(&sami->encoded_content);
     av_bprint_clear(&sami->content);
     av_bprint_clear(&sami->encoded_source);