From patchwork Thu Dec 7 06:24:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhong Li X-Patchwork-Id: 6575 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.161.94 with SMTP id m30csp7901627jah; Wed, 6 Dec 2017 22:25:58 -0800 (PST) X-Google-Smtp-Source: AGs4zMYsZpERj1YxZADV3ySdN5CIoMGlZbUeWQ98l74NMoU/9eAYSYfhvZI2TIZwwVY0oAIuRh3L X-Received: by 10.223.157.41 with SMTP id k41mr4988383wre.281.1512627958518; Wed, 06 Dec 2017 22:25:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512627958; cv=none; d=google.com; s=arc-20160816; b=bDG8C2ikgNFptTSHLfrk1NM/T5rU14edEngzrKJ0R5my2b1MFyYXjQDeUPfrEyK0dN xjiLkJdRPvMA0z69DEfw8rz8E1pV7X5kFYNBgjsDdnqzm16JHjXj5po8r+qKn4VMixno aS89tE0mOSwFshh+FejorxsxLsGYPFMhQFCDvr1gRcrrjwDKjMDKF3t2S6f31a/O3IiL RQNiJdgjAH0daedcTgqPKqwTYAg/OZa6JQZimGp9hBzh/LJFn6ob46EKEA0C02RgqC8O cFAhYE8E6T5dgWK29TZMQuP5A0+kT/Q6ckbk+nBknwWQaBfgpy4HrDC7YSUaQ4YDzi3V NXyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to:arc-authentication-results; bh=iIfaCzA0Qr6EUedL+LS8Au1evvDe5hxw0Rlrz90tWK8=; b=gDUio8hIWDx8aXl2Qj6pIYW8+MrqJN4HpWfuBbRQ8VH7Rr8DUgrV1MgeuJWgwee8Cj D7wplhqWo2awimoECf64GZlyJhm8WACmJ4+N+qJ19yCtgBpx4i+lA9zUPcGpztcbtoBU 8nKDsli/kcf92SkLuZDFFFLWojSfjVNFOTszzEJL737++CwoKA4hQsIz3UGeY+/3RJvP 7BVaVbde2FprSg0hZauZ3TfLZCpTCPnq7V9vdl2vHB/jGQE2hsWMkC47HXVq4TlTI4SK OlxDtMwj+ziKhXj2jNet+zYUEGevagpWDJfclylkNAd2XkSZqVrQasa/h1JKgHaUeZXW B3Yw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id x75si3095079wme.209.2017.12.06.22.25.58; Wed, 06 Dec 2017 22:25:58 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A06AC68A190; Thu, 7 Dec 2017 08:25:46 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 76B316898B7 for ; Thu, 7 Dec 2017 08:25:40 +0200 (EET) Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Dec 2017 22:25:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,371,1508828400"; d="scan'208";a="615210" Received: from unknown (HELO localhost.localdomain.sh.intel.com) ([10.239.13.18]) by fmsmga008.fm.intel.com with ESMTP; 06 Dec 2017 22:25:38 -0800 From: Zhong Li To: ffmpeg-devel@ffmpeg.org Date: Thu, 7 Dec 2017 14:24:20 +0800 Message-Id: <1512627860-19796-2-git-send-email-zhong.li@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1512627860-19796-1-git-send-email-zhong.li@intel.com> References: <1512627860-19796-1-git-send-email-zhong.li@intel.com> Subject: [FFmpeg-devel] [PATCH 2/2] lavc/qsvenc: add error messeage if ICQ unsupported. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhong Li MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Signed-off-by: Zhong Li --- libavcodec/qsvenc.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index fbd4d85..f4c8df4 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c @@ -287,6 +287,12 @@ static int select_rc_mode(AVCodecContext *avctx, QSVEncContext *q) return AVERROR(EINVAL); } + if (!want_qscale && avctx->global_quality > 0 && !QSV_HAVE_ICQ){ + av_log(avctx, AV_LOG_ERROR, + "ICQ ratecontrol mode requested, but is not supported by this SDK version\n"); + return AVERROR(ENOSYS); + } + if (want_qscale) { rc_mode = MFX_RATECONTROL_CQP; rc_desc = "constant quantization parameter (CQP)";