| Message ID | 20160923050408.3856-1-jamrial@gmail.com |
|---|---|
| State | Accepted |
| Commit | 75a13115cd6b961f4f6779423353c1cf25db4c0e |
| Headers | show |
On Fri, Sep 23, 2016 at 02:04:08AM -0300, James Almer wrote: > autobsf has been ported to the new bsf API. > > Signed-off-by: James Almer <jamrial@gmail.com> > --- > libavformat/mux.c | 6 ------ > 1 file changed, 6 deletions(-) has this patch been forgotten ? [...]
On 11/5/2016 9:46 PM, Michael Niedermayer wrote: > On Fri, Sep 23, 2016 at 02:04:08AM -0300, James Almer wrote: >> autobsf has been ported to the new bsf API. >> >> Signed-off-by: James Almer <jamrial@gmail.com> >> --- >> libavformat/mux.c | 6 ------ >> 1 file changed, 6 deletions(-) > > has this patch been forgotten ? It didn't get a review, and then we began working on the ffmpeg bsf port so i kinda forgot, yeah. Will re-run fate with it now that we have a better autobsf coverage and apply it if it passes.
On 11/5/2016 9:49 PM, James Almer wrote: > On 11/5/2016 9:46 PM, Michael Niedermayer wrote: >> On Fri, Sep 23, 2016 at 02:04:08AM -0300, James Almer wrote: >>> autobsf has been ported to the new bsf API. >>> >>> Signed-off-by: James Almer <jamrial@gmail.com> >>> --- >>> libavformat/mux.c | 6 ------ >>> 1 file changed, 6 deletions(-) >> >> has this patch been forgotten ? > > It didn't get a review, and then we began working on the ffmpeg bsf > port so i kinda forgot, yeah. > Will re-run fate with it now that we have a better autobsf coverage > and apply it if it passes. FATE passes, so applied.
diff --git a/libavformat/mux.c b/libavformat/mux.c index bbfc0fc..79fbbfc 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.c @@ -309,12 +309,6 @@ FF_DISABLE_DEPRECATION_WARNINGS FF_ENABLE_DEPRECATION_WARNINGS #endif - /* update internal context from codecpar, old bsf api needs this - * FIXME: remove when autobsf uses new bsf API */ - ret = avcodec_parameters_to_context(st->internal->avctx, st->codecpar); - if (ret < 0) - goto fail; - if (!st->time_base.num) { /* fall back on the default timebase values */ if (par->codec_type == AVMEDIA_TYPE_AUDIO && par->sample_rate)
autobsf has been ported to the new bsf API. Signed-off-by: James Almer <jamrial@gmail.com> --- libavformat/mux.c | 6 ------ 1 file changed, 6 deletions(-)