diff mbox

[FFmpeg-devel,1/6] fate: add atrac3p conversion test

Message ID 20171231094607.68768-2-misty@brew.sh
State Superseded
Headers show

Commit Message

misty@brew.sh Dec. 31, 2017, 9:46 a.m. UTC
From: Misty De Meo <mistydemeo@gmail.com>

---
 tests/fate/atrac.mak | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Michael Niedermayer Jan. 2, 2018, 9:24 p.m. UTC | #1
On Sun, Dec 31, 2017 at 05:46:02PM +0800, misty@brew.sh wrote:
> From: Misty De Meo <mistydemeo@gmail.com>
> 
> ---
>  tests/fate/atrac.mak | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/fate/atrac.mak b/tests/fate/atrac.mak
> index acf79a539c..1707373890 100644
> --- a/tests/fate/atrac.mak
> +++ b/tests/fate/atrac.mak
> @@ -31,6 +31,10 @@ FATE_ATRAC3P += fate-atrac3p-2
>  fate-atrac3p-2: CMD = pcm -i $(TARGET_SAMPLES)/atrac3p/sonateno14op27-2-cut.aa3
>  fate-atrac3p-2: REF = $(SAMPLES)/atrac3p/sonateno14op27-2-cut.pcm
>  
> +FATE_ATRAC3P += fate-atrac3p-3
> +fate-atrac3p-3: CMD = pcm -i $(TARGET_SAMPLES)/atrac3p/bgm01.at3
> +fate-atrac3p-3: REF = $(SAMPLES)/atrac3p/bgm01.s16

the reference file is a bit big but test works andf LGTM 


[...]
Zhanbang He Jan. 6, 2018, 4:16 a.m. UTC | #2
On Wed, Jan 3, 2018 at 5:24 AM, Michael Niedermayer <michael@niedermayer.cc>
wrote:

> On Sun, Dec 31, 2017 at 05:46:02PM +0800, misty@brew.sh wrote:
> > From: Misty De Meo <mistydemeo@gmail.com>
> >
> > ---
> >  tests/fate/atrac.mak | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/tests/fate/atrac.mak b/tests/fate/atrac.mak
> > index acf79a539c..1707373890 100644
> > --- a/tests/fate/atrac.mak
> > +++ b/tests/fate/atrac.mak
> > @@ -31,6 +31,10 @@ FATE_ATRAC3P += fate-atrac3p-2
> >  fate-atrac3p-2: CMD = pcm -i $(TARGET_SAMPLES)/atrac3p/
> sonateno14op27-2-cut.aa3
> >  fate-atrac3p-2: REF = $(SAMPLES)/atrac3p/sonateno14op27-2-cut.pcm
> >
> > +FATE_ATRAC3P += fate-atrac3p-3
> > +fate-atrac3p-3: CMD = pcm -i $(TARGET_SAMPLES)/atrac3p/bgm01.at3
> > +fate-atrac3p-3: REF = $(SAMPLES)/atrac3p/bgm01.s16
>
> the reference file is a bit big but test works andf LGTM
>
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> The educated differ from the uneducated as much as the living from the
> dead. -- Aristotle
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>
how to run the test?
diff mbox

Patch

diff --git a/tests/fate/atrac.mak b/tests/fate/atrac.mak
index acf79a539c..1707373890 100644
--- a/tests/fate/atrac.mak
+++ b/tests/fate/atrac.mak
@@ -31,6 +31,10 @@  FATE_ATRAC3P += fate-atrac3p-2
 fate-atrac3p-2: CMD = pcm -i $(TARGET_SAMPLES)/atrac3p/sonateno14op27-2-cut.aa3
 fate-atrac3p-2: REF = $(SAMPLES)/atrac3p/sonateno14op27-2-cut.pcm
 
+FATE_ATRAC3P += fate-atrac3p-3
+fate-atrac3p-3: CMD = pcm -i $(TARGET_SAMPLES)/atrac3p/bgm01.at3
+fate-atrac3p-3: REF = $(SAMPLES)/atrac3p/bgm01.s16
+
 FATE_ATRAC3P-$(call DEMDEC, OMA, ATRAC3P) += $(FATE_ATRAC3P)
 
 FATE_ATRAC_ALL = $(FATE_ATRAC1-yes) $(FATE_ATRAC3-yes) $(FATE_ATRAC3P-yes)