From patchwork Thu Jan 4 04:38:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 7117 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.79.195 with SMTP id r64csp16717952jad; Wed, 3 Jan 2018 20:44:44 -0800 (PST) X-Google-Smtp-Source: ACJfBovG12iKpNGGvMZjyDvY8GDLXWnrKZM90zQ9yz7+6Ep4R6VJnf2wfpTVngKyOge4R3PC2tkb X-Received: by 10.28.62.5 with SMTP id l5mr2997242wma.47.1515041084027; Wed, 03 Jan 2018 20:44:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515041083; cv=none; d=google.com; s=arc-20160816; b=B4H3QiYSjeNlEJ1hRCKv//VFIazWfoIp0FvXoVRxqd946xH0nRGnt+t3l8O1o96h4U pxKEh2osaoF99K+dqRoAec2uadDkqSffEyRWn4ac3F66WUEH9i4B86WRmvvOsEHVz4Ms 8yEXMsb74QC2ILVRMotJ2tUAcY6oVlahR5Ujbkpc7yk3SW8e+ZJHP8yJYV0cQOTvZeWj Tx8rtbyeRQ3OmLpmEa0Ktg+gVLeIo4s5whSHLnyl/scMUty3X6z/n4O1ONH9v50lQ+SH AyuOBtloF+rGR8Rm7HpvZXXO04KY561HxFSuIQc2OqhvbLuU584xmWvMrzGZtEj5YIbl Z6EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:to :message-id:date:from:mime-version:dkim-signature:delivered-to :arc-authentication-results; bh=J0+iE5JpehnUqJPZWDI4iDi/vTHzstNLlulOZ6Z84hI=; b=b8mK0fG4fsyQTZ4n+0L+tt6u5mgZX/ClPmjXJ+KV9caMKtPXoFWE8FjFKus116TAtT VOAJASwl3BFpnFVnaYpx3aL5JcwybTtQP6vBM8gYnfi5WVN7/4AU7Gy7e2gVRkLbJLMM aEJz+ZzD79xcuDdvZ8MwwgUOE0eDl3wqDLu7s23OfxSjejxMdi1HnmldDLhoWDhBwVFl 4b9399v8XB5TJrkLKMKEumvPwV0SlkhBK47b9ZgGgf+WSkOmb3GYScffcSxO1yyq8HOz mvCG7WZK0tc+XFGsl9B30gZVViwdDdedDU8B/GtghAGjqApoRXngfv8Efj++AGqmhRF5 3V5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=orX5xlFK; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id z4si1645551wmh.150.2018.01.03.20.44.43; Wed, 03 Jan 2018 20:44:43 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=orX5xlFK; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CC0D86898B5; Thu, 4 Jan 2018 06:44:25 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-it0-f47.google.com (mail-it0-f47.google.com [209.85.214.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CA7C368975F for ; Thu, 4 Jan 2018 06:44:18 +0200 (EET) Received: by mail-it0-f47.google.com with SMTP id m11so449954iti.1 for ; Wed, 03 Jan 2018 20:44:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=WU4bo4EUYTA+huRNhGRYPgDQJj27QTA56d9dwQ5123g=; b=orX5xlFKeAE09IqjKlYT95Hdbmzw2sPOakEHjydSzX6sbit5FVbn1p2BzY0HT2fkfq A2Vr7ji7nlrMZOydhsNdixnplIavAoRA/U1mKLkFHI915+AyjdG8xoADXWS11D2JVZOL XIHwBhKxTYEh+O/F7tSrkmUf37ZcE3+16JcmqDp2uUqkBcehSJL8q2OcoCgmfVAnMX04 l4PGFsDU9GxXMvIoc26Y3oQ4c8PLxyQKQrDJ4MUwv3y/9p318ClxbLX8tKXVFiEgT+EC CVFKShiXYrNRokhzXYZWZ8cJ4tQsvM+xW3mxII7nIIOQJKibkng88i8lXNci7k4PBHtr 8MUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=WU4bo4EUYTA+huRNhGRYPgDQJj27QTA56d9dwQ5123g=; b=qEto8SUFP/exe47+P5FYGRYBlBJYq7Aqk9w3/NXms952DxPbVy9g8ym5wQ0EU4Umvt O35QxN7CKPVEDJQGJvj+Ycx5rG+qe6fxZlm7K6bzgA3G2r+xRyujtt7shomBd/t4FXrH lKCH27Jq84Bcur6Oc7g85P6lcxsyYNoDa2y4U9mzlwRjtOcUUDL8qZiIhDZNbgjdCIyK HK5Ya6gkuayQC7bSDw1daUzBkx75omlfO268bGcbfHOxiPl4P4+L7SyygzflTaJa0NV8 IY/EhKj2xXMYqp3EwEsKjnKK46Cy3+++glbOasRiwtGVVGUvR57688rOH/tTa7AKKLFZ R79w== X-Gm-Message-State: AKGB3mIYOVToP5nsiJC4KcoIHasSWmmbijFoYNsmYrjkJlwn8O45nfDY 4CQHc/J3IIoYZSee6y90jtZ5fcogb0nhs49Sk9Y= X-Received: by 10.36.68.76 with SMTP id o73mr4078053ita.4.1515040732412; Wed, 03 Jan 2018 20:38:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.2.119.211 with HTTP; Wed, 3 Jan 2018 20:38:31 -0800 (PST) From: Carl Eugen Hoyos Date: Thu, 4 Jan 2018 05:38:31 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH]lavc/opusenc_psy: Remove a write-only variable X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! Attached patch fixes a warning here when compiling the opus encoder. Please comment, Carl Eugen From 605194d85651b76586c8f14cf8034a266e9fc8fd Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Thu, 4 Jan 2018 05:36:38 +0100 Subject: [PATCH] lavc/opusenc_psy: Remove a write-only variable. Fixes a warning: libavcodec/opusenc_psy.c:407:5: warning: ISO C90 forbids mixed declarations and code --- libavcodec/opusenc_psy.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/opusenc_psy.c b/libavcodec/opusenc_psy.c index b712603..622f15c 100644 --- a/libavcodec/opusenc_psy.c +++ b/libavcodec/opusenc_psy.c @@ -404,9 +404,7 @@ static void celt_search_for_intensity(OpusPsyContext *s, CeltFrame *f) return; /* TODO: fix, make some heuristic up here using the lambda value */ - float end_band = 0; - - for (i = f->end_band; i >= end_band; i--) { + for (i = f->end_band; i >= 0; i--) { f->intensity_stereo = i; bands_dist(s, f, &dist); if (best_dist > dist) { -- 1.7.10.4